* [PATCH v2] drm: Fix the length of event_string in drm_dev_wedged_event()
@ 2025-04-08 11:27 jiangfeng
2025-04-08 14:08 ` Raag Jadav
0 siblings, 1 reply; 2+ messages in thread
From: jiangfeng @ 2025-04-08 11:27 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
rodrigo.vivi, christian.koenig, raag.jadav, andrealmeid
Cc: dri-devel, linux-kernel, Feng Jiang
From: Feng Jiang <jiangfeng@kylinos.cn>
When calling scnprintf() to append recovery method to event_string,
the second argument should be `sizeof(event_string) - len`, otherwise
there is a potential overflow problem.
Fixes: b7cf9f4ac1b8 ("drm: Introduce device wedged event")
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
---
v2:
- update commit message
- keep scnprintf() as a single line
---
drivers/gpu/drm/drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 17fc5dc708f4..60e5ac179c15 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -549,7 +549,7 @@ int drm_dev_wedged_event(struct drm_device *dev, unsigned long method)
if (drm_WARN_ONCE(dev, !recovery, "invalid recovery method %u\n", opt))
break;
- len += scnprintf(event_string + len, sizeof(event_string), "%s,", recovery);
+ len += scnprintf(event_string + len, sizeof(event_string) - len, "%s,", recovery);
}
if (recovery)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] drm: Fix the length of event_string in drm_dev_wedged_event()
2025-04-08 11:27 [PATCH v2] drm: Fix the length of event_string in drm_dev_wedged_event() jiangfeng
@ 2025-04-08 14:08 ` Raag Jadav
0 siblings, 0 replies; 2+ messages in thread
From: Raag Jadav @ 2025-04-08 14:08 UTC (permalink / raw)
To: jiangfeng
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
rodrigo.vivi, christian.koenig, andrealmeid, dri-devel,
linux-kernel
On Tue, Apr 08, 2025 at 07:27:28PM +0800, jiangfeng@kylinos.cn wrote:
> From: Feng Jiang <jiangfeng@kylinos.cn>
>
> When calling scnprintf() to append recovery method to event_string,
> the second argument should be `sizeof(event_string) - len`, otherwise
> there is a potential overflow problem.
Thanks. Perhaps change the subject to reflect this as well?
Raag
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-08 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-08 11:27 [PATCH v2] drm: Fix the length of event_string in drm_dev_wedged_event() jiangfeng
2025-04-08 14:08 ` Raag Jadav
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.