nvmetcli creates tilde directories

nvmetcli creates tilde directories

[Richard Weinberger]

Hi!

After playing with nvmetcli, I noticed that my home directory was sprinkled
with directories named "~".
It seems like configshell used by nvmetcli does not resolve "~" to my home directory.

From the source:
shell = configshell.shell.ConfigShell('~/.nvmetcli')

Is this a known issue, or is it a misconfiguration on my side?
FWIW, I'm on openSUSE Tumbleweed.

Thanks,
//richard

Re: nvmetcli creates tilde directories

[Maurizio Lombardi]

On Wed Apr 9, 2025 at 9:43 AM CEST, Richard Weinberger wrote:
> Hi!
>
> After playing with nvmetcli, I noticed that my home directory was sprinkled
> with directories named "~".
> It seems like configshell used by nvmetcli does not resolve "~" to my home directory.

Is this a regression? Which version of configshell is Tumbleweed
running?

There were some large changes to configshell upstream recently so I am
wondering if something has been broken.

Maurizio

Re: nvmetcli creates tilde directories

[Richard Weinberger]

Maurizio,

----- Ursprüngliche Mail -----
> Is this a regression? Which version of configshell is Tumbleweed
> running?

Dunno. It was the very first time I used nvmetcli.
Tumbleweed shipps configshell-fb 2.0.0.
 
> There were some large changes to configshell upstream recently so I am
> wondering if something has been broken.

This would make sense.

Thanks,
//richard

Re: nvmetcli creates tilde directories

[Maurizio Lombardi]

On Wed Apr 9, 2025 at 10:53 AM CEST, Richard Weinberger wrote:
> Maurizio,
>
> ----- Ursprüngliche Mail -----
>> Is this a regression? Which version of configshell is Tumbleweed
>> running?
>
> Dunno. It was the very first time I used nvmetcli.
> Tumbleweed shipps configshell-fb 2.0.0.
>

Ok, 2.0.0 switched to Pathlib library and
I see where the bug is now.

A patch is gonna be pushed soon.

Thanks,
Maurizio

Re: nvmetcli creates tilde directories

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
> A patch is gonna be pushed soon.

Where is your git tree located?
I'm a but puzzled where to look for the most recent nvmetcli sources.

Thanks,
//richard

Re: nvmetcli creates tilde directories

[Maurizio Lombardi]

On Wed Apr 9, 2025 at 1:32 PM CEST, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
>> A patch is gonna be pushed soon.
>
> Where is your git tree located?
> I'm a but puzzled where to look for the most recent nvmetcli sources.

The official nvmetcli repository should be the following one:
http://git.infradead.org/users/hch/nvmetcli.git

But the patch I am talking about will have to be pushed to
configshell (it's on Github):

https://github.com/open-iscsi/configshell-fb

Maurizio

Re: nvmetcli creates tilde directories

[Maurizio Lombardi]

On Wed Apr 9, 2025 at 10:56 AM CEST, Maurizio Lombardi wrote:
>
> Ok, 2.0.0 switched to Pathlib library and
> I see where the bug is now.
>
> A patch is gonna be pushed soon.
>

FYI, I merged a patch in configshell that should
fix this bug.

https://github.com/open-iscsi/configshell-fb/pull/84

Thanks,
Maurizio

Re: nvmetcli creates tilde directories

[Christoph Hellwig]

On Wed, Apr 09, 2025 at 10:11:24AM +0200, Maurizio Lombardi wrote:
> On Wed Apr 9, 2025 at 9:43 AM CEST, Richard Weinberger wrote:
> > Hi!
> >
> > After playing with nvmetcli, I noticed that my home directory was sprinkled
> > with directories named "~".
> > It seems like configshell used by nvmetcli does not resolve "~" to my home directory.
> 
> Is this a regression? Which version of configshell is Tumbleweed
> running?
> 
> There were some large changes to configshell upstream recently so I am
> wondering if something has been broken.

FYI, I recently had a ~ directory show up in my home directory as well,
but didn't manage to track it down.  I've not used nvmetcli on that
system, but did use targetcli so configshell would be involved as well.
This is on a debian unstable system using configshell-fb 1:2.0.0-1.

Re: nvmetcli creates tilde directories

[Maurizio Lombardi]

On Wed Apr 9, 2025 at 9:43 AM CEST, Richard Weinberger wrote:
> Hi!
>
> After playing with nvmetcli, I noticed that my home directory was sprinkled
> with directories named "~".
> It seems like configshell used by nvmetcli does not resolve "~" to my home directory.
>

I released configshell version v2.0.2, it should fix this bug.

Thanks,
Maurizio

Re: nvmetcli creates tilde directories

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Maurizio Lombardi" <mlombard@bsdbackstore.eu>
>> After playing with nvmetcli, I noticed that my home directory was sprinkled
>> with directories named "~".
>> It seems like configshell used by nvmetcli does not resolve "~" to my home
>> directory.
>>
> 
> I released configshell version v2.0.2, it should fix this bug.

Nice, thx!
Let's hope distros will pickup the fix soon.

Thanks,
//richard