[meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

[meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

[Theodore A. Roth]

The insane.bbclass now flags as errors when PACKAGECONFIG contains a
value that does not have a setting.

For example, setting a value like this:

    PACKAGECONFIG += "foo"

without something like this in the recipe:

    PACKAGECONFIG[foo] = "stuff"

will result in QA errors like the following:

    ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
           invalid PACKAGECONFIG(s): docker rootless [invalid-packageconfig]
    ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found, failing task.

Signed-off-by: Theodore A. Roth <troth@openavr.org>
Signed-off-by: Theodore A. Roth <theodore_roth@trimble.com>
---
 recipes-containers/podman/podman_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
index be85e512..9f886ed4 100644
--- a/recipes-containers/podman/podman_git.bb
+++ b/recipes-containers/podman/podman_git.bb
@@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
 # packageconfig, the podman package will rconfict with docker.
 PACKAGECONFIG ?= "docker"
 
+PACKAGECONFIG[docker] ?= ""
+PACKAGECONFIG[rootless] ?= ""
+
 do_compile() {
 	cd ${S}/src
 	rm -rf .gopath
-- 
2.34.1

Re: [meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

[Bruce Ashfield]

I went a different way with this.

docker shouldnt' really be a packageconfig, and rootless was adding
an rdepends later .. when it could have just been done in a compliant
way in the PACKAGECONFIG.

Bruce

In message: [meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG
on 09/04/2025 Theodore A. Roth via lists.yoctoproject.org wrote:

> The insane.bbclass now flags as errors when PACKAGECONFIG contains a
> value that does not have a setting.
> 
> For example, setting a value like this:
> 
>     PACKAGECONFIG += "foo"
> 
> without something like this in the recipe:
> 
>     PACKAGECONFIG[foo] = "stuff"
> 
> will result in QA errors like the following:
> 
>     ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
>            invalid PACKAGECONFIG(s): docker rootless [invalid-packageconfig]
>     ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found, failing task.
> 
> Signed-off-by: Theodore A. Roth <troth@openavr.org>
> Signed-off-by: Theodore A. Roth <theodore_roth@trimble.com>
> ---
>  recipes-containers/podman/podman_git.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> index be85e512..9f886ed4 100644
> --- a/recipes-containers/podman/podman_git.bb
> +++ b/recipes-containers/podman/podman_git.bb
> @@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
>  # packageconfig, the podman package will rconfict with docker.
>  PACKAGECONFIG ?= "docker"
>  
> +PACKAGECONFIG[docker] ?= ""
> +PACKAGECONFIG[rootless] ?= ""
> +
>  do_compile() {
>  	cd ${S}/src
>  	rm -rf .gopath
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9211): https://lists.yoctoproject.org/g/meta-virtualization/message/9211
> Mute This Topic: https://lists.yoctoproject.org/mt/112173803/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [meta-virtualization][PATCH] podman: Fix QA error for invalid PACKAGECONFIG

[Theodore A. Roth]

[-- Attachment #1: Type: text/plain, Size: 2515 bytes --]

I like your fix over mine. Mine felt hacky and with your changes it doesn't
feel like the PACKAGECONFIG mechanism is being abused.

Thanks!

Ted Roth

On Wed, Apr 9, 2025 at 2:53 PM Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:

> I went a different way with this.
>
> docker shouldnt' really be a packageconfig, and rootless was adding
> an rdepends later .. when it could have just been done in a compliant
> way in the PACKAGECONFIG.
>
> Bruce
>
> In message: [meta-virtualization][PATCH] podman: Fix QA error for invalid
> PACKAGECONFIG
> on 09/04/2025 Theodore A. Roth via lists.yoctoproject.org wrote:
>
> > The insane.bbclass now flags as errors when PACKAGECONFIG contains a
> > value that does not have a setting.
> >
> > For example, setting a value like this:
> >
> >     PACKAGECONFIG += "foo"
> >
> > without something like this in the recipe:
> >
> >     PACKAGECONFIG[foo] = "stuff"
> >
> > will result in QA errors like the following:
> >
> >     ERROR: podman-v5.4.1-r0 do_recipe_qa: QA Issue: podman:
> >            invalid PACKAGECONFIG(s): docker rootless
> [invalid-packageconfig]
> >     ERROR: podman-v5.4.1-r0 do_recipe_qa: Fatal QA errors were found,
> failing task.
> >
> > Signed-off-by: Theodore A. Roth <troth@openavr.org>
> > Signed-off-by: Theodore A. Roth <theodore_roth@trimble.com>
> > ---
> >  recipes-containers/podman/podman_git.bb | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/recipes-containers/podman/podman_git.bb
> b/recipes-containers/podman/podman_git.bb
> > index be85e512..9f886ed4 100644
> > --- a/recipes-containers/podman/podman_git.bb
> > +++ b/recipes-containers/podman/podman_git.bb
> > @@ -70,6 +70,9 @@ EXTRA_OEMAKE = " \
> >  # packageconfig, the podman package will rconfict with docker.
> >  PACKAGECONFIG ?= "docker"
> >
> > +PACKAGECONFIG[docker] ?= ""
> > +PACKAGECONFIG[rootless] ?= ""
> > +
> >  do_compile() {
> >       cd ${S}/src
> >       rm -rf .gopath
> > --
> > 2.34.1
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#9211):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9211
> > Mute This Topic: https://lists.yoctoproject.org/mt/112173803/1050810
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [bruce.ashfield@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>

[-- Attachment #2: Type: text/html, Size: 4250 bytes --]