[PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Aditya Garg]

From: Aditya Garg <gargaditya08@live.com>

The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
The M1 Macs have a separate driver. So, lets avoid compiling it for
other architectures.

Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 drivers/gpu/drm/tiny/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index 95c1457d7..d66681d0e 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -3,6 +3,7 @@
 config DRM_APPLETBDRM
 	tristate "DRM support for Apple Touch Bars"
 	depends on DRM && USB && MMU
+	depends on X86 || COMPILE_TEST
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	help
-- 
2.49.0

Re: [PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Alyssa Rosenzweig]

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>

Le Thu , Apr 10, 2025 at 11:50:01PM +0530, Aditya Garg a écrit :
> From: Aditya Garg <gargaditya08@live.com>
> 
> The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
> The M1 Macs have a separate driver. So, lets avoid compiling it for
> other architectures.
> 
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  drivers/gpu/drm/tiny/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
> index 95c1457d7..d66681d0e 100644
> --- a/drivers/gpu/drm/tiny/Kconfig
> +++ b/drivers/gpu/drm/tiny/Kconfig
> @@ -3,6 +3,7 @@
>  config DRM_APPLETBDRM
>  	tristate "DRM support for Apple Touch Bars"
>  	depends on DRM && USB && MMU
> +	depends on X86 || COMPILE_TEST
>  	select DRM_GEM_SHMEM_HELPER
>  	select DRM_KMS_HELPER
>  	help
> -- 
> 2.49.0
> 

Re: [PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Alyssa Rosenzweig]

On Thu, 10 Apr 2025 23:50:01 +0530, Aditya Garg wrote:
> The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
> The M1 Macs have a separate driver. So, lets avoid compiling it for
> other architectures.
> 
> 

Applied, thanks!

[1/1] drm/appletbdrm: Make appletbdrm depend on X86
      commit: de5fbbe1531f645c8b56098be8d1faf31e46f7f0

Best regards,
-- 
Alyssa Rosenzweig <alyssa@rosenzweig.io>

[PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Aditya Garg]

commit de5fbbe1531f645c8b56098be8d1faf31e46f7f0 upstream

The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
The M1 Macs have a separate driver. So, lets avoid compiling it for
other architectures.

Signed-off-by: Aditya Garg <gargaditya08@live.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://lore.kernel.org/r/PN3PR01MB95970778982F28E4A3751392B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
---
Sending this since https://lore.kernel.org/stable/20250617152509.019353397@linuxfoundation.org/
was also backported to 6.15

 drivers/gpu/drm/tiny/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index 95c1457d7..d66681d0e 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -3,6 +3,7 @@
 config DRM_APPLETBDRM
 	tristate "DRM support for Apple Touch Bars"
 	depends on DRM && USB && MMU
+	depends on X86 || COMPILE_TEST
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	help
-- 
2.49.0

Re: [PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Greg Kroah-Hartman]

On Wed, Jun 18, 2025 at 11:27:36AM +0530, Aditya Garg wrote:
> commit de5fbbe1531f645c8b56098be8d1faf31e46f7f0 upstream
> 
> The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
> The M1 Macs have a separate driver. So, lets avoid compiling it for
> other architectures.
> 
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> Link: https://lore.kernel.org/r/PN3PR01MB95970778982F28E4A3751392B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM
> Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> ---
> Sending this since https://lore.kernel.org/stable/20250617152509.019353397@linuxfoundation.org/
> was also backported to 6.15

What stable tree(s) is this for?

thanks,

greg k-h

Re: [PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Aditya Garg]

On 18-06-2025 11:35 am, Greg Kroah-Hartman wrote:
> On Wed, Jun 18, 2025 at 11:27:36AM +0530, Aditya Garg wrote:
>> commit de5fbbe1531f645c8b56098be8d1faf31e46f7f0 upstream
>>
>> The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
>> The M1 Macs have a separate driver. So, lets avoid compiling it for
>> other architectures.
>>
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
>> Link: https://lore.kernel.org/r/PN3PR01MB95970778982F28E4A3751392B8B72@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM
>> Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
>> ---
>> Sending this since https://lore.kernel.org/stable/20250617152509.019353397@linuxfoundation.org/
>> was also backported to 6.15
> 
> What stable tree(s) is this for?

Just 6.15

Re: [PATCH] drm/appletbdrm: Make appletbdrm depend on X86

[Sasha Levin]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: de5fbbe1531f645c8b56098be8d1faf31e46f7f0

Note: The patch differs from the upstream commit:
---
1:  de5fbbe1531f6 ! 1:  4d7bd53570467 drm/appletbdrm: Make appletbdrm depend on X86
    @@ Metadata
      ## Commit message ##
         drm/appletbdrm: Make appletbdrm depend on X86
     
    +    commit de5fbbe1531f645c8b56098be8d1faf31e46f7f0 upstream
    +
         The appletbdrm driver is exclusively for Touch Bars on x86 Intel Macs.
         The M1 Macs have a separate driver. So, lets avoid compiling it for
         other architectures.
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.15.y       |  Success    |  Success   |
| stable/linux-6.12.y       |  Success    |  Success   |
| stable/linux-6.6.y        |  Success    |  Success   |
| stable/linux-6.1.y        |  Success    |  Success   |
| stable/linux-5.15.y       |  Success    |  Success   |
| stable/linux-5.10.y       |  Success    |  Success   |
| stable/linux-5.4.y        |  Success    |  Success   |