Re: [PATCH] perf symbols: Ignore mapping symbols on riscv

From: Namhyung Kim <namhyung@kernel.org>
To: Haibo Xu <haibo1.xu@intel.com>
Cc: xiaobo55x@gmail.com, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH] perf symbols: Ignore mapping symbols on riscv
Date: Thu, 10 Apr 2025 17:53:51 -0700	[thread overview]
Message-ID: <Z_hoH0fu_NnEUUfe@google.com> (raw)
In-Reply-To: <20250409025202.201046-1-haibo1.xu@intel.com>

Hello,

On Wed, Apr 09, 2025 at 10:51:56AM +0800, Haibo Xu wrote:
> RISCV ELF use mapping symbols with special names $x, $d to
> identify regions of RISCV code or code with different ISAs[1].
> These symbols don't identify functions, so will confuse the
> perf output.
> 
> The patch filters out these symbols at load time, similar to
> "4886f2ca perf symbols: Ignore mapping symbols on aarch64".
> 
> [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/
>     master/riscv-elf.adoc#mapping-symbol
> 
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/util/symbol-elf.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> index fbf6d0f73af9..55b1409b0593 100644
> --- a/tools/perf/util/symbol-elf.c
> +++ b/tools/perf/util/symbol-elf.c
> @@ -1733,6 +1733,12 @@ dso__load_sym_internal(struct dso *dso, struct map *map, struct symsrc *syms_ss,
>  				continue;
>  		}
>  
> +		/* Reject RISCV ELF "mapping symbols" */
> +		if (ehdr.e_machine == EM_RISCV) {
> +			if (elf_name[0] == '$' && strchr("dx", elf_name[1]))
> +				continue;
> +		}
> +
>  		if (runtime_ss->opdsec && sym.st_shndx == runtime_ss->opdidx) {
>  			u32 offset = sym.st_value - syms_ss->opdshdr.sh_addr;
>  			u64 *opd = opddata->d_buf + offset;
> -- 
> 2.43.0
>