Re: [PATCH] drm/i915: don't capture DERRMR for VLV/CHV

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Apr 11, 2025 at 10:08:23AM +0300, Jani Nikula wrote:
> DERRMR isn't valid for VLV/CHV. Don't capture it for them.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index f5dc050a6344..5d07b6a9e59e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -2343,7 +2343,7 @@ intel_display_irq_snapshot_capture(struct intel_display *display)
>  	if (!snapshot)
>  		return NULL;
>  
> -	if (DISPLAY_VER(display) >= 6 && DISPLAY_VER(display) < 20)
> +	if (DISPLAY_VER(display) >= 6 && DISPLAY_VER(display) < 20 && !HAS_GMCH(display))
>  		snapshot->derrmr = intel_de_read(display, DERRMR);
>  
>  	return snapshot;
> -- 
> 2.39.5

-- 
Ville Syrjälä
Intel