From: Ingo Molnar <mingo@kernel.org>
To: Mario Limonciello <superm1@kernel.org>
Cc: "Borislav Petkov" <bp@alien8.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Yazen Ghannam" <yazen.ghannam@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC"
<linux-i2c@vger.kernel.org>,
"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h
Date: Sat, 12 Apr 2025 22:47:40 +0200 [thread overview]
Message-ID: <Z_rRbNu9v2qIBDVJ@gmail.com> (raw)
In-Reply-To: <0cb8bbf3-3f63-486a-97a0-9e1c162cef06@kernel.org>
* Mario Limonciello <superm1@kernel.org> wrote:
> > and ... I'm sure you knew this was coming, but we should probably
> > move *all* basic FCH_PM definitions into that header, such as
> > SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so?
>
> I'll double check how it's actually used against the documentation to
> see if this makes sense.
>
> If it's only mapping a subset of registers for the PIIX4 driver use
> bringing the definition out to a header used by other drivers that
> might need a larger or smaller subset to be mapped might not make
> sense.
Sounds good to me!
Ingo
next prev parent reply other threads:[~2025-04-12 20:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 20:01 [PATCH v3 0/4] AMD Zen debugging documentation Mario Limonciello
2025-04-10 20:01 ` [PATCH v3 1/4] Documentation: Add AMD Zen debugging document Mario Limonciello
2025-04-12 2:12 ` Bagas Sanjaya
2025-04-12 2:19 ` Mario Limonciello
2025-04-12 2:28 ` Bagas Sanjaya
2025-04-10 20:02 ` [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h Mario Limonciello
2025-04-11 11:49 ` Borislav Petkov
2025-04-11 12:09 ` Mario Limonciello
2025-04-11 12:41 ` Borislav Petkov
2025-04-12 19:44 ` Ingo Molnar
2025-04-12 19:51 ` Mario Limonciello
2025-04-12 20:15 ` Ingo Molnar
2025-04-12 20:23 ` Mario Limonciello
2025-04-12 20:47 ` Ingo Molnar [this message]
2025-04-12 22:29 ` Borislav Petkov
2025-04-13 7:54 ` Ingo Molnar
2025-04-13 8:44 ` Ingo Molnar
2025-04-13 19:27 ` Mario Limonciello
2025-04-13 19:32 ` Ingo Molnar
2025-04-11 21:15 ` kernel test robot
2025-04-11 21:56 ` kernel test robot
2025-04-10 20:02 ` [PATCH v3 3/4] platform/x86/amd: pmc: use FCH_PM_BASE definition Mario Limonciello
2025-04-10 20:02 ` [PATCH v3 4/4] x86/CPU/AMD: Print the reason for the last reset Mario Limonciello
2025-04-11 12:06 ` Borislav Petkov
2025-04-11 12:12 ` Mario Limonciello
2025-04-11 12:50 ` Borislav Petkov
2025-04-11 13:25 ` Mario Limonciello
2025-04-12 19:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_rRbNu9v2qIBDVJ@gmail.com \
--to=mingo@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.