From: Christoph Hellwig <hch@infradead.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Nhat Pham <nphamcs@gmail.com>, Miaohe Lin <linmiaohe@huawei.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Huacai Chen <chenhuacai@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
linux-mm@kvack.org, loongarch@lists.linux.dev,
Johannes Weiner <hannes@cmpxchg.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, WANG Xuerui <kernel@xen0n.name>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Chris Li <chrisl@kernel.org>
Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED
Date: Sun, 21 Jan 2024 23:42:07 -0800 [thread overview]
Message-ID: <Za4cT3tATxVlMki3@infradead.org> (raw)
In-Reply-To: <CAJD7tkaYu2+g-3y3k35KaiLEsrFVtfpSS=9uv+ic3Zwv6fTS3w@mail.gmail.com>
On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote:
> Well, better compression ratios for one :)
>
> I think a long time ago there were complaints that zsmalloc had higher
> latency than zbud/z3fold, but since then a lot of things have changed
> (including nice compaction optimization from Sergey, and compaction
> was one of the main factors AFAICT). Also, recent experiments that
> Chris Li conducted showed that (at least in our setup), the
> decompression is only a small part of the fault latency with zswap
> (i.e. not the main factor) -- so I am not sure if it actually matters
> in practice.
>
> That said, I have not conducted any experiments personally with z3fold
> or zbud, which is why I proposed the conservative approach of marking
> as deprecated first. However, if others believe this is unnecessary I
> am fine with removal as well. Whatever we agree on is fine by me.
In general deprecated is for code that has active (intentional) users
and/or would break setups. I does sound to me like that is not the
case here, but others might understand this better.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
Nhat Pham <nphamcs@gmail.com>,
linux-mm@kvack.org, Chris Li <chrisl@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
loongarch@lists.linux.dev, Johannes Weiner <hannes@cmpxchg.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, WANG Xuerui <kernel@xen0n.name>,
Vitaly Wool <vitaly.wool@konsulko.com>
Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED
Date: Sun, 21 Jan 2024 23:42:07 -0800 [thread overview]
Message-ID: <Za4cT3tATxVlMki3@infradead.org> (raw)
In-Reply-To: <CAJD7tkaYu2+g-3y3k35KaiLEsrFVtfpSS=9uv+ic3Zwv6fTS3w@mail.gmail.com>
On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote:
> Well, better compression ratios for one :)
>
> I think a long time ago there were complaints that zsmalloc had higher
> latency than zbud/z3fold, but since then a lot of things have changed
> (including nice compaction optimization from Sergey, and compaction
> was one of the main factors AFAICT). Also, recent experiments that
> Chris Li conducted showed that (at least in our setup), the
> decompression is only a small part of the fault latency with zswap
> (i.e. not the main factor) -- so I am not sure if it actually matters
> in practice.
>
> That said, I have not conducted any experiments personally with z3fold
> or zbud, which is why I proposed the conservative approach of marking
> as deprecated first. However, if others believe this is unnecessary I
> am fine with removal as well. Whatever we agree on is fine by me.
In general deprecated is for code that has active (intentional) users
and/or would break setups. I does sound to me like that is not the
case here, but others might understand this better.
next prev parent reply other threads:[~2024-01-22 7:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 19:31 [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED Yosry Ahmed
2024-01-12 19:31 ` Yosry Ahmed
2024-01-12 19:42 ` Nhat Pham
2024-01-12 19:42 ` Nhat Pham
2024-01-12 23:37 ` Yosry Ahmed
2024-01-12 23:37 ` Yosry Ahmed
2024-01-13 0:38 ` Nhat Pham
2024-01-13 0:38 ` Nhat Pham
2024-01-14 18:49 ` Yosry Ahmed
2024-01-14 18:49 ` Yosry Ahmed
2024-01-14 22:42 ` Nhat Pham
2024-01-14 22:42 ` Nhat Pham
2024-01-14 23:14 ` Yosry Ahmed
2024-01-14 23:14 ` Yosry Ahmed
2024-01-16 15:38 ` Christoph Hellwig
2024-01-16 15:38 ` Christoph Hellwig
2024-01-16 20:19 ` Yosry Ahmed
2024-01-16 20:19 ` Yosry Ahmed
2024-01-22 7:42 ` Christoph Hellwig [this message]
2024-01-22 7:42 ` Christoph Hellwig
2024-01-22 20:49 ` Yosry Ahmed
2024-01-22 20:49 ` Yosry Ahmed
2024-01-24 21:40 ` Yosry Ahmed
2024-01-24 21:40 ` Yosry Ahmed
2024-01-12 20:13 ` Nhat Pham
2024-01-12 20:13 ` Nhat Pham
2024-01-15 12:26 ` Vitaly Wool
2024-01-15 12:26 ` Vitaly Wool
2024-01-15 16:47 ` Yosry Ahmed
2024-01-15 16:47 ` Yosry Ahmed
2024-01-16 4:27 ` Sergey Senozhatsky
2024-01-16 4:27 ` Sergey Senozhatsky
2024-01-15 20:01 ` Nhat Pham
2024-01-15 20:01 ` Nhat Pham
2024-01-16 16:46 ` Chris Down
2024-01-16 16:46 ` Chris Down
2024-01-16 16:44 ` Chris Down
2024-01-16 16:44 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za4cT3tATxVlMki3@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@xen0n.name \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=minchan@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=nphamcs@gmail.com \
--cc=npiggin@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.