All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait
Date: Thu, 11 Jan 2024 09:51:16 -0500	[thread overview]
Message-ID: <ZaAAZNFrRe25Atxd@intel.com> (raw)
In-Reply-To: <20240111062518.393544-3-krishnaiah.bommu@intel.com>

On Thu, Jan 11, 2024 at 11:55:17AM +0530, Bommu Krishnaiah wrote:
> Removed drm_xe_sync data in exec_queue_reset_wait since it was declared
> and unused, 

are you sure this is unused? or this is what will force the timeout,
then reset, then the wait_user_fence to really wait to the end?

Cc: Matthew Brost

> failure Intel XE#1081

What is 'Intel XE#1081'?

> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/intel/xe_waitfence.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
> index fd515a151..2f0f00cf4 100644
> --- a/tests/intel/xe_waitfence.c
> +++ b/tests/intel/xe_waitfence.c
> @@ -248,16 +248,8 @@ exec_queue_reset_wait(int fd)
>  		uint32_t data;
>  	} *data;
>  
> -#define USER_FENCE_VALUE        0xdeadbeefdeadbeefull
> -	struct drm_xe_sync sync[1] = {
> -		{ .flags = DRM_XE_SYNC_TYPE_USER_FENCE | DRM_XE_SYNC_FLAG_SIGNAL,
> -			.timeline_value = USER_FENCE_VALUE },
> -	};
> -
>  	struct drm_xe_exec exec = {
>  		.num_batch_buffer = 1,
> -		.num_syncs = 1,
> -		.syncs = to_user_pointer(sync),
>  	};
>  
>  	uint32_t vm = xe_vm_create(fd, 0, 0);
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH v3 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait
Date: Thu, 11 Jan 2024 09:51:16 -0500	[thread overview]
Message-ID: <ZaAAZNFrRe25Atxd@intel.com> (raw)
Message-ID: <20240111145116.xDZsBW3IQ7Sgr0GGTN5jEAdIzekdWvQPNKDTsP0gbG8@z> (raw)
In-Reply-To: <20240111062518.393544-3-krishnaiah.bommu@intel.com>

On Thu, Jan 11, 2024 at 11:55:17AM +0530, Bommu Krishnaiah wrote:
> Removed drm_xe_sync data in exec_queue_reset_wait since it was declared
> and unused, 

are you sure this is unused? or this is what will force the timeout,
then reset, then the wait_user_fence to really wait to the end?

Cc: Matthew Brost

> failure Intel XE#1081

What is 'Intel XE#1081'?

> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/intel/xe_waitfence.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
> index fd515a151..2f0f00cf4 100644
> --- a/tests/intel/xe_waitfence.c
> +++ b/tests/intel/xe_waitfence.c
> @@ -248,16 +248,8 @@ exec_queue_reset_wait(int fd)
>  		uint32_t data;
>  	} *data;
>  
> -#define USER_FENCE_VALUE        0xdeadbeefdeadbeefull
> -	struct drm_xe_sync sync[1] = {
> -		{ .flags = DRM_XE_SYNC_TYPE_USER_FENCE | DRM_XE_SYNC_FLAG_SIGNAL,
> -			.timeline_value = USER_FENCE_VALUE },
> -	};
> -
>  	struct drm_xe_exec exec = {
>  		.num_batch_buffer = 1,
> -		.num_syncs = 1,
> -		.syncs = to_user_pointer(sync),
>  	};
>  
>  	uint32_t vm = xe_vm_create(fd, 0, 0);
> -- 
> 2.25.1
> 

  reply	other threads:[~2024-01-11 14:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11  6:25 [PATCH v3 0/3] tests/xe_waitfence: removed invalid_engine subtest Bommu Krishnaiah
2024-01-11  6:25 ` [PATCH v3 1/3] tests/xe_waitfence: Rename invalid_engine to invalid-exec_queue Bommu Krishnaiah
2024-01-11 14:45   ` Rodrigo Vivi
2024-01-11  6:25 ` [PATCH v3 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait Bommu Krishnaiah
2024-01-11 14:51   ` Rodrigo Vivi [this message]
2024-01-11 14:51     ` Rodrigo Vivi
2024-01-11  6:25 ` [PATCH v3 3/3] tests/xe_waitfence: Removed duplicate code in waitfence Bommu Krishnaiah
2024-01-11 14:54   ` Rodrigo Vivi
2024-01-11  7:09 ` ✓ CI.xeBAT: success for tests/xe_waitfence: removed invalid_engine subtest (rev3) Patchwork
2024-01-11  7:10 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-11  8:21 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaAAZNFrRe25Atxd@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.