All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Valentin.Schneider@arm.com,
	Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Dave Kleikamp <dave.kleikamp@oracle.com>,
	Matteo Carlini <Matteo.Carlini@arm.com>,
	akpm@linux-foundation.org, yang@os.amperecomputing.com
Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Mon, 15 Jan 2024 15:39:00 +0000	[thread overview]
Message-ID: <ZaVRlHpAOoNIiRiY@shell.armlinux.org.uk> (raw)
In-Reply-To: <794a1211-630b-3ee5-55a3-c06f10df1490@linux.com>

On Thu, Dec 14, 2023 at 04:05:56PM -0800, Christoph Lameter (Ampere) wrote:
> Index: linux/arch/arm64/Kconfig
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig
> +++ linux/arch/arm64/Kconfig
> @@ -1407,7 +1407,21 @@ config SCHED_SMT
>   config NR_CPUS
>   	int "Maximum number of CPUs (2-4096)"
>   	range 2 4096

I think your mailer got to your patch and messed up the white space.
There are two spaces before each of these lines rather than the usual
one.

> -	default "256"
> +	default 512
> +
> +#
> +# Determines the placement of cpumasks.
> +#
> +# With CPUMASK_OFFSTACK the cpumasks are dynamically allocated.
> +# Useful for machines with lots of core because it avoids increasing
> +# the size of many of the data structures in the kernel.
> +#
> +# If this is off then the cpumasks have a static sizes and are
> +# embedded within data structures.
> +#
> +config CPUMASK_OFFSTACK
> +	def_bool y
> +	depends on NR_CPUS > 256

Should that be ">= 256" ?

> 
>   config HOTPLUG_CPU
>   	bool "Support for hot-pluggable CPUs"

Same here.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Valentin.Schneider@arm.com,
	Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Dave Kleikamp <dave.kleikamp@oracle.com>,
	Matteo Carlini <Matteo.Carlini@arm.com>,
	akpm@linux-foundation.org, yang@os.amperecomputing.com
Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Mon, 15 Jan 2024 15:39:00 +0000	[thread overview]
Message-ID: <ZaVRlHpAOoNIiRiY@shell.armlinux.org.uk> (raw)
In-Reply-To: <794a1211-630b-3ee5-55a3-c06f10df1490@linux.com>

On Thu, Dec 14, 2023 at 04:05:56PM -0800, Christoph Lameter (Ampere) wrote:
> Index: linux/arch/arm64/Kconfig
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig
> +++ linux/arch/arm64/Kconfig
> @@ -1407,7 +1407,21 @@ config SCHED_SMT
>   config NR_CPUS
>   	int "Maximum number of CPUs (2-4096)"
>   	range 2 4096

I think your mailer got to your patch and messed up the white space.
There are two spaces before each of these lines rather than the usual
one.

> -	default "256"
> +	default 512
> +
> +#
> +# Determines the placement of cpumasks.
> +#
> +# With CPUMASK_OFFSTACK the cpumasks are dynamically allocated.
> +# Useful for machines with lots of core because it avoids increasing
> +# the size of many of the data structures in the kernel.
> +#
> +# If this is off then the cpumasks have a static sizes and are
> +# embedded within data structures.
> +#
> +config CPUMASK_OFFSTACK
> +	def_bool y
> +	depends on NR_CPUS > 256

Should that be ">= 256" ?

> 
>   config HOTPLUG_CPU
>   	bool "Support for hot-pluggable CPUs"

Same here.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!


  reply	other threads:[~2024-01-15 15:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  0:05 [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Christoph Lameter (Ampere)
2023-12-15  0:05 ` Christoph Lameter (Ampere)
2024-01-15 15:39 ` Russell King (Oracle) [this message]
2024-01-15 15:39   ` Russell King (Oracle)
2024-01-16  7:10   ` Kefeng Wang
2024-01-16  7:10     ` Kefeng Wang
2024-01-16  9:28     ` Russell King (Oracle)
2024-01-16  9:28       ` Russell King (Oracle)
2024-01-16 13:08   ` Mark Rutland
2024-01-16 13:08     ` Mark Rutland
2024-01-16 21:06     ` Eric Mackay
2024-01-16 21:06       ` Eric Mackay
2024-01-17 19:59       ` Christoph Lameter (Ampere)
2024-01-17 19:59         ` Christoph Lameter (Ampere)
2024-01-15 23:59 ` Eric Mackay
2024-01-15 23:59   ` Eric Mackay
2024-01-16 11:24   ` Russell King (Oracle)
2024-01-16 11:24     ` Russell King (Oracle)
2024-01-16 21:06     ` Eric Mackay
2024-01-16 21:06       ` Eric Mackay
2024-01-17 20:01       ` Christoph Lameter (Ampere)
2024-01-17 20:01         ` Christoph Lameter (Ampere)
2024-01-18 17:53         ` Eric Mackay
2024-01-18 17:53           ` Eric Mackay
2024-01-23 23:55           ` [PATCH v2] " Christoph Lameter (Ampere)
2024-01-23 23:55             ` Christoph Lameter (Ampere)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaVRlHpAOoNIiRiY@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Matteo.Carlini@arm.com \
    --cc=Valentin.Schneider@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=dave.kleikamp@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robin.murphy@arm.com \
    --cc=vanshikonda@os.amperecomputing.com \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.