From: Andrea Parri <parri.andrea@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, paulmck@kernel.org, corbet@lwn.net,
mmaas@google.com, hboehm@google.com, striker@us.ibm.com,
charlie@rivosinc.com, rehn@rivosinc.com,
linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] membarrier: riscv: Provide core serializing command
Date: Wed, 24 Jan 2024 19:44:20 +0100 [thread overview]
Message-ID: <ZbFahHxi5laA6CbI@andrea> (raw)
In-Reply-To: <aabea058-0088-41bb-822a-402669f348bb@efficios.com>
> > +# riscv uses xRET as return from interrupt and to return to user-space.
> > +#
> > +# Given that xRET is not core serializing, we rely on FENCE.I for providing
> > +# core serialization:
> > +#
> > +# - by calling sync_core_before_usermode() on return from interrupt (cf.
> > +# ipi_sync_core()),
> > +#
> > +# - via switch_mm() and sync_core_before_usermode() (respectively, for
> > +# uthread->uthread and kthread->uthread transitions) to go back to
> > +# user-space.
>
> I don't quite get the meaning of the sentence above. There seems to be a
> missing marker before "to go back".
Let's see. Without the round brackets, the last part becomes:
- via switch_mm() and sync_core_before_usermode() to go back to
user-space.
This is indeed what I meant to say. What am I missing?
Andrea
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Parri <parri.andrea@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, paulmck@kernel.org, corbet@lwn.net,
mmaas@google.com, hboehm@google.com, striker@us.ibm.com,
charlie@rivosinc.com, rehn@rivosinc.com,
linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] membarrier: riscv: Provide core serializing command
Date: Wed, 24 Jan 2024 19:44:20 +0100 [thread overview]
Message-ID: <ZbFahHxi5laA6CbI@andrea> (raw)
In-Reply-To: <aabea058-0088-41bb-822a-402669f348bb@efficios.com>
> > +# riscv uses xRET as return from interrupt and to return to user-space.
> > +#
> > +# Given that xRET is not core serializing, we rely on FENCE.I for providing
> > +# core serialization:
> > +#
> > +# - by calling sync_core_before_usermode() on return from interrupt (cf.
> > +# ipi_sync_core()),
> > +#
> > +# - via switch_mm() and sync_core_before_usermode() (respectively, for
> > +# uthread->uthread and kthread->uthread transitions) to go back to
> > +# user-space.
>
> I don't quite get the meaning of the sentence above. There seems to be a
> missing marker before "to go back".
Let's see. Without the round brackets, the last part becomes:
- via switch_mm() and sync_core_before_usermode() to go back to
user-space.
This is indeed what I meant to say. What am I missing?
Andrea
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-01-24 18:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 14:55 [PATCH v3 0/4] membarrier: riscv: Core serializing command Andrea Parri
2024-01-10 14:55 ` Andrea Parri
2024-01-10 14:55 ` [PATCH v3 1/4] membarrier: riscv: Add full memory barrier in switch_mm() Andrea Parri
2024-01-10 14:55 ` Andrea Parri
2024-01-10 14:55 ` [PATCH v3 2/4] membarrier: Create Documentation/scheduler/membarrier.rst Andrea Parri
2024-01-10 14:55 ` Andrea Parri
2024-01-10 18:15 ` Randy Dunlap
2024-01-10 18:15 ` Randy Dunlap
2024-01-10 19:05 ` Andrea Parri
2024-01-10 19:05 ` Andrea Parri
2024-01-10 19:08 ` Randy Dunlap
2024-01-10 19:08 ` Randy Dunlap
2024-01-10 19:19 ` Andrea Parri
2024-01-10 19:19 ` Andrea Parri
2024-01-24 16:13 ` Mathieu Desnoyers
2024-01-24 16:13 ` Mathieu Desnoyers
2024-01-10 14:55 ` [PATCH v3 3/4] locking: Introduce prepare_sync_core_cmd() Andrea Parri
2024-01-10 14:55 ` Andrea Parri
2024-01-10 14:55 ` [PATCH v3 4/4] membarrier: riscv: Provide core serializing command Andrea Parri
2024-01-10 14:55 ` Andrea Parri
2024-01-10 19:27 ` Stefan O'Rear
2024-01-10 19:27 ` Stefan O'Rear
2024-01-10 22:34 ` Andrea Parri
2024-01-10 22:34 ` Andrea Parri
2024-01-24 16:18 ` Mathieu Desnoyers
2024-01-24 16:18 ` Mathieu Desnoyers
2024-01-24 18:44 ` Andrea Parri [this message]
2024-01-24 18:44 ` Andrea Parri
2024-01-24 18:56 ` Mathieu Desnoyers
2024-01-24 18:56 ` Mathieu Desnoyers
2024-01-24 21:43 ` Andrea Parri
2024-01-24 21:43 ` Andrea Parri
2024-01-24 14:13 ` [PATCH v3 0/4] membarrier: riscv: Core " Andrea Parri
2024-01-24 14:13 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbFahHxi5laA6CbI@andrea \
--to=parri.andrea@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=corbet@lwn.net \
--cc=hboehm@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mmaas@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=rehn@rivosinc.com \
--cc=striker@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.