Re: [PATCH v2 3/3] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

> On Sun, 28 Jan 2024 12:25:45 +0100
> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> 
> > Add device bindings for asm330lhhxg1 IMU sensor.
> > Use asm330lhhx as fallback device for asm330lhhxg1 since it implements
> > all the features currently supported by asm330lhhxg1.
> 
> If there are no other changes, I can amend this text whilst applying.
> Something lie:
> 
> The asm330lhhx supports a subset of the features and functionality
> provided by the asm330lhhxg1 via identical interfaces and so is a
> suitable fallback compatible.

I think it is fine, thx Jonathan.

Regards,
Lorenzo

> 
> As normal for bindings we shouldn't talk about the driver though
> what we really care about here is that the driver will never support
> functionality for the fallback part that doesn't apply for the
> more advanced part (because there isn't any!)
> 
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > index 28b667a9cb76..7ba3de66a2e1 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > @@ -49,6 +49,9 @@ properties:
> >        - items:
> >            - const: st,asm330lhb
> >            - const: st,asm330lhh
> > +      - items:
> > +          - const: st,asm330lhhxg1
> > +          - const: st,asm330lhhx
> >  
> >    reg:
> >      maxItems: 1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]