Re: [PATCH v2 3/3] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

> On 29/01/2024 14:30, Lorenzo Bianconi wrote:
> >> On 28/01/2024 12:25, Lorenzo Bianconi wrote:
> >>> Add device bindings for asm330lhhxg1 IMU sensor.
> >>> Use asm330lhhx as fallback device for asm330lhhxg1 since it implements
> >>> all the features currently supported by asm330lhhxg1.
> >>>
> >>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >>> ---
> >>>  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> >>> index 28b667a9cb76..7ba3de66a2e1 100644
> >>> --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> >>> +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> >>> @@ -49,6 +49,9 @@ properties:
> >>>        - items:
> >>>            - const: st,asm330lhb
> >>>            - const: st,asm330lhh
> >>> +      - items:
> >>> +          - const: st,asm330lhhxg1
> >>> +          - const: st,asm330lhhx
> >>
> >> lhhx is compatible with st,lsm6dsr, so some explanation would be useful
> >> why it is not included here.
> >>
> >> Best regards,
> >> Krzysztof
> >>
> > 
> > Do you mean something like:
> > 
> 
> I meant either explanation in commit msg or adding lsm6dsr fallback.
> 
> Best regards,
> Krzysztof
> 

I think we can use lsm6dsr as fallback instead of asm330lhhx (for st_lsm6dsx
there is no difference), I have just used asm330lhhx since both asm330lhhx and
asm330lhhxg1 are automotive sensors.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]