All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Shawn Guo <shawnguo@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>, Peng Fan <peng.fan@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] gpio: vf610: allow disabling the vf610 driver
Date: Tue, 30 Jan 2024 07:45:23 +0100	[thread overview]
Message-ID: <ZbibA9QbOn19AXcn@gaggiata.pivistrello.it> (raw)
In-Reply-To: <ZbgX-HGjM5fdftCG@v2202401214221251712.nicesrv.de>

On Mon, Jan 29, 2024 at 10:26:16PM +0100, Martin Kaiser wrote:
> Thus wrote Francesco Dolcini (francesco@dolcini.it):
> 
> > On Wed, Jan 24, 2024 at 09:58:57PM +0100, Martin Kaiser wrote:
> > > The vf610 gpio driver is enabled by default for all i.MX machines,
> > > without any option to disable it in a board-specific config file.
> 
> > > Most i.MX chipsets have no hardware for this driver. Change the default
> > > to enable GPIO_VF610 for SOC_VF610 and disable it otherwise.
> 
> > > Add a text description after the bool type, this makes the driver
> > > selectable by make config etc.
> 
> > > Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> > > ---
> 
> > >  config GPIO_VF610
> > > -	def_bool y
> > > +	bool "VF610 GPIO support"
> > > +	default y if SOC_VF610
> 
> > any reason for having this default y for SOC_VF610, but not for the
> > other SOC that uses the same variant (i.MX7ULP, ... ?).
> 
> Ok, it's probably not as consistent as it could be.

...

> Does this make sense?
sounds fair to me.

Francesco

> 
>    Martin

WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco@dolcini.it>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Shawn Guo <shawnguo@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>, Peng Fan <peng.fan@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] gpio: vf610: allow disabling the vf610 driver
Date: Tue, 30 Jan 2024 07:45:23 +0100	[thread overview]
Message-ID: <ZbibA9QbOn19AXcn@gaggiata.pivistrello.it> (raw)
In-Reply-To: <ZbgX-HGjM5fdftCG@v2202401214221251712.nicesrv.de>

On Mon, Jan 29, 2024 at 10:26:16PM +0100, Martin Kaiser wrote:
> Thus wrote Francesco Dolcini (francesco@dolcini.it):
> 
> > On Wed, Jan 24, 2024 at 09:58:57PM +0100, Martin Kaiser wrote:
> > > The vf610 gpio driver is enabled by default for all i.MX machines,
> > > without any option to disable it in a board-specific config file.
> 
> > > Most i.MX chipsets have no hardware for this driver. Change the default
> > > to enable GPIO_VF610 for SOC_VF610 and disable it otherwise.
> 
> > > Add a text description after the bool type, this makes the driver
> > > selectable by make config etc.
> 
> > > Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> > > ---
> 
> > >  config GPIO_VF610
> > > -	def_bool y
> > > +	bool "VF610 GPIO support"
> > > +	default y if SOC_VF610
> 
> > any reason for having this default y for SOC_VF610, but not for the
> > other SOC that uses the same variant (i.MX7ULP, ... ?).
> 
> Ok, it's probably not as consistent as it could be.

...

> Does this make sense?
sounds fair to me.

Francesco

> 
>    Martin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-01-30  6:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 20:58 [PATCH v4 0/4] gpio: vf610: allow disabling the vf610 driver Martin Kaiser
2024-01-24 20:58 ` Martin Kaiser
2024-01-24 20:58 ` [PATCH v4 1/4] " Martin Kaiser
2024-01-24 20:58   ` Martin Kaiser
2024-01-26 12:27   ` Francesco Dolcini
2024-01-26 12:27     ` Francesco Dolcini
2024-01-29 21:26     ` Martin Kaiser
2024-01-29 21:26       ` Martin Kaiser
2024-01-30  6:45       ` Francesco Dolcini [this message]
2024-01-30  6:45         ` Francesco Dolcini
2024-02-06 14:05         ` Martin Kaiser
2024-02-06 14:05           ` Martin Kaiser
2024-02-02 13:32   ` Bartosz Golaszewski
2024-02-02 13:32     ` Bartosz Golaszewski
2024-01-24 20:58 ` [PATCH v4 2/4] gpio: vf610: enable COMPILE_TEST Martin Kaiser
2024-01-24 20:58   ` Martin Kaiser
2024-02-02 13:33   ` Bartosz Golaszewski
2024-02-02 13:33     ` Bartosz Golaszewski
2024-01-24 20:58 ` [PATCH v4 3/4] ARM: imx_v6_v7_defconfig: enable the vf610 gpio driver Martin Kaiser
2024-01-24 20:58   ` Martin Kaiser
2024-02-06  8:11   ` Shawn Guo
2024-02-06  8:11     ` Shawn Guo
2024-01-24 20:59 ` [PATCH v4 4/4] arm64: defconfig: " Martin Kaiser
2024-01-24 20:59   ` Martin Kaiser
2024-02-06  8:11   ` Shawn Guo
2024-02-06  8:11     ` Shawn Guo
2024-01-26  3:36 ` [PATCH v4 0/4] gpio: vf610: allow disabling the vf610 driver Peng Fan
2024-01-26  3:36   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbibA9QbOn19AXcn@gaggiata.pivistrello.it \
    --to=francesco@dolcini.it \
    --cc=andrew@lunn.ch \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@kaiser.cx \
    --cc=peng.fan@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.