From: Sean Christopherson <seanjc@google.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 5/5] KVM: selftests: x86_64: Remove redundant newlines
Date: Tue, 30 Jan 2024 12:26:25 -0800 [thread overview]
Message-ID: <ZblbcUloeMqc-lR0@google.com> (raw)
In-Reply-To: <20231206170241.82801-12-ajones@ventanamicro.com>
On Wed, Dec 06, 2023, Andrew Jones wrote:
> @@ -162,7 +162,7 @@ static void check_clocksource(void)
> goto out;
> }
>
> - TEST_ASSERT(!strncmp(clk_name, "tsc\n", st.st_size),
> + TEST_ASSERT(!strncmp(clk_name, "tsc", st.st_size),
This newline is functionally necessary. It's in the strncmp() (*#$@ sysfs appends
newlines to everything), not the TEST_ASSERT message. I'll give you a pass and
fixup when applying since I'm guessing you don't have x86 hardware ;-)
I double checked the other arch patches and didn't see anything sneaky like this.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
kvm-riscv@lists.infradead.org, pbonzini@redhat.com,
maz@kernel.org, oliver.upton@linux.dev, anup@brainfault.org,
borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com
Subject: Re: [PATCH 5/5] KVM: selftests: x86_64: Remove redundant newlines
Date: Tue, 30 Jan 2024 12:26:25 -0800 [thread overview]
Message-ID: <ZblbcUloeMqc-lR0@google.com> (raw)
In-Reply-To: <20231206170241.82801-12-ajones@ventanamicro.com>
On Wed, Dec 06, 2023, Andrew Jones wrote:
> @@ -162,7 +162,7 @@ static void check_clocksource(void)
> goto out;
> }
>
> - TEST_ASSERT(!strncmp(clk_name, "tsc\n", st.st_size),
> + TEST_ASSERT(!strncmp(clk_name, "tsc", st.st_size),
This newline is functionally necessary. It's in the strncmp() (*#$@ sysfs appends
newlines to everything), not the TEST_ASSERT message. I'll give you a pass and
fixup when applying since I'm guessing you don't have x86 hardware ;-)
I double checked the other arch patches and didn't see anything sneaky like this.
next prev parent reply other threads:[~2024-01-30 20:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 17:02 [PATCH 0/5] KVM: selftests: Remove redundant newlines Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2023-12-06 17:02 ` [PATCH 1/5] " Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2023-12-06 17:02 ` [PATCH 2/5] KVM: selftests: aarch64: " Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2023-12-07 11:19 ` Zenghui Yu
2023-12-07 11:19 ` Zenghui Yu
2023-12-06 17:02 ` [PATCH 3/5] KVM: selftests: riscv: " Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2023-12-07 3:36 ` Anup Patel
2023-12-07 3:36 ` Anup Patel
2023-12-06 17:02 ` [PATCH 4/5] KVM: selftests: s390x: " Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2023-12-06 17:09 ` Claudio Imbrenda
2023-12-06 17:09 ` Claudio Imbrenda
2023-12-06 17:18 ` Janosch Frank
2023-12-06 17:18 ` Janosch Frank
2023-12-06 17:02 ` [PATCH 5/5] KVM: selftests: x86_64: " Andrew Jones
2023-12-06 17:02 ` Andrew Jones
2024-01-30 20:26 ` Sean Christopherson [this message]
2024-01-30 20:26 ` Sean Christopherson
2024-01-31 8:49 ` Andrew Jones
2024-01-31 8:49 ` Andrew Jones
2023-12-06 17:07 ` [PATCH 0/5] KVM: selftests: " Andrew Jones
2023-12-06 17:07 ` Andrew Jones
2024-01-31 0:59 ` Sean Christopherson
2024-01-31 0:59 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZblbcUloeMqc-lR0@google.com \
--to=seanjc@google.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.