From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] lib/string_choices: Add str_plural() helper
Date: Wed, 14 Feb 2024 20:49:39 +0200 [thread overview]
Message-ID: <Zc0LQ8YAWBwNptBF@smile.fi.intel.com> (raw)
In-Reply-To: <87y1bm6gpu.fsf@intel.com>
On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote:
> On Wed, 14 Feb 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote:
> >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote:
> >> > Add str_plural() helper to replace existing open implementations
> >> > used by many drivers and help improve future user facing messages.
> >>
> >> Any user of this, please?
>
> git grep "\"\" *: *\"s\""
You know what I meant.
Second patch in the series that shows usefulness of the first patch.
...
> >> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> >>
> >> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> > Cc: Jani Nikula <jani.nikula@intel.com>
> >>
> >> Move these Cc to the after '---' line.
>
> Why?
At bare minimum to reduce noise in the commit message.
If going further, to be environment friendly (no jokes).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-14 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 16:50 [PATCH] lib/string_choices: Add str_plural() helper Michal Wajdeczko
2024-02-14 18:08 ` Andy Shevchenko
2024-02-14 18:09 ` Andy Shevchenko
2024-02-14 18:30 ` Jani Nikula
2024-02-14 18:49 ` Andy Shevchenko [this message]
2024-02-14 19:07 ` Kees Cook
2024-02-15 15:20 ` Jani Nikula
2024-02-15 15:37 ` Michal Wajdeczko
2024-02-15 16:11 ` Andy Shevchenko
2024-02-15 16:55 ` Michal Wajdeczko
2024-02-15 17:05 ` Andy Shevchenko
2024-02-15 17:14 ` Michal Wajdeczko
2024-02-15 19:23 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc0LQ8YAWBwNptBF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jani.nikula@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.