From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] lib/string_choices: Add str_plural() helper
Date: Thu, 15 Feb 2024 19:05:06 +0200 [thread overview]
Message-ID: <Zc5EQhQC0DaHZIgO@smile.fi.intel.com> (raw)
In-Reply-To: <c5c13073-d543-4f80-a8b7-cc080cf04cbf@intel.com>
On Thu, Feb 15, 2024 at 05:55:43PM +0100, Michal Wajdeczko wrote:
> On 15.02.2024 17:11, Andy Shevchenko wrote:
> > On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote:
> >> On 15.02.2024 16:20, Jani Nikula wrote:
> >>> On Wed, 14 Feb 2024, Kees Cook <keescook@chromium.org> wrote:
> >>>> On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote:
...
> >>>> Or a Coccinelle script that could do some rewrites? But, yes, if you can
> >>>> include some examples, that would be nice. I think the helper is fine to
> >>>> add.
> >>
> >> please find below requested Coccinelle script:
> >
> > Thanks!
> >
> > Btw, what to do with 0?
>
> code is based on this rule:
>
> "With countable nouns, zero is always followed by plural nouns."
If it's not documented / commented, please add one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-15 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 16:50 [PATCH] lib/string_choices: Add str_plural() helper Michal Wajdeczko
2024-02-14 18:08 ` Andy Shevchenko
2024-02-14 18:09 ` Andy Shevchenko
2024-02-14 18:30 ` Jani Nikula
2024-02-14 18:49 ` Andy Shevchenko
2024-02-14 19:07 ` Kees Cook
2024-02-15 15:20 ` Jani Nikula
2024-02-15 15:37 ` Michal Wajdeczko
2024-02-15 16:11 ` Andy Shevchenko
2024-02-15 16:55 ` Michal Wajdeczko
2024-02-15 17:05 ` Andy Shevchenko [this message]
2024-02-15 17:14 ` Michal Wajdeczko
2024-02-15 19:23 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc5EQhQC0DaHZIgO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jani.nikula@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.