From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <frederic@kernel.org>,
Valentin Schneider <vschneid@redhat.com>
Subject: [PATCH] net/core/dev.c: enable timestamp static key if CPU isolation is configured
Date: Fri, 16 Feb 2024 12:02:15 -0300 [thread overview]
Message-ID: <Zc9493j46rZMRIDv@tpad> (raw)
For systems that use CPU isolation (via nohz_full), creating or destroying
a socket with timestamping (SOF_TIMESTAMPING_OPT_TX_SWHW) might cause a
static key to be enabled/disabled. This in turn causes undesired
IPIs to isolated CPUs.
So enable the static key unconditionally, if CPU isolation is enabled,
thus avoiding the IPIs.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/net/core/dev.c b/net/core/dev.c
index 0d548431f3fa..cc9a77b4aa4e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -153,6 +153,7 @@
#include <linux/prandom.h>
#include <linux/once_lite.h>
#include <net/netdev_rx_queue.h>
+#include <linux/sched/isolation.h>
#include "dev.h"
#include "net-sysfs.h"
@@ -11601,3 +11602,14 @@ static int __init net_dev_init(void)
}
subsys_initcall(net_dev_init);
+
+static int __init net_dev_late_init(void)
+{
+ /* avoid static key IPIs to isolated CPUs */
+ if (housekeeping_enabled(HK_TYPE_MISC))
+ net_enable_timestamp();
+
+ return 0;
+}
+
+late_initcall(net_dev_late_init);
next reply other threads:[~2024-02-16 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:02 Marcelo Tosatti [this message]
2024-02-16 15:13 ` [PATCH] net/core/dev.c: enable timestamp static key if CPU isolation is configured Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 10:35 Marcelo Tosatti
2024-02-22 9:34 ` Paolo Abeni
2024-02-22 15:11 ` Willem de Bruijn
2024-02-22 17:52 ` Marcelo Tosatti
2024-02-22 18:42 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc9493j46rZMRIDv@tpad \
--to=mtosatti@redhat.com \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.