From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Sanket Goswami <Sanket.Goswami@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
michael.j.ruhl@intel.com, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 7/9] i2c: designware: Move interrupt handling functions before i2c_dw_xfer()
Date: Tue, 6 Feb 2024 17:18:10 +0200 [thread overview]
Message-ID: <ZcJNsv7w7CYiFNpm@smile.fi.intel.com> (raw)
In-Reply-To: <20240206145158.227254-8-jarkko.nikula@linux.intel.com>
On Tue, Feb 06, 2024 at 04:51:56PM +0200, Jarkko Nikula wrote:
> Code is more logically arranged when i2c_dw_read_clear_intrbits() and
> i2c_dw_isr() are located before i2c_dw_xfer().
>
> Real reason for this is to prepare for more shared code between
> interrupt and polling mode code.
...
> + /*
> + * We must disable the adapter before returning and signaling the end
> + * of the current transfer. Otherwise the hardware might continue
> + * generating interrupts which in turn causes a race condition with
> + * the following transfer. Needs some more investigation if the
While at it, you may make it consistent, i.e. by dropping an extra space.
> + * additional interrupts are a hardware bug or this driver doesn't
> + * handle them correctly yet.
> + */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-06 15:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 14:51 [PATCH v2 0/9] i2c: designware: Generic polling mode code Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 1/9] i2c: designware: Add some flexiblity to the model info Jarkko Nikula
2024-02-06 15:30 ` Andy Shevchenko
2024-02-09 14:14 ` Jarkko Nikula
2024-02-09 14:25 ` Andy Shevchenko
2024-02-06 14:51 ` [PATCH v2 2/9] i2c: designware: Convert arbitration semaphore flag as semaphore type Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 3/9] i2c: designware: Convert shared_with_punit boolean " Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 4/9] i2c: designware: Uniform initialization flow for polling mode Jarkko Nikula
2024-02-06 15:13 ` Andy Shevchenko
2024-02-06 14:51 ` [PATCH v2 5/9] i2c: designware: Do not enable interrupts shortly in " Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 6/9] i2c: designware: Use accessors to DW_IC_INTR_MASK register Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 7/9] i2c: designware: Move interrupt handling functions before i2c_dw_xfer() Jarkko Nikula
2024-02-06 15:18 ` Andy Shevchenko [this message]
2024-02-06 14:51 ` [PATCH v2 8/9] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC Jarkko Nikula
2024-02-06 14:51 ` [PATCH v2 9/9] i2c: designware: Implement generic polling mode code for " Jarkko Nikula
2024-02-06 15:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcJNsv7w7CYiFNpm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=andi.shyti@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.