All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: ankita@nvidia.com
Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com,
	yuzenghui@huawei.com, reinette.chatre@intel.com,
	surenb@google.com, stefanha@redhat.com, brauner@kernel.org,
	will@kernel.org, mark.rutland@arm.com,
	alex.williamson@redhat.com, kevin.tian@intel.com,
	yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org,
	andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com,
	ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org,
	rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com,
	cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
	vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
	jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev,
	mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 2/4] mm: introduce new flag to indicate wc safe
Date: Thu, 8 Feb 2024 13:03:27 +0000	[thread overview]
Message-ID: <ZcTRH1rzfPbuQ_qj@arm.com> (raw)
In-Reply-To: <20240207204652.22954-3-ankita@nvidia.com>

On Thu, Feb 08, 2024 at 02:16:50AM +0530, ankita@nvidia.com wrote:
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index f5a97dec5169..884c068a79eb 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp);
>  # define VM_UFFD_MINOR		VM_NONE
>  #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */
>  
> +/*
> + * This flag is used to connect VFIO to arch specific KVM code. It
> + * indicates that the memory under this VMA is safe for use with any
> + * non-cachable memory type inside KVM. Some VFIO devices, on some
> + * platforms, are thought to be unsafe and can cause machine crashes if
> + * KVM does not lock down the memory type.
> + */
> +#ifdef CONFIG_64BIT
> +#define VM_VFIO_ALLOW_WC_BIT	39
> +#define VM_VFIO_ALLOW_WC	BIT(VM_VFIO_ALLOW_WC_BIT)
> +#else
> +#define VM_VFIO_ALLOW_WC	VM_NONE
> +#endif

Adding David Hildenbrand to this thread as well since we briefly
discussed potential alternatives (not sure we came to any conclusion).

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: ankita@nvidia.com
Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com,
	yuzenghui@huawei.com, reinette.chatre@intel.com,
	surenb@google.com, stefanha@redhat.com, brauner@kernel.org,
	will@kernel.org, mark.rutland@arm.com,
	alex.williamson@redhat.com, kevin.tian@intel.com,
	yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org,
	andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com,
	ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org,
	rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com,
	cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
	vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
	jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev,
	mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 2/4] mm: introduce new flag to indicate wc safe
Date: Thu, 8 Feb 2024 13:03:27 +0000	[thread overview]
Message-ID: <ZcTRH1rzfPbuQ_qj@arm.com> (raw)
In-Reply-To: <20240207204652.22954-3-ankita@nvidia.com>

On Thu, Feb 08, 2024 at 02:16:50AM +0530, ankita@nvidia.com wrote:
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index f5a97dec5169..884c068a79eb 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp);
>  # define VM_UFFD_MINOR		VM_NONE
>  #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */
>  
> +/*
> + * This flag is used to connect VFIO to arch specific KVM code. It
> + * indicates that the memory under this VMA is safe for use with any
> + * non-cachable memory type inside KVM. Some VFIO devices, on some
> + * platforms, are thought to be unsafe and can cause machine crashes if
> + * KVM does not lock down the memory type.
> + */
> +#ifdef CONFIG_64BIT
> +#define VM_VFIO_ALLOW_WC_BIT	39
> +#define VM_VFIO_ALLOW_WC	BIT(VM_VFIO_ALLOW_WC_BIT)
> +#else
> +#define VM_VFIO_ALLOW_WC	VM_NONE
> +#endif

Adding David Hildenbrand to this thread as well since we briefly
discussed potential alternatives (not sure we came to any conclusion).

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-08 13:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 20:46 [PATCH v6 0/4] kvm: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory ankita
2024-02-07 20:46 ` ankita
2024-02-07 20:46 ` [PATCH v6 1/4] kvm: arm64: introduce new flag for non-cacheable " ankita
2024-02-07 20:46   ` ankita
2024-02-08 13:00   ` Catalin Marinas
2024-02-08 13:00     ` Catalin Marinas
2024-02-08 13:24     ` Oliver Upton
2024-02-08 13:24       ` Oliver Upton
2024-02-09 14:10       ` Ankit Agrawal
2024-02-09 14:10         ` Ankit Agrawal
2024-02-08 13:19   ` Will Deacon
2024-02-08 13:19     ` Will Deacon
2024-02-09 14:12     ` Ankit Agrawal
2024-02-09 14:12       ` Ankit Agrawal
2024-02-07 20:46 ` [PATCH v6 2/4] mm: introduce new flag to indicate wc safe ankita
2024-02-07 20:46   ` ankita
2024-02-08 13:03   ` Catalin Marinas [this message]
2024-02-08 13:03     ` Catalin Marinas
2024-02-08 14:34     ` Jason Gunthorpe
2024-02-08 14:34       ` Jason Gunthorpe
2024-02-07 20:46 ` [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device ankita
2024-02-07 20:46   ` ankita
2024-02-08 13:26   ` Oliver Upton
2024-02-08 13:26     ` Oliver Upton
2024-02-08 14:51   ` Catalin Marinas
2024-02-08 14:51     ` Catalin Marinas
2024-02-09 14:05     ` Ankit Agrawal
2024-02-09 14:05       ` Ankit Agrawal
2024-02-07 20:46 ` [PATCH v6 4/4] vfio: convey kvm that the vfio-pci device is wc safe ankita
2024-02-07 20:46   ` ankita
2024-02-08 14:53   ` Catalin Marinas
2024-02-08 14:53     ` Catalin Marinas
2024-02-08 17:30   ` Alex Williamson
2024-02-08 17:30     ` Alex Williamson
2024-02-08 17:54     ` Jason Gunthorpe
2024-02-08 17:54       ` Jason Gunthorpe
2024-02-09 14:02       ` Ankit Agrawal
2024-02-09 14:02         ` Ankit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcTRH1rzfPbuQ_qj@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=acurrid@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=andreyknvl@gmail.com \
    --cc=aniketa@nvidia.com \
    --cc=ankita@nvidia.com \
    --cc=apopple@nvidia.com \
    --cc=ardb@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cjia@nvidia.com \
    --cc=danw@nvidia.com \
    --cc=david@redhat.com \
    --cc=gshan@redhat.com \
    --cc=james.morse@arm.com \
    --cc=jgg@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=kwankhede@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mochs@nvidia.com \
    --cc=oliver.upton@linux.dev \
    --cc=rananta@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=ricarkol@google.com \
    --cc=ryan.roberts@arm.com \
    --cc=stefanha@redhat.com \
    --cc=surenb@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=targupta@nvidia.com \
    --cc=vsethi@nvidia.com \
    --cc=wangjinchao@xfusion.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    --cc=yuzenghui@huawei.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.