All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf@google.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Baoquan He <bhe@redhat.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	bpf@vger.kernel.org,  Kexec-ml <kexec@lists.infradead.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH linux-next] bpf: fix warning for crash_kexec
Date: Mon, 12 Feb 2024 08:48:08 -0800	[thread overview]
Message-ID: <ZcpLyKDulwlrhGd1@google.com> (raw)
In-Reply-To: <ZcnaW5hB8y3da3bI@krava>

On 02/12, Jiri Olsa wrote:
> On Sat, Feb 10, 2024 at 12:51:21PM +0800, Baoquan He wrote:
> > On 02/09/24 at 11:18am, Stanislav Fomichev wrote:
> > > On 02/09, Hari Bathini wrote:
> > > > With [1], CONFIG_KEXEC & !CONFIG_CRASH_DUMP is supported but that led
> > > > to the below warning:
> > > > 
> > > >   "WARN: resolve_btfids: unresolved symbol crash_kexec"
> > > > 
> > > > Fix it by using the appropriate #ifdef.
> > > 
> > > Same question here: how did you find this particular kconfig option
> > > (CONFIG_CRASH_DUMP) to use? Looking at the code, crash_kexec is defined
> > > in kernel/kexec_core.c and it's gated by CONFIG_KEXEC_CORE. So the
> > > existing ifdef seems correct?
> > 
> > This patch is based on the latest next tree, I have made some changes to
> > split the crash code from kexec_core.c. If you check next/master branch,
> > crash_kexec is not in kernel/keec_core.c any more.
> 
> makes sense, it should have fixes tag:
> 
> Fixes: 29fd9ae62910 ("crash: split crash dumping code out from kexec_core.c")
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

+1, would've been nice to have more details in the commit description :-)

Acked-by: Stanislav Fomichev <sdf@google.com>

WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Fomichev <sdf@google.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Baoquan He <bhe@redhat.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	bpf@vger.kernel.org,  Kexec-ml <kexec@lists.infradead.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH linux-next] bpf: fix warning for crash_kexec
Date: Mon, 12 Feb 2024 08:48:08 -0800	[thread overview]
Message-ID: <ZcpLyKDulwlrhGd1@google.com> (raw)
In-Reply-To: <ZcnaW5hB8y3da3bI@krava>

On 02/12, Jiri Olsa wrote:
> On Sat, Feb 10, 2024 at 12:51:21PM +0800, Baoquan He wrote:
> > On 02/09/24 at 11:18am, Stanislav Fomichev wrote:
> > > On 02/09, Hari Bathini wrote:
> > > > With [1], CONFIG_KEXEC & !CONFIG_CRASH_DUMP is supported but that led
> > > > to the below warning:
> > > > 
> > > >   "WARN: resolve_btfids: unresolved symbol crash_kexec"
> > > > 
> > > > Fix it by using the appropriate #ifdef.
> > > 
> > > Same question here: how did you find this particular kconfig option
> > > (CONFIG_CRASH_DUMP) to use? Looking at the code, crash_kexec is defined
> > > in kernel/kexec_core.c and it's gated by CONFIG_KEXEC_CORE. So the
> > > existing ifdef seems correct?
> > 
> > This patch is based on the latest next tree, I have made some changes to
> > split the crash code from kexec_core.c. If you check next/master branch,
> > crash_kexec is not in kernel/keec_core.c any more.
> 
> makes sense, it should have fixes tag:
> 
> Fixes: 29fd9ae62910 ("crash: split crash dumping code out from kexec_core.c")
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

+1, would've been nice to have more details in the commit description :-)

Acked-by: Stanislav Fomichev <sdf@google.com>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2024-02-12 16:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 12:35 [PATCH linux-next] bpf: fix warning for crash_kexec Hari Bathini
2024-02-09 12:35 ` Hari Bathini
2024-02-09 19:18 ` Stanislav Fomichev
2024-02-09 19:18   ` Stanislav Fomichev
2024-02-10  4:51   ` Baoquan He
2024-02-10  4:51     ` Baoquan He
2024-02-12  8:44     ` Jiri Olsa
2024-02-12  8:44       ` Jiri Olsa
2024-02-12 16:48       ` Stanislav Fomichev [this message]
2024-02-12 16:48         ` Stanislav Fomichev
2024-02-10  4:52 ` Baoquan He
2024-02-10  4:52   ` Baoquan He
2024-03-18  6:52 ` Hari Bathini
2024-03-18  6:52   ` Hari Bathini
2024-03-18 16:13   ` Yonghong Song
2024-03-18 16:13     ` Yonghong Song
2024-03-19  8:06     ` Hari Bathini
2024-03-19  8:06       ` Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcpLyKDulwlrhGd1@google.com \
    --to=sdf@google.com \
    --cc=ast@kernel.org \
    --cc=bhe@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hbathini@linux.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=olsajiri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.