Re: [Intel-wired-lan] [iwl-next v1 06/15] ice: add subfunction aux driver support

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Tue, Feb 13, 2024 at 12:28:19PM +0100, Jiri Pirko wrote:
> Tue, Feb 13, 2024 at 10:43:00AM CET, michal.swiatkowski@linux.intel.com wrote:
> >On Tue, Feb 13, 2024 at 09:57:12AM +0100, Jiri Pirko wrote:
> >> Tue, Feb 13, 2024 at 08:27:15AM CET, michal.swiatkowski@linux.intel.com wrote:
> >> >From: Piotr Raczynski <piotr.raczynski@intel.com>
> >> >
> >> >Instead of only registering devlink port by the ice driver itself,
> >> >let PF driver only register port representor for a given subfunction.
> >> >Then, aux driver is supposed to register its own devlink instance and
> >> >register virtual devlink port.
> >> >
> >> >Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> >> >Signed-off-by: Piotr Raczynski <piotr.raczynski@intel.com>
> >> >Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> >> >---
> >> > .../intel/ice/devlink/ice_devlink_port.c      |  52 ++++-
> >> > .../intel/ice/devlink/ice_devlink_port.h      |   6 +
> >> > drivers/net/ethernet/intel/ice/ice_devlink.c  |  28 ++-
> >> > drivers/net/ethernet/intel/ice/ice_devlink.h  |   3 +
> >> > drivers/net/ethernet/intel/ice/ice_main.c     |   9 +
> >> > drivers/net/ethernet/intel/ice/ice_sf_eth.c   | 214 ++++++++++++++++--
> >> > drivers/net/ethernet/intel/ice/ice_sf_eth.h   |  21 ++
> >> > 7 files changed, 302 insertions(+), 31 deletions(-)
> >> 
> >> Could you please split this. I see that you can push out 1-3 patches as
> >> preparation.
> >
> >Do you mean 1-3 patchses from this patch, or from whole patchset? I mean,
> 
> This patch.
> 
> >do you want to split the patchset to two patchsets? (by splitting patch
> 
> Yes, 2 patchsets. If convenient 3. Just do one change per patch so it is
> reviewable.
> 
> 
Ok, will do that.

> >from the patchset I will have more than netdev maximum; 15 I think). 
> >
> >Thanks,
> >Michal