* [PATCH] arm64: head: Remove the instructions that get the virtual offset in __relocate_kernel [not found] <CGME20240226040238epcas1p189fc1471befb73603d75aab855ae37ac@epcas1p1.samsung.com> @ 2024-02-26 4:02 ` Seongsu Park 0 siblings, 0 replies; 4+ messages in thread From: Seongsu Park @ 2024-02-26 4:02 UTC (permalink / raw) To: catalin.marinas, will, anshuman.khandual, ardb, maz, joey.gouly, quic_neeraju Cc: linux-arm-kernel, linux-kernel, sgsu.park, Leem ChaeHoon, Hyongwu Kim, Gyeonggeon Choi, Soomin Cho, Daero Lee, kmasta Since relative references have been used in RELA and RELR tables, there has been no need to know their start va and end va. Therefore, the instructions to get virtual offset in __relocate_kernel should be removed. Co-developed-by: Leem ChaeHoon <infinite.run@gmail.com> Signed-off-by: Leem ChaeHoon <infinite.run@gmail.com> Co-developed-by: Hyongwu Kim <browoo777@gmail.com> Signed-off-by: Hyongwu Kim <browoo777@gmail.com> Co-developed-by: Gyeonggeon Choi <gychoi@student.42seoul.kr> Signed-off-by: Gyeonggeon Choi <gychoi@student.42seoul.kr> Co-developed-by: Soomin Cho <to.soomin@gmail.com> Signed-off-by: Soomin Cho <to.soomin@gmail.com> Co-developed-by: Daero Lee <skseofh@gmail.com> Signed-off-by: Daero Lee <skseofh@gmail.com> Co-developed-by: kmasta <kmasta.study@gmail.com> Signed-off-by: kmasta <kmasta.study@gmail.com> Signed-off-by: Seongsu Park <sgsu.park@samsung.com> --- arch/arm64/kernel/head.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S index cab7f91949d8..90db196f7c19 100644 --- a/arch/arm64/kernel/head.S +++ b/arch/arm64/kernel/head.S @@ -787,8 +787,6 @@ SYM_FUNC_START_LOCAL(__relocate_kernel) */ adr_l x9, __rela_start adr_l x10, __rela_end - mov_q x11, KIMAGE_VADDR // default virtual offset - add x11, x11, x23 // actual virtual offset 0: cmp x9, x10 b.hs 1f -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64: head: Remove the instructions that get the virtual offset in __relocate_kernel @ 2024-02-26 4:02 ` Seongsu Park 0 siblings, 0 replies; 4+ messages in thread From: Seongsu Park @ 2024-02-26 4:02 UTC (permalink / raw) To: catalin.marinas, will, anshuman.khandual, ardb, maz, joey.gouly, quic_neeraju Cc: linux-arm-kernel, linux-kernel, sgsu.park, Leem ChaeHoon, Hyongwu Kim, Gyeonggeon Choi, Soomin Cho, Daero Lee, kmasta Since relative references have been used in RELA and RELR tables, there has been no need to know their start va and end va. Therefore, the instructions to get virtual offset in __relocate_kernel should be removed. Co-developed-by: Leem ChaeHoon <infinite.run@gmail.com> Signed-off-by: Leem ChaeHoon <infinite.run@gmail.com> Co-developed-by: Hyongwu Kim <browoo777@gmail.com> Signed-off-by: Hyongwu Kim <browoo777@gmail.com> Co-developed-by: Gyeonggeon Choi <gychoi@student.42seoul.kr> Signed-off-by: Gyeonggeon Choi <gychoi@student.42seoul.kr> Co-developed-by: Soomin Cho <to.soomin@gmail.com> Signed-off-by: Soomin Cho <to.soomin@gmail.com> Co-developed-by: Daero Lee <skseofh@gmail.com> Signed-off-by: Daero Lee <skseofh@gmail.com> Co-developed-by: kmasta <kmasta.study@gmail.com> Signed-off-by: kmasta <kmasta.study@gmail.com> Signed-off-by: Seongsu Park <sgsu.park@samsung.com> --- arch/arm64/kernel/head.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S index cab7f91949d8..90db196f7c19 100644 --- a/arch/arm64/kernel/head.S +++ b/arch/arm64/kernel/head.S @@ -787,8 +787,6 @@ SYM_FUNC_START_LOCAL(__relocate_kernel) */ adr_l x9, __rela_start adr_l x10, __rela_end - mov_q x11, KIMAGE_VADDR // default virtual offset - add x11, x11, x23 // actual virtual offset 0: cmp x9, x10 b.hs 1f -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: head: Remove the instructions that get the virtual offset in __relocate_kernel 2024-02-26 4:02 ` Seongsu Park @ 2024-02-28 18:01 ` Catalin Marinas -1 siblings, 0 replies; 4+ messages in thread From: Catalin Marinas @ 2024-02-28 18:01 UTC (permalink / raw) To: Seongsu Park Cc: will, anshuman.khandual, ardb, maz, joey.gouly, quic_neeraju, linux-arm-kernel, linux-kernel, Leem ChaeHoon, Hyongwu Kim, Gyeonggeon Choi, Soomin Cho, Daero Lee, kmasta On Mon, Feb 26, 2024 at 01:02:24PM +0900, Seongsu Park wrote: > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index cab7f91949d8..90db196f7c19 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -787,8 +787,6 @@ SYM_FUNC_START_LOCAL(__relocate_kernel) > */ > adr_l x9, __rela_start > adr_l x10, __rela_end > - mov_q x11, KIMAGE_VADDR // default virtual offset > - add x11, x11, x23 // actual virtual offset > > 0: cmp x9, x10 > b.hs 1f This code has been removed by commit 734958ef0b54 ("arm64: head: move relocation handling to C code") in linux-next, so the patch is no longer needed. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: head: Remove the instructions that get the virtual offset in __relocate_kernel @ 2024-02-28 18:01 ` Catalin Marinas 0 siblings, 0 replies; 4+ messages in thread From: Catalin Marinas @ 2024-02-28 18:01 UTC (permalink / raw) To: Seongsu Park Cc: will, anshuman.khandual, ardb, maz, joey.gouly, quic_neeraju, linux-arm-kernel, linux-kernel, Leem ChaeHoon, Hyongwu Kim, Gyeonggeon Choi, Soomin Cho, Daero Lee, kmasta On Mon, Feb 26, 2024 at 01:02:24PM +0900, Seongsu Park wrote: > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index cab7f91949d8..90db196f7c19 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -787,8 +787,6 @@ SYM_FUNC_START_LOCAL(__relocate_kernel) > */ > adr_l x9, __rela_start > adr_l x10, __rela_end > - mov_q x11, KIMAGE_VADDR // default virtual offset > - add x11, x11, x23 // actual virtual offset > > 0: cmp x9, x10 > b.hs 1f This code has been removed by commit 734958ef0b54 ("arm64: head: move relocation handling to C code") in linux-next, so the patch is no longer needed. Thanks. -- Catalin ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-28 18:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20240226040238epcas1p189fc1471befb73603d75aab855ae37ac@epcas1p1.samsung.com>
2024-02-26 4:02 ` [PATCH] arm64: head: Remove the instructions that get the virtual offset in __relocate_kernel Seongsu Park
2024-02-26 4:02 ` Seongsu Park
2024-02-28 18:01 ` Catalin Marinas
2024-02-28 18:01 ` Catalin Marinas
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.