From: Yury Norov <yury.norov@gmail.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Andy Shevchenko <andy@kernel.org>,
linux-s390@vger.kernel.org, ntfs3@lists.linux.dev,
Wojciech Drewek <wojciech.drewek@intel.com>,
Ido Schimmel <idosch@nvidia.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Jiri Pirko <jiri@resnulli.us>, Eric Dumazet <edumazet@google.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Alexander Potapenko <glider@google.com>,
Simon Horman <horms@kernel.org>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-btrfs@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v5 09/21] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64()
Date: Wed, 28 Feb 2024 08:26:44 -0800 [thread overview]
Message-ID: <Zd9exCzbAnOxAY50@yury-ThinkPad> (raw)
In-Reply-To: <20240201122216.2634007-10-aleksander.lobakin@intel.com>
On Thu, Feb 01, 2024 at 01:22:04PM +0100, Alexander Lobakin wrote:
> bitmap_size() is a pretty generic name and one may want to use it for
> a generic bitmap API function. At the same time, its logic is
> NTFS-specific, as it aligns to the sizeof(u64), not the sizeof(long)
> (although it uses ideologically right ALIGN() instead of division).
> Add the prefix 'ntfs3_' used for that FS (not just 'ntfs_' to not mix
> it with the legacy module) and use generic BITS_TO_U64() while at it.
>
> Suggested-by: Yury Norov <yury.norov@gmail.com> # BITS_TO_U64()
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <yury.norov@gmail.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Andy Shevchenko <andy@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alexander Potapenko <glider@google.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@nvidia.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Simon Horman <horms@kernel.org>,
linux-btrfs@vger.kernel.org, dm-devel@redhat.com,
ntfs3@lists.linux.dev, linux-s390@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 09/21] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64()
Date: Wed, 28 Feb 2024 08:26:44 -0800 [thread overview]
Message-ID: <Zd9exCzbAnOxAY50@yury-ThinkPad> (raw)
In-Reply-To: <20240201122216.2634007-10-aleksander.lobakin@intel.com>
On Thu, Feb 01, 2024 at 01:22:04PM +0100, Alexander Lobakin wrote:
> bitmap_size() is a pretty generic name and one may want to use it for
> a generic bitmap API function. At the same time, its logic is
> NTFS-specific, as it aligns to the sizeof(u64), not the sizeof(long)
> (although it uses ideologically right ALIGN() instead of division).
> Add the prefix 'ntfs3_' used for that FS (not just 'ntfs_' to not mix
> it with the legacy module) and use generic BITS_TO_U64() while at it.
>
> Suggested-by: Yury Norov <yury.norov@gmail.com> # BITS_TO_U64()
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
next prev parent reply other threads:[~2024-02-28 16:26 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 12:21 [Intel-wired-lan] [PATCH net-next v5 00/21] ice: add PFCP filter support Alexander Lobakin
2024-02-01 12:21 ` Alexander Lobakin
2024-02-01 12:21 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Alexander Lobakin
2024-02-01 12:21 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Alexander Lobakin
2024-02-01 13:23 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Arnd Bergmann
2024-02-01 13:23 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Arnd Bergmann
2024-02-01 13:45 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Alexander Potapenko
2024-02-01 13:45 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Alexander Potapenko
2024-02-01 14:02 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Arnd Bergmann
2024-02-01 14:02 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Arnd Bergmann
2024-02-28 16:10 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Yury Norov
2024-02-28 16:10 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Yury Norov
2024-02-01 15:49 ` [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}() Alexander Lobakin
2024-02-01 15:49 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Alexander Lobakin
2024-02-01 12:21 ` [Intel-wired-lan] [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read, write}() Alexander Lobakin
2024-02-01 12:21 ` [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read,write}() Alexander Lobakin
2024-02-28 16:13 ` [Intel-wired-lan] [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read, write}() Yury Norov
2024-02-28 16:13 ` [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read,write}() Yury Norov
2024-02-01 12:21 ` [Intel-wired-lan] [PATCH net-next v5 03/21] lib/test_bitmap: use pr_info() for non-error messages Alexander Lobakin
2024-02-01 12:21 ` Alexander Lobakin
2024-02-28 16:16 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:16 ` Yury Norov
2024-02-01 12:21 ` [Intel-wired-lan] [PATCH net-next v5 04/21] bitops: add missing prototype check Alexander Lobakin
2024-02-01 12:21 ` Alexander Lobakin
2024-02-28 16:18 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:18 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 05/21] bitops: make BYTES_TO_BITS() treewide-available Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:20 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:20 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 06/21] bitops: let the compiler optimize {__, }assign_bit() Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 06/21] bitops: let the compiler optimize {__,}assign_bit() Alexander Lobakin
2024-02-28 16:23 ` [Intel-wired-lan] [PATCH net-next v5 06/21] bitops: let the compiler optimize {__, }assign_bit() Yury Norov
2024-02-28 16:23 ` [PATCH net-next v5 06/21] bitops: let the compiler optimize {__,}assign_bit() Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 07/21] linkmode: convert linkmode_{test, set, clear, mod}_bit() to macros Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 07/21] linkmode: convert linkmode_{test,set,clear,mod}_bit() " Alexander Lobakin
2024-02-28 16:24 ` [Intel-wired-lan] [PATCH net-next v5 07/21] linkmode: convert linkmode_{test, set, clear, mod}_bit() " Yury Norov
2024-02-28 16:24 ` [PATCH net-next v5 07/21] linkmode: convert linkmode_{test,set,clear,mod}_bit() " Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 08/21] s390/cio: rename bitmap_size() -> idset_bitmap_size() Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-26 17:13 ` [Intel-wired-lan] " Peter Oberparleiter
2024-02-26 17:13 ` Peter Oberparleiter
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 09/21] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64() Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:26 ` Yury Norov [this message]
2024-02-28 16:26 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 10/21] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits() Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:27 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:27 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 11/21] tools: move alignment-related macros to new <linux/align.h> Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-02 11:37 ` [Intel-wired-lan] " Przemek Kitszel
2024-02-02 11:37 ` Przemek Kitszel
2024-02-28 16:28 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:28 ` Yury Norov
2024-02-28 16:29 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:29 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 12/21] bitmap: introduce generic optimized bitmap_size() Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:31 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:31 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 13/21] bitmap: make bitmap_{get, set}_value8() use bitmap_{read, write}() Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Alexander Lobakin
2024-02-02 11:39 ` [Intel-wired-lan] [PATCH net-next v5 13/21] bitmap: make bitmap_{get, set}_value8() use bitmap_{read, write}() Przemek Kitszel
2024-02-02 11:39 ` [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Przemek Kitszel
2024-02-28 16:31 ` [Intel-wired-lan] [PATCH net-next v5 13/21] bitmap: make bitmap_{get, set}_value8() use bitmap_{read, write}() Yury Norov
2024-02-28 16:31 ` [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 14/21] lib/bitmap: add compile-time test for __assign_bit() optimization Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:32 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:32 ` Yury Norov
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 15/21] ip_tunnel: use a separate struct to store tunnel params in the kernel Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 16/21] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 17/21] lib/bitmap: add tests for IP tunnel flags conversion helpers Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-28 16:38 ` [Intel-wired-lan] " Yury Norov
2024-02-28 16:38 ` Yury Norov
2024-03-26 12:20 ` [Intel-wired-lan] " Alexander Lobakin
2024-03-26 12:20 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 18/21] pfcp: add PFCP module Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 19/21] pfcp: always set pfcp metadata Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 20/21] ice: refactor ICE_TC_FLWR_FIELD_ENC_OPTS Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-01 12:22 ` [Intel-wired-lan] [PATCH net-next v5 21/21] ice: Add support for PFCP hardware offload in switchdev Alexander Lobakin
2024-02-01 12:22 ` Alexander Lobakin
2024-02-06 12:46 ` [Intel-wired-lan] [PATCH net-next v5 00/21] ice: add PFCP filter support Alexander Lobakin
2024-02-06 12:46 ` Alexander Lobakin
2024-02-06 15:37 ` [Intel-wired-lan] " Jakub Kicinski
2024-02-06 15:37 ` Jakub Kicinski
2024-02-07 15:05 ` [Intel-wired-lan] " Jakub Kicinski
2024-02-07 15:05 ` Jakub Kicinski
2024-02-12 11:35 ` [Intel-wired-lan] " Alexander Lobakin
2024-02-12 11:35 ` Alexander Lobakin
2024-02-28 16:46 ` Yury Norov
2024-02-28 16:46 ` Yury Norov
2024-04-02 10:59 ` Niklas Schnelle
2024-04-02 10:59 ` Niklas Schnelle
2024-04-02 11:00 ` Alexander Lobakin
2024-04-02 11:00 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd9exCzbAnOxAY50@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andy@kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.