From: Jisheng Zhang <jszhang@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chao Wei <chao.wei@sophgo.com>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Liu Gui <kenneth.liu@sophgo.com>,
Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
dlan@gentoo.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller
Date: Sat, 17 Feb 2024 21:56:55 +0800 [thread overview]
Message-ID: <ZdC7J-5zUQFHHiNK@xhacker> (raw)
In-Reply-To: <IA1PR20MB49533397F35C450DB92B00C7BB4E2@IA1PR20MB4953.namprd20.prod.outlook.com>
On Wed, Feb 14, 2024 at 09:35:55AM +0800, Inochi Amaoto wrote:
> Add top misc system controller dt node for CV18XX/SG200x.
it's better to delay this patch until users is seen.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
> arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..dbf018e99c48 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -53,6 +53,14 @@ soc {
> dma-noncoherent;
> ranges;
>
> + topctrl: syscon@3000000 {
"sysctrl" is better, the TRM name this as system controller.
> + compatible = "sophgo,cv1800-top-syscon",
> + "syscon", "simple-mfd";
> + reg = <0x03000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> gpio0: gpio@3020000 {
> compatible = "snps,dw-apb-gpio";
> reg = <0x3020000 0x1000>;
> --
> 2.43.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chao Wei <chao.wei@sophgo.com>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Liu Gui <kenneth.liu@sophgo.com>,
Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
dlan@gentoo.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller
Date: Sat, 17 Feb 2024 21:56:55 +0800 [thread overview]
Message-ID: <ZdC7J-5zUQFHHiNK@xhacker> (raw)
In-Reply-To: <IA1PR20MB49533397F35C450DB92B00C7BB4E2@IA1PR20MB4953.namprd20.prod.outlook.com>
On Wed, Feb 14, 2024 at 09:35:55AM +0800, Inochi Amaoto wrote:
> Add top misc system controller dt node for CV18XX/SG200x.
it's better to delay this patch until users is seen.
>
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
> arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..dbf018e99c48 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -53,6 +53,14 @@ soc {
> dma-noncoherent;
> ranges;
>
> + topctrl: syscon@3000000 {
"sysctrl" is better, the TRM name this as system controller.
> + compatible = "sophgo,cv1800-top-syscon",
> + "syscon", "simple-mfd";
> + reg = <0x03000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> gpio0: gpio@3020000 {
> compatible = "snps,dw-apb-gpio";
> reg = <0x3020000 0x1000>;
> --
> 2.43.1
>
next prev parent reply other threads:[~2024-02-17 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 1:35 [PATCH 0/2] riscv: sophgo: cv18xx: add top misc system controller Inochi Amaoto
2024-02-14 1:35 ` Inochi Amaoto
2024-02-14 1:35 ` [PATCH 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC Inochi Amaoto
2024-02-14 1:35 ` Inochi Amaoto
2024-02-14 2:21 ` Rob Herring
2024-02-14 2:21 ` Rob Herring
2024-02-14 2:46 ` Inochi Amaoto
2024-02-14 2:46 ` Inochi Amaoto
2024-02-14 1:35 ` [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller Inochi Amaoto
2024-02-14 1:35 ` Inochi Amaoto
2024-02-17 13:56 ` Jisheng Zhang [this message]
2024-02-17 13:56 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdC7J-5zUQFHHiNK@xhacker \
--to=jszhang@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=kenneth.liu@sophgo.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.