Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@smile.fr>
Cc: David Picard <david.picard@clermont.in2p3.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
Date: Wed, 21 Feb 2024 07:28:20 +0100	[thread overview]
Message-ID: <ZdWYBJ7mt1L2CTjL@landeda> (raw)
In-Reply-To: <643b99fe-655d-45b9-80dd-f47bb53efcb2@smile.fr>

Romain, David, All,

On 2024-02-20 23:26 +0100, Romain Naour spake thusly:
> Le 20/02/2024 à 22:18, David Picard a écrit :
[--SNIP--]
> >>> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
> >> It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
> >> in their name :)

It's not common, but we do already have a bunch of such packages:

    $ git grep -E 'PROPRIETARY\>' package/ boot/ |wc -l
    13

[--SNIP--]
> > I did it on purpose. This package is called a library, but it really is a bunch
> > of C files. You only use a subset, depending on your hardware. This code was
> > made to be compiled in the application, not as a conventional library.
> > I could copy the files to STAGING, but cleaning would be more complicated and it
> > would waste some disk space.
> Ok, maybe is should not be packaged in Buildroot then.
> When a package is build by Buildroot, it can generate a binary, a library or
> provide some header files.
> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
> download step.

I agree with Romain. It does not make miuch sense IMHO to just drop
source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
tailored to such cases.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot