All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
@ 2024-02-13 16:31 David Picard
  0 siblings, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-13 16:31 UTC (permalink / raw)
  To: buildroot; +Cc: David Picard, Thomas Petazzoni

Add a package for the Intel/Altera SoC FPGA hardware library. It is
used to let the HPS and the FPGA fabric communicate with each other.

Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
---
 package/Config.in                             |  1 +
 package/intel-socfpga-hwlib/Config.in         | 12 ++++++
 .../intel-socfpga-hwlib.hash                  |  2 +
 .../intel-socfpga-hwlib.mk                    | 39 +++++++++++++++++++
 4 files changed, 54 insertions(+)
 create mode 100644 package/intel-socfpga-hwlib/Config.in
 create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
 create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk

diff --git a/package/Config.in b/package/Config.in
index bf0fe078b9..cd6c6bcaba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1736,6 +1736,7 @@ menu "Hardware handling"
 	source "package/gnu-efi/Config.in"
 	source "package/hackrf/Config.in"
 	source "package/hidapi/Config.in"
+	source "package/intel-socfpga-hwlib/Config.in"
 	source "package/jitterentropy-library/Config.in"
 	source "package/lcdapi/Config.in"
 	source "package/let-me-create/Config.in"
diff --git a/package/intel-socfpga-hwlib/Config.in b/package/intel-socfpga-hwlib/Config.in
new file mode 100644
index 0000000000..ced6483a59
--- /dev/null
+++ b/package/intel-socfpga-hwlib/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
+	bool "intel-socfpga-hwlib"
+	depends on BR2_arm
+	help
+	  This package provides the Intel SoC FPGA HWLIB for
+	  Intel/Altera SoC FPGA chips.
+	  This library allows to communicate with the FPGA fabric from
+	  Linux, running on the HPS device.
+	  The source code is not compiled. Instead, a symlink is added
+	  to $(STAGING_DIR)/lib.
+
+	  https://github.com/altera-opensource/intel-socfpga-hwlib
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
new file mode 100644
index 0000000000..60efe9013e
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
@@ -0,0 +1,2 @@
+sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4  intel-socfpga-hwlib-23.12.02.tar.gz
+sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484  License.txt
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
new file mode 100644
index 0000000000..bf18c23560
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# intel-socfpga-hwlib
+#
+################################################################################
+
+INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
+INTEL_SOCFPGA_HWLIB_SITE = $(call github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
+INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
+INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
+INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
+INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
+
+define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
+	ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION) $(STAGING_DIR)/lib/intel-socfpga-hwlib
+endef
+
+# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
+# 	mkdir -p $(BINARIES_DIR)/intel-ucode
+# 	$(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
+# 		$(@D)/intel-ucode/*
+# endef
+#
+# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
+# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
+# 	mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
+# 	$(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
+# 		$(@D)/intel-ucode/*
+# endef
+# else
+# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
+# endif
+
+# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
+# 	$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
+# 	$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
+# endef
+
+$(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
@ 2024-02-14  8:19 David Picard
  0 siblings, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-14  8:19 UTC (permalink / raw)
  To: buildroot; +Cc: David Picard, Thomas Petazzoni

Add a package for the Intel/Altera SoC FPGA hardware library. It is
used to let the HPS and the FPGA fabric communicate with each other.

Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
---
 package/Config.in                             |  1 +
 package/intel-socfpga-hwlib/Config.in         | 12 ++++++
 .../intel-socfpga-hwlib.hash                  |  2 +
 .../intel-socfpga-hwlib.mk                    | 39 +++++++++++++++++++
 4 files changed, 54 insertions(+)
 create mode 100644 package/intel-socfpga-hwlib/Config.in
 create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
 create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk

diff --git a/package/Config.in b/package/Config.in
index bf0fe078b9..cd6c6bcaba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1736,6 +1736,7 @@ menu "Hardware handling"
 	source "package/gnu-efi/Config.in"
 	source "package/hackrf/Config.in"
 	source "package/hidapi/Config.in"
+	source "package/intel-socfpga-hwlib/Config.in"
 	source "package/jitterentropy-library/Config.in"
 	source "package/lcdapi/Config.in"
 	source "package/let-me-create/Config.in"
diff --git a/package/intel-socfpga-hwlib/Config.in b/package/intel-socfpga-hwlib/Config.in
new file mode 100644
index 0000000000..ced6483a59
--- /dev/null
+++ b/package/intel-socfpga-hwlib/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
+	bool "intel-socfpga-hwlib"
+	depends on BR2_arm
+	help
+	  This package provides the Intel SoC FPGA HWLIB for
+	  Intel/Altera SoC FPGA chips.
+	  This library allows to communicate with the FPGA fabric from
+	  Linux, running on the HPS device.
+	  The source code is not compiled. Instead, a symlink is added
+	  to $(STAGING_DIR)/lib.
+
+	  https://github.com/altera-opensource/intel-socfpga-hwlib
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
new file mode 100644
index 0000000000..60efe9013e
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
@@ -0,0 +1,2 @@
+sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4  intel-socfpga-hwlib-23.12.02.tar.gz
+sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484  License.txt
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
new file mode 100644
index 0000000000..bf18c23560
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# intel-socfpga-hwlib
+#
+################################################################################
+
+INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
+INTEL_SOCFPGA_HWLIB_SITE = $(call github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
+INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
+INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
+INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
+INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
+
+define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
+	ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION) $(STAGING_DIR)/lib/intel-socfpga-hwlib
+endef
+
+# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
+# 	mkdir -p $(BINARIES_DIR)/intel-ucode
+# 	$(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
+# 		$(@D)/intel-ucode/*
+# endef
+#
+# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
+# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
+# 	mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
+# 	$(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
+# 		$(@D)/intel-ucode/*
+# endef
+# else
+# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
+# endif
+
+# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
+# 	$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
+# 	$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
+# endef
+
+$(eval $(generic-package))
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
@ 2024-02-14  9:29 David Picard
  0 siblings, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-14  9:29 UTC (permalink / raw)
  To: buildroot; +Cc: David Picard, Thomas Petazzoni

Add a package for the Intel/Altera SoC FPGA hardware library. It is
used to let the HPS and the FPGA fabric communicate with each other.

Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
---
package/Config.in | 1 +
package/intel-socfpga-hwlib/Config.in | 12 ++++++
.../intel-socfpga-hwlib.hash | 2 +
.../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
4 files changed, 54 insertions(+)
create mode 100644 package/intel-socfpga-hwlib/Config.in
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk

diff --git a/package/Config.in b/package/Config.in
index bf0fe078b9..cd6c6bcaba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1736,6 +1736,7 @@ menu "Hardware handling"
source "package/gnu-efi/Config.in"
source "package/hackrf/Config.in"
source "package/hidapi/Config.in"
+ source "package/intel-socfpga-hwlib/Config.in"
source "package/jitterentropy-library/Config.in"
source "package/lcdapi/Config.in"
source "package/let-me-create/Config.in"
diff --git a/package/intel-socfpga-hwlib/Config.in 
b/package/intel-socfpga-hwlib/Config.in
new file mode 100644
index 0000000000..ced6483a59
--- /dev/null
+++ b/package/intel-socfpga-hwlib/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
+ bool "intel-socfpga-hwlib"
+ depends on BR2_arm
+ help
+ This package provides the Intel SoC FPGA HWLIB for
+ Intel/Altera SoC FPGA chips.
+ This library allows to communicate with the FPGA fabric from
+ Linux, running on the HPS device.
+ The source code is not compiled. Instead, a symlink is added
+ to $(STAGING_DIR)/lib.
+
+ https://github.com/altera-opensource/intel-socfpga-hwlib
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
new file mode 100644
index 0000000000..60efe9013e
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
@@ -0,0 +1,2 @@
+sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4 
intel-socfpga-hwlib-23.12.02.tar.gz
+sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484 
License.txt
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
new file mode 100644
index 0000000000..bf18c23560
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# intel-socfpga-hwlib
+#
+################################################################################
+
+INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
+INTEL_SOCFPGA_HWLIB_SITE = $(call 
github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
+INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
+INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
+INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
+INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
+
+define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
+ ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION) 
$(STAGING_DIR)/lib/intel-socfpga-hwlib
+endef
+
+# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
+# mkdir -p $(BINARIES_DIR)/intel-ucode
+# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+#
+# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
+# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
+# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
+# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+# else
+# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
+# endif
+
+# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
+# endef
+
+$(eval $(generic-package))

-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
@ 2024-02-14  9:32 David Picard
  0 siblings, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-14  9:32 UTC (permalink / raw)
  To: buildroot; +Cc: David Picard, Thomas Petazzoni

Add a package for the Intel/Altera SoC FPGA hardware library. It is
used to let the HPS and the FPGA fabric communicate with each other.

Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
---
package/Config.in | 1 +
package/intel-socfpga-hwlib/Config.in | 12 ++++++
.../intel-socfpga-hwlib.hash | 2 +
.../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
4 files changed, 54 insertions(+)
create mode 100644 package/intel-socfpga-hwlib/Config.in
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk

diff --git a/package/Config.in b/package/Config.in
index bf0fe078b9..cd6c6bcaba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1736,6 +1736,7 @@ menu "Hardware handling"
source "package/gnu-efi/Config.in"
source "package/hackrf/Config.in"
source "package/hidapi/Config.in"
+ source "package/intel-socfpga-hwlib/Config.in"
source "package/jitterentropy-library/Config.in"
source "package/lcdapi/Config.in"
source "package/let-me-create/Config.in"
diff --git a/package/intel-socfpga-hwlib/Config.in 
b/package/intel-socfpga-hwlib/Config.in
new file mode 100644
index 0000000000..ced6483a59
--- /dev/null
+++ b/package/intel-socfpga-hwlib/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
+ bool "intel-socfpga-hwlib"
+ depends on BR2_arm
+ help
+ This package provides the Intel SoC FPGA HWLIB for
+ Intel/Altera SoC FPGA chips.
+ This library allows to communicate with the FPGA fabric from
+ Linux, running on the HPS device.
+ The source code is not compiled. Instead, a symlink is added
+ to $(STAGING_DIR)/lib.
+
+ https://github.com/altera-opensource/intel-socfpga-hwlib
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
new file mode 100644
index 0000000000..60efe9013e
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
@@ -0,0 +1,2 @@
+sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4 
intel-socfpga-hwlib-23.12.02.tar.gz
+sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484 
License.txt
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
new file mode 100644
index 0000000000..bf18c23560
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# intel-socfpga-hwlib
+#
+################################################################################
+
+INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
+INTEL_SOCFPGA_HWLIB_SITE = $(call 
github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
+INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
+INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
+INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
+INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
+
+define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
+ ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION) 
$(STAGING_DIR)/lib/intel-socfpga-hwlib
+endef
+
+# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
+# mkdir -p $(BINARIES_DIR)/intel-ucode
+# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+#
+# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
+# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
+# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
+# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+# else
+# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
+# endif
+
+# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
+# endef
+
+$(eval $(generic-package))

-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
@ 2024-02-14  9:34 David Picard
  2024-02-14 16:23 ` Romain Naour
  0 siblings, 1 reply; 14+ messages in thread
From: David Picard @ 2024-02-14  9:34 UTC (permalink / raw)
  To: buildroot

Add a package for the Intel/Altera SoC FPGA hardware library. It is
used to let the HPS and the FPGA fabric communicate with each other.

Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
---
package/Config.in | 1 +
package/intel-socfpga-hwlib/Config.in | 12 ++++++
.../intel-socfpga-hwlib.hash | 2 +
.../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
4 files changed, 54 insertions(+)
create mode 100644 package/intel-socfpga-hwlib/Config.in
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk

diff --git a/package/Config.in b/package/Config.in
index bf0fe078b9..cd6c6bcaba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1736,6 +1736,7 @@ menu "Hardware handling"
source "package/gnu-efi/Config.in"
source "package/hackrf/Config.in"
source "package/hidapi/Config.in"
+ source "package/intel-socfpga-hwlib/Config.in"
source "package/jitterentropy-library/Config.in"
source "package/lcdapi/Config.in"
source "package/let-me-create/Config.in"
diff --git a/package/intel-socfpga-hwlib/Config.in 
b/package/intel-socfpga-hwlib/Config.in
new file mode 100644
index 0000000000..ced6483a59
--- /dev/null
+++ b/package/intel-socfpga-hwlib/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
+ bool "intel-socfpga-hwlib"
+ depends on BR2_arm
+ help
+ This package provides the Intel SoC FPGA HWLIB for
+ Intel/Altera SoC FPGA chips.
+ This library allows to communicate with the FPGA fabric from
+ Linux, running on the HPS device.
+ The source code is not compiled. Instead, a symlink is added
+ to $(STAGING_DIR)/lib.
+
+ https://github.com/altera-opensource/intel-socfpga-hwlib
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
new file mode 100644
index 0000000000..60efe9013e
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
@@ -0,0 +1,2 @@
+sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4 
intel-socfpga-hwlib-23.12.02.tar.gz
+sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484 
License.txt
diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk 
b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
new file mode 100644
index 0000000000..bf18c23560
--- /dev/null
+++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# intel-socfpga-hwlib
+#
+################################################################################
+
+INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
+INTEL_SOCFPGA_HWLIB_SITE = $(call 
github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
+INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
+INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
+INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
+INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
+
+define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
+ ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION) 
$(STAGING_DIR)/lib/intel-socfpga-hwlib
+endef
+
+# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
+# mkdir -p $(BINARIES_DIR)/intel-ucode
+# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+#
+# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
+# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
+# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
+# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
+# $(@D)/intel-ucode/*
+# endef
+# else
+# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
+# endif
+
+# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
+# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
+# endef
+
+$(eval $(generic-package))

-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-14  9:34 [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package David Picard
@ 2024-02-14 16:23 ` Romain Naour
  2024-02-15  7:40   ` David Picard
  2024-02-20 21:18   ` David Picard
  0 siblings, 2 replies; 14+ messages in thread
From: Romain Naour @ 2024-02-14 16:23 UTC (permalink / raw)
  To: David Picard, buildroot

Hello David,

Le 14/02/2024 à 10:34, David Picard a écrit :
> Add a package for the Intel/Altera SoC FPGA hardware library. It is
> used to let the HPS and the FPGA fabric communicate with each other.

We received 4 thime the same patch on the mailing list:

http://patchwork.ozlabs.org/project/buildroot/patch/20240214081921.4663-1-david.picard@clermont.in2p3.fr/

http://patchwork.ozlabs.org/project/buildroot/patch/2770b2ac-4cec-4d56-81e9-89dfd33f786a@clermont.in2p3.fr/

http://patchwork.ozlabs.org/project/buildroot/patch/abcd4153-41e2-45ce-a89a-e198e86ba337@clermont.in2p3.fr/

http://patchwork.ozlabs.org/project/buildroot/patch/c90e4512-405c-40fb-b597-1a04d7449afa@clermont.in2p3.fr/

Which one should we review?

Please, send patch using git send-email tool.

(https://nightly.buildroot.org/manual.html#submitting-patches)

Also, when you resend a patch, add the changelog info.

https://nightly.buildroot.org/manual.html#_patch_revision_changelog


> 
> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
> ---
> package/Config.in | 1 +
> package/intel-socfpga-hwlib/Config.in | 12 ++++++
> .../intel-socfpga-hwlib.hash | 2 +
> .../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
> 4 files changed, 54 insertions(+)
> create mode 100644 package/intel-socfpga-hwlib/Config.in
> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index bf0fe078b9..cd6c6bcaba 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1736,6 +1736,7 @@ menu "Hardware handling"
> source "package/gnu-efi/Config.in"
> source "package/hackrf/Config.in"
> source "package/hidapi/Config.in"
> + source "package/intel-socfpga-hwlib/Config.in"
> source "package/jitterentropy-library/Config.in"
> source "package/lcdapi/Config.in"
> source "package/let-me-create/Config.in"
> diff --git a/package/intel-socfpga-hwlib/Config.in
> b/package/intel-socfpga-hwlib/Config.in
> new file mode 100644
> index 0000000000..ced6483a59
> --- /dev/null
> +++ b/package/intel-socfpga-hwlib/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
> + bool "intel-socfpga-hwlib"
> + depends on BR2_arm
> + help
> + This package provides the Intel SoC FPGA HWLIB for
> + Intel/Altera SoC FPGA chips.
> + This library allows to communicate with the FPGA fabric from
> + Linux, running on the HPS device.
> + The source code is not compiled. Instead, a symlink is added
> + to $(STAGING_DIR)/lib.
> +
> + https://github.com/altera-opensource/intel-socfpga-hwlib

Check the coding style with ./utils/check-package

> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
> new file mode 100644
> index 0000000000..60efe9013e
> --- /dev/null
> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
> @@ -0,0 +1,2 @@
> +sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4
> intel-socfpga-hwlib-23.12.02.tar.gz
> +sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484
> License.txt
> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
> new file mode 100644
> index 0000000000..bf18c23560
> --- /dev/null
> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
> @@ -0,0 +1,39 @@
> +################################################################################
> +#
> +# intel-socfpga-hwlib
> +#
> +################################################################################
> +
> +INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
> +INTEL_SOCFPGA_HWLIB_SITE = $(call
> github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY

It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
in their name :)

> +INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt

It look like a BSD-3-Clause license

https://spdx.org/licenses/BSD-3-Clause.html

> +INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
> +INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
> +
> +define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
> + ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION)
> $(STAGING_DIR)/lib/intel-socfpga-hwlib
> +endef

I don't think this is what you want to do.

> +
> +# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
> +# mkdir -p $(BINARIES_DIR)/intel-ucode
> +# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
> +# $(@D)/intel-ucode/*
> +# endef
> +#
> +# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
> +# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
> +# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
> +# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
> +# $(@D)/intel-ucode/*
> +# endef
> +# else
> +# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
> +# endif
> +
> +# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
> +# endef

Please, don't add commended code.

Best regards,
Romain


> +
> +$(eval $(generic-package))
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-14 16:23 ` Romain Naour
@ 2024-02-15  7:40   ` David Picard
  2024-02-20 21:18   ` David Picard
  1 sibling, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-15  7:40 UTC (permalink / raw)
  To: Romain Naour, buildroot

Hi,

I screwed up with the mailing list and posted the same patch 5 times. 
You can take any of them and discard the others.

Sorry for the confusion...
David

Le 14/02/2024 à 17:23, Romain Naour a écrit :
> Hello David,
>
> Le 14/02/2024 à 10:34, David Picard a écrit :
>> Add a package for the Intel/Altera SoC FPGA hardware library. It is
>> used to let the HPS and the FPGA fabric communicate with each other.
> We received 4 thime the same patch on the mailing list:
>
> http://patchwork.ozlabs.org/project/buildroot/patch/20240214081921.4663-1-david.picard@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/2770b2ac-4cec-4d56-81e9-89dfd33f786a@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/abcd4153-41e2-45ce-a89a-e198e86ba337@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/c90e4512-405c-40fb-b597-1a04d7449afa@clermont.in2p3.fr/
>
> Which one should we review?
>
> Please, send patch using git send-email tool.
>
> (https://nightly.buildroot.org/manual.html#submitting-patches)
>
> Also, when you resend a patch, add the changelog info.
>
> https://nightly.buildroot.org/manual.html#_patch_revision_changelog
>
>
>> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
>> ---
>> package/Config.in | 1 +
>> package/intel-socfpga-hwlib/Config.in | 12 ++++++
>> .../intel-socfpga-hwlib.hash | 2 +
>> .../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
>> 4 files changed, 54 insertions(+)
>> create mode 100644 package/intel-socfpga-hwlib/Config.in
>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index bf0fe078b9..cd6c6bcaba 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -1736,6 +1736,7 @@ menu "Hardware handling"
>> source "package/gnu-efi/Config.in"
>> source "package/hackrf/Config.in"
>> source "package/hidapi/Config.in"
>> + source "package/intel-socfpga-hwlib/Config.in"
>> source "package/jitterentropy-library/Config.in"
>> source "package/lcdapi/Config.in"
>> source "package/let-me-create/Config.in"
>> diff --git a/package/intel-socfpga-hwlib/Config.in
>> b/package/intel-socfpga-hwlib/Config.in
>> new file mode 100644
>> index 0000000000..ced6483a59
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
>> + bool "intel-socfpga-hwlib"
>> + depends on BR2_arm
>> + help
>> + This package provides the Intel SoC FPGA HWLIB for
>> + Intel/Altera SoC FPGA chips.
>> + This library allows to communicate with the FPGA fabric from
>> + Linux, running on the HPS device.
>> + The source code is not compiled. Instead, a symlink is added
>> + to $(STAGING_DIR)/lib.
>> +
>> + https://github.com/altera-opensource/intel-socfpga-hwlib
> Check the coding style with ./utils/check-package
>
>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> new file mode 100644
>> index 0000000000..60efe9013e
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> @@ -0,0 +1,2 @@
>> +sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4
>> intel-socfpga-hwlib-23.12.02.tar.gz
>> +sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484
>> License.txt
>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> new file mode 100644
>> index 0000000000..bf18c23560
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> @@ -0,0 +1,39 @@
>> +################################################################################
>> +#
>> +# intel-socfpga-hwlib
>> +#
>> +################################################################################
>> +
>> +INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
>> +INTEL_SOCFPGA_HWLIB_SITE = $(call
>> github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
>> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
> It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
> in their name :)
>
>> +INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
> It look like a BSD-3-Clause license
>
> https://spdx.org/licenses/BSD-3-Clause.html
>
>> +INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
>> +INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
>> +
>> +define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
>> + ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION)
>> $(STAGING_DIR)/lib/intel-socfpga-hwlib
>> +endef
> I don't think this is what you want to do.
>
>> +
>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
>> +# mkdir -p $(BINARIES_DIR)/intel-ucode
>> +# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
>> +# $(@D)/intel-ucode/*
>> +# endef
>> +#
>> +# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
>> +# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
>> +# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
>> +# $(@D)/intel-ucode/*
>> +# endef
>> +# else
>> +# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
>> +# endif
>> +
>> +# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
>> +# endef
> Please, don't add commended code.
>
> Best regards,
> Romain
>
>
>> +
>> +$(eval $(generic-package))
>>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-14 16:23 ` Romain Naour
  2024-02-15  7:40   ` David Picard
@ 2024-02-20 21:18   ` David Picard
  2024-02-20 22:26     ` Romain Naour
  1 sibling, 1 reply; 14+ messages in thread
From: David Picard @ 2024-02-20 21:18 UTC (permalink / raw)
  To: Romain Naour, buildroot

Hi,

I checked my subscription options, but I don't receive the messages I 
send to the list.

My comments are in the text.

Le 14/02/2024 à 17:23, Romain Naour a écrit :
> Hello David,
>
> Le 14/02/2024 à 10:34, David Picard a écrit :
>> Add a package for the Intel/Altera SoC FPGA hardware library. It is
>> used to let the HPS and the FPGA fabric communicate with each other.
> We received 4 thime the same patch on the mailing list:
>
> http://patchwork.ozlabs.org/project/buildroot/patch/20240214081921.4663-1-david.picard@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/2770b2ac-4cec-4d56-81e9-89dfd33f786a@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/abcd4153-41e2-45ce-a89a-e198e86ba337@clermont.in2p3.fr/
>
> http://patchwork.ozlabs.org/project/buildroot/patch/c90e4512-405c-40fb-b597-1a04d7449afa@clermont.in2p3.fr/
>
> Which one should we review?
>
> Please, send patch using git send-email tool.
>
> (https://nightly.buildroot.org/manual.html#submitting-patches)
>
> Also, when you resend a patch, add the changelog info.
>
> https://nightly.buildroot.org/manual.html#_patch_revision_changelog
>
>
>> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
>> ---
>> package/Config.in | 1 +
>> package/intel-socfpga-hwlib/Config.in | 12 ++++++
>> .../intel-socfpga-hwlib.hash | 2 +
>> .../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
>> 4 files changed, 54 insertions(+)
>> create mode 100644 package/intel-socfpga-hwlib/Config.in
>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index bf0fe078b9..cd6c6bcaba 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -1736,6 +1736,7 @@ menu "Hardware handling"
>> source "package/gnu-efi/Config.in"
>> source "package/hackrf/Config.in"
>> source "package/hidapi/Config.in"
>> + source "package/intel-socfpga-hwlib/Config.in"
>> source "package/jitterentropy-library/Config.in"
>> source "package/lcdapi/Config.in"
>> source "package/let-me-create/Config.in"
>> diff --git a/package/intel-socfpga-hwlib/Config.in
>> b/package/intel-socfpga-hwlib/Config.in
>> new file mode 100644
>> index 0000000000..ced6483a59
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
>> + bool "intel-socfpga-hwlib"
>> + depends on BR2_arm
>> + help
>> + This package provides the Intel SoC FPGA HWLIB for
>> + Intel/Altera SoC FPGA chips.
>> + This library allows to communicate with the FPGA fabric from
>> + Linux, running on the HPS device.
>> + The source code is not compiled. Instead, a symlink is added
>> + to $(STAGING_DIR)/lib.
>> +
>> + https://github.com/altera-opensource/intel-socfpga-hwlib
> Check the coding style with ./utils/check-package
>
>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> new file mode 100644
>> index 0000000000..60efe9013e
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>> @@ -0,0 +1,2 @@
>> +sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4
>> intel-socfpga-hwlib-23.12.02.tar.gz
>> +sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484
>> License.txt
>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> new file mode 100644
>> index 0000000000..bf18c23560
>> --- /dev/null
>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>> @@ -0,0 +1,39 @@
>> +################################################################################
>> +#
>> +# intel-socfpga-hwlib
>> +#
>> +################################################################################
>> +
>> +INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
>> +INTEL_SOCFPGA_HWLIB_SITE = $(call
>> github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
>> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
> It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
> in their name :)
I think "Intel" is the best match : https://spdx.org/licenses/Intel.html
>
>> +INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
> It look like a BSD-3-Clause license
>
> https://spdx.org/licenses/BSD-3-Clause.html
>
>> +INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
>> +INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
>> +
>> +define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
>> + ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION)
>> $(STAGING_DIR)/lib/intel-socfpga-hwlib
>> +endef
> I don't think this is what you want to do.
I did it on purpose. This package is called a library, but it really is 
a bunch of C files. You only use a subset, depending on your hardware. 
This code was made to be compiled in the application, not as a 
conventional library.
I could copy the files to STAGING, but cleaning would be more 
complicated and it would waste some disk space.

>
>> +
>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
>> +# mkdir -p $(BINARIES_DIR)/intel-ucode
>> +# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
>> +# $(@D)/intel-ucode/*
>> +# endef
>> +#
>> +# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
>> +# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
>> +# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
>> +# $(@D)/intel-ucode/*
>> +# endef
>> +# else
>> +# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
>> +# endif
>> +
>> +# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
>> +# endef
> Please, don't add commended code.
Of course not. I'll clean it.

Thanks for reviewing,
David
>
> Best regards,
> Romain
>
>
>> +
>> +$(eval $(generic-package))
>>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-20 21:18   ` David Picard
@ 2024-02-20 22:26     ` Romain Naour
  2024-02-21  6:28       ` Yann E. MORIN
  0 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2024-02-20 22:26 UTC (permalink / raw)
  To: David Picard, buildroot

Hello David,

Le 20/02/2024 à 22:18, David Picard a écrit :
> Hi,
> 
> I checked my subscription options, but I don't receive the messages I send to
> the list.
> 
> My comments are in the text.
> 
> Le 14/02/2024 à 17:23, Romain Naour a écrit :
>> Hello David,
>>
>> Le 14/02/2024 à 10:34, David Picard a écrit :
>>> Add a package for the Intel/Altera SoC FPGA hardware library. It is
>>> used to let the HPS and the FPGA fabric communicate with each other.
>> We received 4 thime the same patch on the mailing list:
>>
>> http://patchwork.ozlabs.org/project/buildroot/patch/20240214081921.4663-1-david.picard@clermont.in2p3.fr/
>>
>> http://patchwork.ozlabs.org/project/buildroot/patch/2770b2ac-4cec-4d56-81e9-89dfd33f786a@clermont.in2p3.fr/
>>
>> http://patchwork.ozlabs.org/project/buildroot/patch/abcd4153-41e2-45ce-a89a-e198e86ba337@clermont.in2p3.fr/
>>
>> http://patchwork.ozlabs.org/project/buildroot/patch/c90e4512-405c-40fb-b597-1a04d7449afa@clermont.in2p3.fr/
>>
>> Which one should we review?
>>
>> Please, send patch using git send-email tool.
>>
>> (https://nightly.buildroot.org/manual.html#submitting-patches)
>>
>> Also, when you resend a patch, add the changelog info.
>>
>> https://nightly.buildroot.org/manual.html#_patch_revision_changelog
>>
>>
>>> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
>>> ---
>>> package/Config.in | 1 +
>>> package/intel-socfpga-hwlib/Config.in | 12 ++++++
>>> .../intel-socfpga-hwlib.hash | 2 +
>>> .../intel-socfpga-hwlib.mk | 39 +++++++++++++++++++
>>> 4 files changed, 54 insertions(+)
>>> create mode 100644 package/intel-socfpga-hwlib/Config.in
>>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>>> create mode 100644 package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>>
>>> diff --git a/package/Config.in b/package/Config.in
>>> index bf0fe078b9..cd6c6bcaba 100644
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -1736,6 +1736,7 @@ menu "Hardware handling"
>>> source "package/gnu-efi/Config.in"
>>> source "package/hackrf/Config.in"
>>> source "package/hidapi/Config.in"
>>> + source "package/intel-socfpga-hwlib/Config.in"
>>> source "package/jitterentropy-library/Config.in"
>>> source "package/lcdapi/Config.in"
>>> source "package/let-me-create/Config.in"
>>> diff --git a/package/intel-socfpga-hwlib/Config.in
>>> b/package/intel-socfpga-hwlib/Config.in
>>> new file mode 100644
>>> index 0000000000..ced6483a59
>>> --- /dev/null
>>> +++ b/package/intel-socfpga-hwlib/Config.in
>>> @@ -0,0 +1,12 @@
>>> +config BR2_PACKAGE_INTEL_SOCFPGA_HWLIB
>>> + bool "intel-socfpga-hwlib"
>>> + depends on BR2_arm
>>> + help
>>> + This package provides the Intel SoC FPGA HWLIB for
>>> + Intel/Altera SoC FPGA chips.
>>> + This library allows to communicate with the FPGA fabric from
>>> + Linux, running on the HPS device.
>>> + The source code is not compiled. Instead, a symlink is added
>>> + to $(STAGING_DIR)/lib.
>>> +
>>> + https://github.com/altera-opensource/intel-socfpga-hwlib
>> Check the coding style with ./utils/check-package
>>
>>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>>> new file mode 100644
>>> index 0000000000..60efe9013e
>>> --- /dev/null
>>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.hash
>>> @@ -0,0 +1,2 @@
>>> +sha256 bbf0767facfdf18ca3dbead66b1e98090c4e9731e2b87cf35c3bf13db0c315e4
>>> intel-socfpga-hwlib-23.12.02.tar.gz
>>> +sha256 2ed04f9cc773f88c8d52c05c04bb3d28f376c082bf99b6a3cb5590b1627ad484
>>> License.txt
>>> diff --git a/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>> b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>> new file mode 100644
>>> index 0000000000..bf18c23560
>>> --- /dev/null
>>> +++ b/package/intel-socfpga-hwlib/intel-socfpga-hwlib.mk
>>> @@ -0,0 +1,39 @@
>>> +################################################################################
>>> +#
>>> +# intel-socfpga-hwlib
>>> +#
>>> +################################################################################
>>> +
>>> +INTEL_SOCFPGA_HWLIB_VERSION = 23.12.02
>>> +INTEL_SOCFPGA_HWLIB_SITE = $(call
>>> github,altera-opensource,intel-socfpga-hwlib,rel_master_$(INTEL_SOCFPGA_HWLIB_VERSION)_pr)
>>> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
>> It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
>> in their name :)
> I think "Intel" is the best match : https://spdx.org/licenses/Intel.html

The two are really close indeed, but the Intel one contains "EXPORT LAWS" part
at the end that is missing in the intel-socfpga-hwlib license file.

Also, the Intel use bullet point while BSD use a number (not sure it's really
significant)

>>
>>> +INTEL_SOCFPGA_HWLIB_LICENSE_FILES = License.txt
>> It look like a BSD-3-Clause license
>>
>> https://spdx.org/licenses/BSD-3-Clause.html
>>
>>> +INTEL_SOCFPGA_HWLIB_REDISTRIBUTE = YES
>>> +INTEL_SOCFPGA_HWLIB_INSTALL_STAGING = YES
>>> +
>>> +define INTEL_SOCFPGA_HWLIB_INSTALL_STAGING_CMDS
>>> + ln -s $(BUILD_DIR)/intel-socfpga-hwlib-$(INTEL_SOCFPGA_HWLIB_VERSION)
>>> $(STAGING_DIR)/lib/intel-socfpga-hwlib
>>> +endef
>> I don't think this is what you want to do.
> I did it on purpose. This package is called a library, but it really is a bunch
> of C files. You only use a subset, depending on your hardware. This code was
> made to be compiled in the application, not as a conventional library.
> I could copy the files to STAGING, but cleaning would be more complicated and it
> would waste some disk space.

Ok, maybe is should not be packaged in Buildroot then.

When a package is build by Buildroot, it can generate a binary, a library or
provide some header files.

If your application doesn't bundle intel-socfpga-hwlib sources but it requires
it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
download step.

> 
>>
>>> +
>>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_IMAGES_CMDS
>>> +# mkdir -p $(BINARIES_DIR)/intel-ucode
>>> +# $(INSTALL) -m 0644 -t $(BINARIES_DIR)/intel-ucode \
>>> +# $(@D)/intel-ucode/*
>>> +# endef
>>> +#
>>> +# ifeq ($(BR2_PACKAGE_INTEL_SOCFPGA_HWLIB_INSTALL_TARGET),y)
>>> +# define INTEL_SOCFPGA_HWLIB_INSTALL_TARGET_CMDS
>>> +# mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode
>>> +# $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \
>>> +# $(@D)/intel-ucode/*
>>> +# endef
>>> +# else
>>> +# INTEL_SOCFPGA_HWLIB_INSTALL_TARGET = NO
>>> +# endif
>>> +
>>> +# define INTEL_SOCFPGA_HWLIB_LINUX_CONFIG_FIXUPS
>>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE)
>>> +# $(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL)
>>> +# endef
>> Please, don't add commended code.
> Of course not. I'll clean it.
> 
> Thanks for reviewing,
> David

Best regards,
Romain


>>
>> Best regards,
>> Romain
>>
>>
>>> +
>>> +$(eval $(generic-package))
>>>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-20 22:26     ` Romain Naour
@ 2024-02-21  6:28       ` Yann E. MORIN
  2024-02-21  8:36         ` David Picard
  0 siblings, 1 reply; 14+ messages in thread
From: Yann E. MORIN @ 2024-02-21  6:28 UTC (permalink / raw)
  To: Romain Naour; +Cc: David Picard, buildroot

Romain, David, All,

On 2024-02-20 23:26 +0100, Romain Naour spake thusly:
> Le 20/02/2024 à 22:18, David Picard a écrit :
[--SNIP--]
> >>> +INTEL_SOCFPGA_HWLIB_LICENSE = PROPRIETARY
> >> It's unexpected to find a PROPRIETARY tool in a gitbub accound with "opensource"
> >> in their name :)

It's not common, but we do already have a bunch of such packages:

    $ git grep -E 'PROPRIETARY\>' package/ boot/ |wc -l
    13

[--SNIP--]
> > I did it on purpose. This package is called a library, but it really is a bunch
> > of C files. You only use a subset, depending on your hardware. This code was
> > made to be compiled in the application, not as a conventional library.
> > I could copy the files to STAGING, but cleaning would be more complicated and it
> > would waste some disk space.
> Ok, maybe is should not be packaged in Buildroot then.
> When a package is build by Buildroot, it can generate a binary, a library or
> provide some header files.
> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
> download step.

I agree with Romain. It does not make miuch sense IMHO to just drop
source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
tailored to such cases.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-21  6:28       ` Yann E. MORIN
@ 2024-02-21  8:36         ` David Picard
  2024-02-21 12:25           ` David Picard
  0 siblings, 1 reply; 14+ messages in thread
From: David Picard @ 2024-02-21  8:36 UTC (permalink / raw)
  To: Yann E. MORIN, Romain Naour; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]

So, should I submit a package, using the LIBFOO_EXTRA_DOWNLOADS feature 
? What value would you recommend for LIBFOO_DL_DIR ?

David

Le 21/02/2024 à 07:28, Yann E. MORIN a écrit :
>>> I did it on purpose. This package is called a library, but it really is a bunch
>>> of C files. You only use a subset, depending on your hardware. This code was
>>> made to be compiled in the application, not as a conventional library.
>>> I could copy the files to STAGING, but cleaning would be more complicated and it
>>> would waste some disk space.
>> Ok, maybe is should not be packaged in Buildroot then.
>> When a package is build by Buildroot, it can generate a binary, a library or
>> provide some header files.
>> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
>> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
>> download step.
> I agree with Romain. It does not make miuch sense IMHO to just drop
> source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
> tailored to such cases.

[-- Attachment #1.2: Type: text/html, Size: 1611 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-21  8:36         ` David Picard
@ 2024-02-21 12:25           ` David Picard
  2024-02-21 15:33             ` Romain Naour
  0 siblings, 1 reply; 14+ messages in thread
From: David Picard @ 2024-02-21 12:25 UTC (permalink / raw)
  To: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --]

Or should I add LIBFOO_EXTRA_DOWNLOADS to my application package ?

Le 21/02/2024 à 09:36, David Picard a écrit :
> So, should I submit a package, using the LIBFOO_EXTRA_DOWNLOADS 
> feature ? What value would you recommend for LIBFOO_DL_DIR ?
>
> David
>
> Le 21/02/2024 à 07:28, Yann E. MORIN a écrit :
>>>> I did it on purpose. This package is called a library, but it really is a bunch
>>>> of C files. You only use a subset, depending on your hardware. This code was
>>>> made to be compiled in the application, not as a conventional library.
>>>> I could copy the files to STAGING, but cleaning would be more complicated and it
>>>> would waste some disk space.
>>> Ok, maybe is should not be packaged in Buildroot then.
>>> When a package is build by Buildroot, it can generate a binary, a library or
>>> provide some header files.
>>> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
>>> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
>>> download step.
>> I agree with Romain. It does not make miuch sense IMHO to just drop
>> source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
>> tailored to such cases.
>
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

[-- Attachment #1.2: Type: text/html, Size: 2477 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-21 12:25           ` David Picard
@ 2024-02-21 15:33             ` Romain Naour
  2024-02-22 10:09               ` David Picard
  0 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2024-02-21 15:33 UTC (permalink / raw)
  To: David Picard, buildroot

Hello David,

Le 21/02/2024 à 13:25, David Picard a écrit :
> Or should I add LIBFOO_EXTRA_DOWNLOADS to my application package ?

See an example how to use _EXTRA_DOWNLOADS:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/tesseract-ocr/tesseract-ocr.mk?ref_type=heads#L58

Best regards,
Romain


> 
> Le 21/02/2024 à 09:36, David Picard a écrit :
>> So, should I submit a package, using the LIBFOO_EXTRA_DOWNLOADS feature ? What
>> value would you recommend for LIBFOO_DL_DIR ?
>>
>> David
>>
>> Le 21/02/2024 à 07:28, Yann E. MORIN a écrit :
>>>>> I did it on purpose. This package is called a library, but it really is a bunch
>>>>> of C files. You only use a subset, depending on your hardware. This code was
>>>>> made to be compiled in the application, not as a conventional library.
>>>>> I could copy the files to STAGING, but cleaning would be more complicated and it
>>>>> would waste some disk space.
>>>> Ok, maybe is should not be packaged in Buildroot then.
>>>> When a package is build by Buildroot, it can generate a binary, a library or
>>>> provide some header files.
>>>> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
>>>> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
>>>> download step.
>>> I agree with Romain. It does not make miuch sense IMHO to just drop
>>> source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
>>> tailored to such cases.
>>
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package
  2024-02-21 15:33             ` Romain Naour
@ 2024-02-22 10:09               ` David Picard
  0 siblings, 0 replies; 14+ messages in thread
From: David Picard @ 2024-02-22 10:09 UTC (permalink / raw)
  To: Romain Naour, buildroot

OK, thanks. So I guess my patch can just be discarded. Can I do it my 
self on Patchwork ? If so, to what status should it be changed ?

Le 21/02/2024 à 16:33, Romain Naour a écrit :
> Hello David,
>
> Le 21/02/2024 à 13:25, David Picard a écrit :
>> Or should I add LIBFOO_EXTRA_DOWNLOADS to my application package ?
> See an example how to use _EXTRA_DOWNLOADS:
>
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/tesseract-ocr/tesseract-ocr.mk?ref_type=heads#L58
>
> Best regards,
> Romain
>
>
>> Le 21/02/2024 à 09:36, David Picard a écrit :
>>> So, should I submit a package, using the LIBFOO_EXTRA_DOWNLOADS feature ? What
>>> value would you recommend for LIBFOO_DL_DIR ?
>>>
>>> David
>>>
>>> Le 21/02/2024 à 07:28, Yann E. MORIN a écrit :
>>>>>> I did it on purpose. This package is called a library, but it really is a bunch
>>>>>> of C files. You only use a subset, depending on your hardware. This code was
>>>>>> made to be compiled in the application, not as a conventional library.
>>>>>> I could copy the files to STAGING, but cleaning would be more complicated and it
>>>>>> would waste some disk space.
>>>>> Ok, maybe is should not be packaged in Buildroot then.
>>>>> When a package is build by Buildroot, it can generate a binary, a library or
>>>>> provide some header files.
>>>>> If your application doesn't bundle intel-socfpga-hwlib sources but it requires
>>>>> it to build in Buildroot, you can use LIBFOO_EXTRA_DOWNLOADS to add an extra
>>>>> download step.
>>>> I agree with Romain. It does not make miuch sense IMHO to just drop
>>>> source files like that. And the _EXTRA_DOWNLOADS mechanism is exactly
>>>> tailored to such cases.
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot@buildroot.org
>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-02-22 10:09 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14  9:34 [Buildroot] [PATCH 1/1] package/intel-socfpga-hwlib: add new package David Picard
2024-02-14 16:23 ` Romain Naour
2024-02-15  7:40   ` David Picard
2024-02-20 21:18   ` David Picard
2024-02-20 22:26     ` Romain Naour
2024-02-21  6:28       ` Yann E. MORIN
2024-02-21  8:36         ` David Picard
2024-02-21 12:25           ` David Picard
2024-02-21 15:33             ` Romain Naour
2024-02-22 10:09               ` David Picard
  -- strict thread matches above, loose matches on Subject: below --
2024-02-14  9:32 David Picard
2024-02-14  9:29 David Picard
2024-02-14  8:19 David Picard
2024-02-13 16:31 David Picard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.