From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Mark Brown <broonie@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Wang Kefeng <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed()
Date: Wed, 21 Feb 2024 11:29:38 +0000 [thread overview]
Message-ID: <ZdXeopPukQGXUqoz@shell.armlinux.org.uk> (raw)
In-Reply-To: <202402202235.A77C9AD@keescook>
On Tue, Feb 20, 2024 at 10:39:15PM -0800, Kees Cook wrote:
> On Mon, Jan 22, 2024 at 05:12:38PM -0800, Kees Cook wrote:
> > Under PAN emulation when dumping backtraces from things like the
> > LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU)
> > would happen because of dump_instr() attempting to read a userspace
> > address. Make sure copy_from_kernel_nofault() does not attempt this
> > any more.
> >
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1]
> > Suggested-by: "Russell King (Oracle)" <linux@armlinux.org.uk>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Wang Kefeng <wangkefeng.wang@huawei.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Ben Hutchings <ben@decadent.org.uk>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Russell, do you mind if I carry in my tree the 3 ARM patches I sent?
> They're mostly pretty trivial, and they've been in "Incoming"[1] for 2
> weeks but haven't shown up in -next yet. I'd really like them to get
> some soak time, and for them to reach the v6.9 merge window in time.
They can't show up in -next at the moment because the machine that hosts
my git tree is being moved between data centres. This was originally
flagged as a same-day (Tuesday) move, then next day, then it'll be back
online on Saturday. That's the last update that we've had.
As I don't believe my GPG key has the necessary signatures on, I don't
believe I can get a kernel.org account. I'm not even sure whether my
gpg key is even correct for that - and at the moment I just glaze over
reading the kernel.org gpg documentation.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Mark Brown <broonie@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Wang Kefeng <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed()
Date: Wed, 21 Feb 2024 11:29:38 +0000 [thread overview]
Message-ID: <ZdXeopPukQGXUqoz@shell.armlinux.org.uk> (raw)
In-Reply-To: <202402202235.A77C9AD@keescook>
On Tue, Feb 20, 2024 at 10:39:15PM -0800, Kees Cook wrote:
> On Mon, Jan 22, 2024 at 05:12:38PM -0800, Kees Cook wrote:
> > Under PAN emulation when dumping backtraces from things like the
> > LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU)
> > would happen because of dump_instr() attempting to read a userspace
> > address. Make sure copy_from_kernel_nofault() does not attempt this
> > any more.
> >
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1]
> > Suggested-by: "Russell King (Oracle)" <linux@armlinux.org.uk>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Wang Kefeng <wangkefeng.wang@huawei.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Ben Hutchings <ben@decadent.org.uk>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Russell, do you mind if I carry in my tree the 3 ARM patches I sent?
> They're mostly pretty trivial, and they've been in "Incoming"[1] for 2
> weeks but haven't shown up in -next yet. I'd really like them to get
> some soak time, and for them to reach the v6.9 merge window in time.
They can't show up in -next at the moment because the machine that hosts
my git tree is being moved between data centres. This was originally
flagged as a same-day (Tuesday) move, then next day, then it'll be back
online on Saturday. That's the last update that we've had.
As I don't believe my GPG key has the necessary signatures on, I don't
believe I can get a kernel.org account. I'm not even sure whether my
gpg key is even correct for that - and at the moment I just glaze over
reading the kernel.org gpg documentation.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-21 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 1:12 [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed() Kees Cook
2024-01-23 1:12 ` Kees Cook
2024-01-23 13:44 ` Ard Biesheuvel
2024-01-23 13:44 ` Ard Biesheuvel
2024-01-23 19:02 ` Mark Brown
2024-01-23 19:02 ` Mark Brown
2024-02-21 6:39 ` Kees Cook
2024-02-21 6:39 ` Kees Cook
2024-02-21 11:29 ` Russell King (Oracle) [this message]
2024-02-21 11:29 ` Russell King (Oracle)
2024-02-21 11:31 ` Russell King (Oracle)
2024-02-21 11:31 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdXeopPukQGXUqoz@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=ben@decadent.org.uk \
--cc=broonie@kernel.org \
--cc=hughd@google.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.