* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
@ 2024-02-21 15:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-21 15:39 UTC (permalink / raw)
To: Arnd Bergmann, Javier Martinez Canillas, linux-kernel
Cc: Maxime Ripard, Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
On 21/02/2024 16:31, Arnd Bergmann wrote:
> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>> These options are needed by some Linux distributions (e.g: Fedora), so
>> let's enable them to make it easier for developers using such distros.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>> CONFIG_EXT2_FS=y
>> CONFIG_EXT3_FS=y
>> CONFIG_EXT4_FS_POSIX_ACL=y
>> +CONFIG_XFS_FS=m
>> CONFIG_BTRFS_FS=m
>> CONFIG_BTRFS_FS_POSIX_ACL=y
>
> Unfortunately this will increase build time noticeably, but
> I agree it is the right thing to do.
>
> Can you send it (with any other acks) to soc@kernel.org so
> I can merge it from there?
Due to XFS, please include:
Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
so this will not be precedence used for further patches like this
(Maxime already used such argument, so I want to be sure it will not be
used against me in the future)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
2024-02-21 15:39 ` Krzysztof Kozlowski
@ 2024-02-21 15:49 ` Maxime Ripard
-1 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2024-02-21 15:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Javier Martinez Canillas, linux-kernel,
Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1332 bytes --]
On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
> On 21/02/2024 16:31, Arnd Bergmann wrote:
> > On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
> >> These options are needed by some Linux distributions (e.g: Fedora), so
> >> let's enable them to make it easier for developers using such distros.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> ---
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> >> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
> >> CONFIG_EXT2_FS=y
> >> CONFIG_EXT3_FS=y
> >> CONFIG_EXT4_FS_POSIX_ACL=y
> >> +CONFIG_XFS_FS=m
> >> CONFIG_BTRFS_FS=m
> >> CONFIG_BTRFS_FS_POSIX_ACL=y
> >
> > Unfortunately this will increase build time noticeably, but
> > I agree it is the right thing to do.
> >
> > Can you send it (with any other acks) to soc@kernel.org so
> > I can merge it from there?
>
> Due to XFS, please include:
>
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)
For the record, I didn't use anything against *you*. I'd just like
consistency over how defconfig rules are applied.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
@ 2024-02-21 15:49 ` Maxime Ripard
0 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2024-02-21 15:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Javier Martinez Canillas, linux-kernel,
Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
> On 21/02/2024 16:31, Arnd Bergmann wrote:
> > On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
> >> These options are needed by some Linux distributions (e.g: Fedora), so
> >> let's enable them to make it easier for developers using such distros.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> ---
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> >> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
> >> CONFIG_EXT2_FS=y
> >> CONFIG_EXT3_FS=y
> >> CONFIG_EXT4_FS_POSIX_ACL=y
> >> +CONFIG_XFS_FS=m
> >> CONFIG_BTRFS_FS=m
> >> CONFIG_BTRFS_FS_POSIX_ACL=y
> >
> > Unfortunately this will increase build time noticeably, but
> > I agree it is the right thing to do.
> >
> > Can you send it (with any other acks) to soc@kernel.org so
> > I can merge it from there?
>
> Due to XFS, please include:
>
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)
For the record, I didn't use anything against *you*. I'd just like
consistency over how defconfig rules are applied.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
2024-02-21 15:49 ` Maxime Ripard
@ 2024-02-21 15:52 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-21 15:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: Arnd Bergmann, Javier Martinez Canillas, linux-kernel,
Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
On 21/02/2024 16:49, Maxime Ripard wrote:
> On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
>> On 21/02/2024 16:31, Arnd Bergmann wrote:
>>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>>> let's enable them to make it easier for developers using such distros.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>>> ---
>>>
>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>>> CONFIG_EXT2_FS=y
>>>> CONFIG_EXT3_FS=y
>>>> CONFIG_EXT4_FS_POSIX_ACL=y
>>>> +CONFIG_XFS_FS=m
>>>> CONFIG_BTRFS_FS=m
>>>> CONFIG_BTRFS_FS_POSIX_ACL=y
>>>
>>> Unfortunately this will increase build time noticeably, but
>>> I agree it is the right thing to do.
>>>
>>> Can you send it (with any other acks) to soc@kernel.org so
>>> I can merge it from there?
>>
>> Due to XFS, please include:
>>
>> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> so this will not be precedence used for further patches like this
>> (Maxime already used such argument, so I want to be sure it will not be
>> used against me in the future)
>
> For the record, I didn't use anything against *you*. I'd just like
> consistency over how defconfig rules are applied.
True, apologies if it seemed to harsh. I meant the discussion, so maybe
better:
"Maxime used such argument with discussion with me, so I want to be sure
there is no silent ack from me in the future."
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
@ 2024-02-21 15:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-21 15:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: Arnd Bergmann, Javier Martinez Canillas, linux-kernel,
Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
On 21/02/2024 16:49, Maxime Ripard wrote:
> On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
>> On 21/02/2024 16:31, Arnd Bergmann wrote:
>>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>>> let's enable them to make it easier for developers using such distros.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>>> ---
>>>
>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>>> CONFIG_EXT2_FS=y
>>>> CONFIG_EXT3_FS=y
>>>> CONFIG_EXT4_FS_POSIX_ACL=y
>>>> +CONFIG_XFS_FS=m
>>>> CONFIG_BTRFS_FS=m
>>>> CONFIG_BTRFS_FS_POSIX_ACL=y
>>>
>>> Unfortunately this will increase build time noticeably, but
>>> I agree it is the right thing to do.
>>>
>>> Can you send it (with any other acks) to soc@kernel.org so
>>> I can merge it from there?
>>
>> Due to XFS, please include:
>>
>> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> so this will not be precedence used for further patches like this
>> (Maxime already used such argument, so I want to be sure it will not be
>> used against me in the future)
>
> For the record, I didn't use anything against *you*. I'd just like
> consistency over how defconfig rules are applied.
True, apologies if it seemed to harsh. I meant the discussion, so maybe
better:
"Maxime used such argument with discussion with me, so I want to be sure
there is no silent ack from me in the future."
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
2024-02-21 15:39 ` Krzysztof Kozlowski
@ 2024-02-21 19:06 ` Javier Martinez Canillas
-1 siblings, 0 replies; 14+ messages in thread
From: Javier Martinez Canillas @ 2024-02-21 19:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, Arnd Bergmann, linux-kernel
Cc: Maxime Ripard, Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> On 21/02/2024 16:31, Arnd Bergmann wrote:
>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>> let's enable them to make it easier for developers using such distros.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>> ---
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>
>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>> CONFIG_EXT2_FS=y
>>> CONFIG_EXT3_FS=y
>>> CONFIG_EXT4_FS_POSIX_ACL=y
>>> +CONFIG_XFS_FS=m
>>> CONFIG_BTRFS_FS=m
>>> CONFIG_BTRFS_FS_POSIX_ACL=y
>>
>> Unfortunately this will increase build time noticeably, but
>> I agree it is the right thing to do.
>>
>> Can you send it (with any other acks) to soc@kernel.org so
>> I can merge it from there?
>
> Due to XFS, please include:
>
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Don't worry, I won't to re-send anything if you disagree with the change.
> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)
>
I used the same argument and is a fair one in my opinion. Removing other
filesystems should send the correct message, if that is the agreegment.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable zram, xfs and loading compressed FW support
@ 2024-02-21 19:06 ` Javier Martinez Canillas
0 siblings, 0 replies; 14+ messages in thread
From: Javier Martinez Canillas @ 2024-02-21 19:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, Arnd Bergmann, linux-kernel
Cc: Maxime Ripard, Erico Nunes, Enric Balletbo i Serra, Brian Masney,
Bjorn Andersson, Catalin Marinas, Geert Uytterhoeven,
Konrad Dybcio, Marek Szyprowski, Neil Armstrong, Will Deacon,
linux-arm-kernel
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> On 21/02/2024 16:31, Arnd Bergmann wrote:
>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>> let's enable them to make it easier for developers using such distros.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>> ---
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>
>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>> CONFIG_EXT2_FS=y
>>> CONFIG_EXT3_FS=y
>>> CONFIG_EXT4_FS_POSIX_ACL=y
>>> +CONFIG_XFS_FS=m
>>> CONFIG_BTRFS_FS=m
>>> CONFIG_BTRFS_FS_POSIX_ACL=y
>>
>> Unfortunately this will increase build time noticeably, but
>> I agree it is the right thing to do.
>>
>> Can you send it (with any other acks) to soc@kernel.org so
>> I can merge it from there?
>
> Due to XFS, please include:
>
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Don't worry, I won't to re-send anything if you disagree with the change.
> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)
>
I used the same argument and is a fair one in my opinion. Removing other
filesystems should send the correct message, if that is the agreegment.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 14+ messages in thread