All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Yury Norov <yury.norov@gmail.com>,
	netdev@vger.kernel.org,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 RESEND 3/6] bitmap: Make bitmap_onto() available to users
Date: Wed, 21 Feb 2024 16:30:11 +0200	[thread overview]
Message-ID: <ZdYI81yKNisoLR7Y@smile.fi.intel.com> (raw)
In-Reply-To: <20240221144431.149c3a16@bootlin.com>

On Wed, Feb 21, 2024 at 02:44:31PM +0100, Herve Codina wrote:
> On Thu, 15 Feb 2024 21:17:23 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

[...]

> > > Now what's the plan ?
> > > Andy, do you want to send a v2 of this patch or may I get the patch, modify it
> > > according to reviews already present in v1 and integrate it in my current
> > > series ?  
> > 
> > I would like to do that, but under pile of different things.
> > I would try my best but if you have enough time and motivation feel free
> > to take over, address the comments and integrate in your series.
> > 
> > I dunno what to do with bitmap_onto(), perhaps in a separate patch we can
> > replace it with bitmap_scatter() (IIUC) with explanation that the former
> > 1) uses atomic ops while being non-atomic as a whole, and b) having quite
> > hard to get documentation. At least that's how I see it, I mean that I would
> > like to leave bitmap_onto() alone and address it separately.
> 
> I will take the Andy's bitmap_{scatter,gather}() patch in my next iteration.
> And use bitmap_{scatter,gather}() in my code.

Thank you and sorry that I have no time to finish that. I will be happy to help
reviewing if you Cc me.

> For bitmap_onto() replacement, nothing will be done in my next iteration as
> it is out of this series scope.

I agree on this. This will be a separate logical change related to NUMA with
explanation and replacement of all callers at once.

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Yury Norov <yury.norov@gmail.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Andrew Lunn <andrew@lunn.ch>,
	Mark Brown <broonie@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 RESEND 3/6] bitmap: Make bitmap_onto() available to users
Date: Wed, 21 Feb 2024 16:30:11 +0200	[thread overview]
Message-ID: <ZdYI81yKNisoLR7Y@smile.fi.intel.com> (raw)
In-Reply-To: <20240221144431.149c3a16@bootlin.com>

On Wed, Feb 21, 2024 at 02:44:31PM +0100, Herve Codina wrote:
> On Thu, 15 Feb 2024 21:17:23 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

[...]

> > > Now what's the plan ?
> > > Andy, do you want to send a v2 of this patch or may I get the patch, modify it
> > > according to reviews already present in v1 and integrate it in my current
> > > series ?  
> > 
> > I would like to do that, but under pile of different things.
> > I would try my best but if you have enough time and motivation feel free
> > to take over, address the comments and integrate in your series.
> > 
> > I dunno what to do with bitmap_onto(), perhaps in a separate patch we can
> > replace it with bitmap_scatter() (IIUC) with explanation that the former
> > 1) uses atomic ops while being non-atomic as a whole, and b) having quite
> > hard to get documentation. At least that's how I see it, I mean that I would
> > like to leave bitmap_onto() alone and address it separately.
> 
> I will take the Andy's bitmap_{scatter,gather}() patch in my next iteration.
> And use bitmap_{scatter,gather}() in my code.

Thank you and sorry that I have no time to finish that. I will be happy to help
reviewing if you Cc me.

> For bitmap_onto() replacement, nothing will be done in my next iteration as
> it is out of this series scope.

I agree on this. This will be a separate logical change related to NUMA with
explanation and replacement of all callers at once.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-02-21 14:31 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  7:56 [PATCH v3 RESEND 0/6] Add support for QMC HDLC Herve Codina
2024-02-12  7:56 ` Herve Codina
2024-02-12  7:56 ` [PATCH v3 RESEND 1/6] net: wan: " Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12 12:22   ` Andy Shevchenko
2024-02-12 12:22     ` Andy Shevchenko
2024-02-22 12:05     ` Herve Codina
2024-02-22 12:05       ` Herve Codina
2024-02-22 13:19       ` Andy Shevchenko
2024-02-22 13:19         ` Andy Shevchenko
2024-02-22 13:21         ` Herve Codina
2024-02-22 13:21           ` Herve Codina
2024-02-12  7:56 ` [PATCH v3 RESEND 2/6] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [PATCH v3 RESEND 3/6] bitmap: Make bitmap_onto() available to users Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12 12:27   ` Andy Shevchenko
2024-02-12 12:27     ` Andy Shevchenko
2024-02-12 13:37     ` Herve Codina
2024-02-12 13:37       ` Herve Codina
2024-02-12 14:01       ` Andy Shevchenko
2024-02-12 14:01         ` Andy Shevchenko
2024-02-12 14:20         ` Herve Codina
2024-02-12 14:20           ` Herve Codina
2024-02-12 14:36           ` Andy Shevchenko
2024-02-12 14:36             ` Andy Shevchenko
2024-02-12 19:13             ` Yury Norov
2024-02-12 19:13               ` Yury Norov
2024-02-15 17:46               ` Herve Codina
2024-02-15 17:46                 ` Herve Codina
2024-02-15 19:17                 ` Andy Shevchenko
2024-02-15 19:17                   ` Andy Shevchenko
2024-02-21 13:44                   ` Herve Codina
2024-02-21 13:44                     ` Herve Codina
2024-02-21 14:30                     ` Andy Shevchenko [this message]
2024-02-21 14:30                       ` Andy Shevchenko
2024-02-12  7:56 ` [PATCH v3 RESEND 4/6] bitmap: Introduce bitmap_off() Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  9:45   ` Rasmus Villemoes
2024-02-12  9:45     ` Rasmus Villemoes
2024-02-12 18:37   ` Yury Norov
2024-02-12 18:37     ` Yury Norov
2024-02-12 18:41     ` Yury Norov
2024-02-12 18:41       ` Yury Norov
2024-02-12  7:56 ` [PATCH v3 RESEND 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [PATCH v3 RESEND 6/6] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 0/6] Add support for QMC HDLC Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 1/6] net: wan: " Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 2/6] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 3/6] bitmap: Make bitmap_onto() available to users Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 4/6] bitmap: Introduce bitmap_off() Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  7:56 ` [RESEND PATCH v3 6/6] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-02-12  7:56   ` Herve Codina
2024-02-12  8:05 ` [PATCH v3 RESEND 0/6] Add support for QMC HDLC Herve Codina
2024-02-12  8:05   ` Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdYI81yKNisoLR7Y@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herve.codina@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.