From: Sean Christopherson <seanjc@google.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test
Date: Thu, 22 Feb 2024 14:42:10 -0800 [thread overview]
Message-ID: <ZdfNwhe2s0Mn2gB4@google.com> (raw)
In-Reply-To: <ZcKYRsNUAngWGy2a@google.com>
On Tue, Feb 06, 2024, Sean Christopherson wrote:
> On Fri, Feb 02, 2024, Sean Christopherson wrote:
> > +int main(int argc, char *argv[])
> > +{
> > + TEST_REQUIRE(is_kvm_sev_supported());
>
> This also needs
>
> TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SEV));
>
> to handle the case where the platform supports SEV, i.e. /dev/sev exists, but
> KVM doesn't support SEV, e.g. if TDP is disabled, if SEV was explicitly disabled
> via module param, etc.
Thinking more about this, I think we should simply delete is_kvm_sev_supported().
(a) it obviously doesn't query _KVM_ support, and (b) if KVM says SEV is supported,
then it darn well actually be supported.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vishal Annapurve <vannapurve@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Andrew Jones <andrew.jones@linux.dev>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Peter Gonda <pgonda@google.com>
Subject: Re: [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test
Date: Thu, 22 Feb 2024 14:42:10 -0800 [thread overview]
Message-ID: <ZdfNwhe2s0Mn2gB4@google.com> (raw)
In-Reply-To: <ZcKYRsNUAngWGy2a@google.com>
On Tue, Feb 06, 2024, Sean Christopherson wrote:
> On Fri, Feb 02, 2024, Sean Christopherson wrote:
> > +int main(int argc, char *argv[])
> > +{
> > + TEST_REQUIRE(is_kvm_sev_supported());
>
> This also needs
>
> TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SEV));
>
> to handle the case where the platform supports SEV, i.e. /dev/sev exists, but
> KVM doesn't support SEV, e.g. if TDP is disabled, if SEV was explicitly disabled
> via module param, etc.
Thinking more about this, I think we should simply delete is_kvm_sev_supported().
(a) it obviously doesn't query _KVM_ support, and (b) if KVM says SEV is supported,
then it darn well actually be supported.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vishal Annapurve <vannapurve@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Andrew Jones <andrew.jones@linux.dev>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Peter Gonda <pgonda@google.com>
Subject: Re: [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test
Date: Thu, 22 Feb 2024 14:42:10 -0800 [thread overview]
Message-ID: <ZdfNwhe2s0Mn2gB4@google.com> (raw)
In-Reply-To: <ZcKYRsNUAngWGy2a@google.com>
On Tue, Feb 06, 2024, Sean Christopherson wrote:
> On Fri, Feb 02, 2024, Sean Christopherson wrote:
> > +int main(int argc, char *argv[])
> > +{
> > + TEST_REQUIRE(is_kvm_sev_supported());
>
> This also needs
>
> TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SEV));
>
> to handle the case where the platform supports SEV, i.e. /dev/sev exists, but
> KVM doesn't support SEV, e.g. if TDP is disabled, if SEV was explicitly disabled
> via module param, etc.
Thinking more about this, I think we should simply delete is_kvm_sev_supported().
(a) it obviously doesn't query _KVM_ support, and (b) if KVM says SEV is supported,
then it darn well actually be supported.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vishal Annapurve <vannapurve@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Andrew Jones <andrew.jones@linux.dev>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Peter Gonda <pgonda@google.com>
Subject: Re: [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test
Date: Thu, 22 Feb 2024 14:42:10 -0800 [thread overview]
Message-ID: <ZdfNwhe2s0Mn2gB4@google.com> (raw)
In-Reply-To: <ZcKYRsNUAngWGy2a@google.com>
On Tue, Feb 06, 2024, Sean Christopherson wrote:
> On Fri, Feb 02, 2024, Sean Christopherson wrote:
> > +int main(int argc, char *argv[])
> > +{
> > + TEST_REQUIRE(is_kvm_sev_supported());
>
> This also needs
>
> TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SEV));
>
> to handle the case where the platform supports SEV, i.e. /dev/sev exists, but
> KVM doesn't support SEV, e.g. if TDP is disabled, if SEV was explicitly disabled
> via module param, etc.
Thinking more about this, I think we should simply delete is_kvm_sev_supported().
(a) it obviously doesn't query _KVM_ support, and (b) if KVM says SEV is supported,
then it darn well actually be supported.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-22 22:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 0:09 [PATCH v8 00/10] KVM: selftests: Add SEV smoke test Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 01/10] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 02/10] KVM: selftests: Make sparsebit structs const where appropriate Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 03/10] KVM: selftests: Add a macro to iterate over a sparsebit range Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 04/10] KVM: selftests: Add support for allocating/managing protected guest memory Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-15 5:26 ` Itaru Kitayama
2024-02-15 5:26 ` Itaru Kitayama
2024-02-15 5:26 ` Itaru Kitayama
2024-02-15 5:26 ` Itaru Kitayama
2024-02-03 0:09 ` [PATCH v8 05/10] KVM: selftests: Add support for protected vm_vaddr_* allocations Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-15 5:29 ` Itaru Kitayama
2024-02-15 5:29 ` Itaru Kitayama
2024-02-15 5:29 ` Itaru Kitayama
2024-02-15 5:29 ` Itaru Kitayama
2024-02-03 0:09 ` [PATCH v8 06/10] KVM: selftests: Explicitly ucall pool from shared memory Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 07/10] KVM: selftests: Allow tagging protected memory in guest page tables Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 08/10] KVM: selftests: Add library for creating and interacting with SEV guests Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 09/10] KVM: selftests: Use the SEV library APIs in the intra-host migration test Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-03 0:09 ` Sean Christopherson
2024-02-06 20:36 ` Sean Christopherson
2024-02-06 20:36 ` Sean Christopherson
2024-02-06 20:36 ` Sean Christopherson
2024-02-06 20:36 ` Sean Christopherson
2024-02-22 22:42 ` Sean Christopherson [this message]
2024-02-22 22:42 ` Sean Christopherson
2024-02-22 22:42 ` Sean Christopherson
2024-02-22 22:42 ` Sean Christopherson
2024-02-22 22:55 ` Sean Christopherson
2024-02-22 22:55 ` Sean Christopherson
2024-02-22 22:55 ` Sean Christopherson
2024-02-22 22:55 ` Sean Christopherson
2024-02-21 18:23 ` [PATCH v8 00/10] KVM: selftests: Add " Carlos Bilbao
2024-02-21 18:23 ` Carlos Bilbao
2024-02-21 18:23 ` Carlos Bilbao
2024-02-21 18:23 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdfNwhe2s0Mn2gB4@google.com \
--to=seanjc@google.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.