CI: MPTCP BPF tests are now validated

CI: MPTCP BPF tests are now validated

[Matthieu Baerts]

Hello,

From today, the CI is now validating MPTCP BPF tests!

To be able to do that, I got some help from Geliang (thanks!) to update
the script used by the CI to launch these tests. I just did the wiring
to run these tests in a new job, in parallel to the other ones, and it
seems working:

https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8186843723

Please tell me if there are anything wrong with that (results,
notifications, summary, etc.)


@Geliang: it looks like the "burst" test is unstable. Do you mind
looking at that please?


Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: CI: MPTCP BPF tests are now validated

[Geliang Tang]

Hi Matt,

On Thu, Mar 07, 2024 at 02:59:14PM +0100, Matthieu Baerts wrote:
> Hello,
> 
> >From today, the CI is now validating MPTCP BPF tests!

Great!

> 
> To be able to do that, I got some help from Geliang (thanks!) to update
> the script used by the CI to launch these tests. I just did the wiring
> to run these tests in a new job, in parallel to the other ones, and it
> seems working:
> 
> https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8186843723
> 
> Please tell me if there are anything wrong with that (results,
> notifications, summary, etc.)
> 
> 
> @Geliang: it looks like the "burst" test is unstable. Do you mind
> looking at that please?

Sure, I'll check it.

Thanks,
-Geliang

> 
> 
> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.

Re: CI: MPTCP BPF tests are now validated

[Geliang Tang]

Hi Matt,

On Mon, 2024-03-11 at 09:54 +0800, Geliang Tang wrote:
> Hi Matt,
> 
> On Thu, Mar 07, 2024 at 02:59:14PM +0100, Matthieu Baerts wrote:
> > Hello,
> > 
> > > From today, the CI is now validating MPTCP BPF tests!
> 
> Great!
> 
> > 
> > To be able to do that, I got some help from Geliang (thanks!) to
> > update
> > the script used by the CI to launch these tests. I just did the
> > wiring
> > to run these tests in a new job, in parallel to the other ones, and
> > it
> > seems working:
> > 
> > https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8186843723
> > 
> > Please tell me if there are anything wrong with that (results,
> > notifications, summary, etc.)
> > 
> > 
> > @Geliang: it looks like the "burst" test is unstable. Do you mind
> > looking at that please?
> 
> Sure, I'll check it.

I checked this. BPF tests fail sometimes with "bytes != total_bytes"
errors. And the following patch can fix it:

https://patchwork.kernel.org/project/mptcp/patch/afe585987759af38b2547056c93d5ae8a0b1f50a.1710938175.git.tanggeliang@kylinos.cn/

Thanks,
-Geliang

> 
> Thanks,
> -Geliang
> 
> > 
> > 
> > Cheers,
> > Matt
> > -- 
> > Sponsored by the NGI0 Core fund.
> 

Re: CI: MPTCP BPF tests are now validated

[Geliang Tang]

Hi Matt,

On Thu, 2024-03-21 at 10:22 +0800, Geliang Tang wrote:
> Hi Matt,
> 
> On Mon, 2024-03-11 at 09:54 +0800, Geliang Tang wrote:
> > Hi Matt,
> > 
> > On Thu, Mar 07, 2024 at 02:59:14PM +0100, Matthieu Baerts wrote:
> > > Hello,
> > > 
> > > > From today, the CI is now validating MPTCP BPF tests!
> > 
> > Great!
> > 
> > > 
> > > To be able to do that, I got some help from Geliang (thanks!) to
> > > update
> > > the script used by the CI to launch these tests. I just did the
> > > wiring
> > > to run these tests in a new job, in parallel to the other ones,
> > > and
> > > it
> > > seems working:
> > > 
> > > https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8186843723
> > > 
> > > Please tell me if there are anything wrong with that (results,
> > > notifications, summary, etc.)
> > > 
> > > 
> > > @Geliang: it looks like the "burst" test is unstable. Do you mind
> > > looking at that please?
> > 
> > Sure, I'll check it.
> 
> I checked this. BPF tests fail sometimes with "bytes != total_bytes"
> errors. And the following patch can fix it:

I finally resolve it. It's because "burst" emits EAGAIN in this case,
we must handle it.

New patch is here:
https://patchwork.kernel.org/project/mptcp/patch/311e074a3ca0465bdc5e4c2283e334bae5ccd306.1711296000.git.tanggeliang@kylinos.cn/

Thanks,
-Geliang

> 
> https://patchwork.kernel.org/project/mptcp/patch/afe585987759af38b2547056c93d5ae8a0b1f50a.1710938175.git.tanggeliang@kylinos.cn/
> 
> Thanks,
> -Geliang
> 
> > 
> > Thanks,
> > -Geliang
> > 
> > > 
> > > 
> > > Cheers,
> > > Matt
> > > -- 
> > > Sponsored by the NGI0 Core fund.
> > 
>