From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, vadim.fedorenko@linux.dev,
arkadiusz.kubalewski@intel.com
Subject: Re: [PATCH net-next] dpll: avoid multiple function calls to dump netdev info
Date: Fri, 1 Mar 2024 16:40:26 +0100 [thread overview]
Message-ID: <ZeH26t7WPkfwUnhs@nanopsycho> (raw)
In-Reply-To: <20240301001607.2925706-1-kuba@kernel.org>
Fri, Mar 01, 2024 at 01:16:07AM CET, kuba@kernel.org wrote:
>Due to compiler oddness and because struct dpll_pin is defined
>in a private header we have to call into dpll code to get
>the handle for the pin associated with a netdev.
>Combine getting the pin pointer and getting the info into
>a single function call by having the helpers take a netdev
>pointer, rather than expecting a pin.
>
>The exports are note needed, networking core can't be a module.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>---
>BTW is the empty nest if the netdev has no pin intentional?
The user can tell if this is or is not supported by kernel easily.
>Should we add a comment explaining why it's there?
Yeah.
next prev parent reply other threads:[~2024-03-01 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 0:16 [PATCH net-next] dpll: avoid multiple function calls to dump netdev info Jakub Kicinski
2024-03-01 15:40 ` Jiri Pirko [this message]
2024-03-01 16:24 ` Eric Dumazet
2024-03-01 17:31 ` Jakub Kicinski
2024-03-02 9:36 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeH26t7WPkfwUnhs@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.