* [PATCH] Fix typo in comment (uin32_t -> uint32_t)
@ 2024-03-01 18:55 Frediano Ziglio
2024-03-02 7:06 ` Zhao Liu
0 siblings, 1 reply; 3+ messages in thread
From: Frediano Ziglio @ 2024-03-01 18:55 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Williamson, Cédric Le Goater, Michael Tokarev,
Laurent Vivier, qemu-trivial
Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
hw/vfio/pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
index 6e64a2654e..4bb7d7d257 100644
--- a/hw/vfio/pci.h
+++ b/hw/vfio/pci.h
@@ -181,7 +181,7 @@ struct VFIOPCIDevice {
Notifier irqchip_change_notifier;
};
-/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
+/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
match hw */
static inline bool vfio_pci_is(VFIOPCIDevice *vdev, uint32_t vendor,
uint32_t device)
{
return (vendor == PCI_ANY_ID || vendor == vdev->vendor_id) &&
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
2024-03-01 18:55 [PATCH] Fix typo in comment (uin32_t -> uint32_t) Frediano Ziglio
@ 2024-03-02 7:06 ` Zhao Liu
2024-03-04 6:04 ` Cédric Le Goater
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Liu @ 2024-03-02 7:06 UTC (permalink / raw)
To: Frediano Ziglio
Cc: qemu-devel, Alex Williamson, Cédric Le Goater,
Michael Tokarev, Laurent Vivier, qemu-trivial
On Fri, Mar 01, 2024 at 06:55:35PM +0000, Frediano Ziglio wrote:
> Date: Fri, 1 Mar 2024 18:55:35 +0000
> From: Frediano Ziglio <freddy77@gmail.com>
> Subject: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
> hw/vfio/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index 6e64a2654e..4bb7d7d257 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -181,7 +181,7 @@ struct VFIOPCIDevice {
> Notifier irqchip_change_notifier;
> };
>
> -/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
> +/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
> match hw */
It would be better to also change the comment style as:
/*
* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
* match hw.
*/
Otherwise,
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
> static inline bool vfio_pci_is(VFIOPCIDevice *vdev, uint32_t vendor,
> uint32_t device)
> {
> return (vendor == PCI_ANY_ID || vendor == vdev->vendor_id) &&
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
2024-03-02 7:06 ` Zhao Liu
@ 2024-03-04 6:04 ` Cédric Le Goater
0 siblings, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2024-03-04 6:04 UTC (permalink / raw)
To: Zhao Liu, Frediano Ziglio
Cc: qemu-devel, Alex Williamson, Michael Tokarev, Laurent Vivier,
qemu-trivial
On 3/2/24 08:06, Zhao Liu wrote:
> On Fri, Mar 01, 2024 at 06:55:35PM +0000, Frediano Ziglio wrote:
>> Date: Fri, 1 Mar 2024 18:55:35 +0000
>> From: Frediano Ziglio <freddy77@gmail.com>
>> Subject: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
>> ---
>> hw/vfio/pci.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
>> index 6e64a2654e..4bb7d7d257 100644
>> --- a/hw/vfio/pci.h
>> +++ b/hw/vfio/pci.h
>> @@ -181,7 +181,7 @@ struct VFIOPCIDevice {
>> Notifier irqchip_change_notifier;
>> };
>>
>> -/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
>> +/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
>> match hw */
>
> It would be better to also change the comment style as:
>
> /*
> * Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
> * match hw.
> */
yes and there is a similar typo in linux-user/fd-trans.c.
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-04 6:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-01 18:55 [PATCH] Fix typo in comment (uin32_t -> uint32_t) Frediano Ziglio
2024-03-02 7:06 ` Zhao Liu
2024-03-04 6:04 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.