[PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[Sakari Ailus]

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on
it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig
options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies
anymore.

 drivers/media/v4l2-core/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
index 331b8e535e5b..d55eff3f31b0 100644
--- a/drivers/media/v4l2-core/Kconfig
+++ b/drivers/media/v4l2-core/Kconfig
@@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
 
 config VIDEO_V4L2_SUBDEV_API
 	bool
-	depends on VIDEO_DEV && MEDIA_CONTROLLER
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
 	help
 	  Enables the V4L2 sub-device pad-level userspace API used to configure
 	  video format, size and frame rate between hardware blocks.
-- 
2.39.2

Re: [PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[Laurent Pinchart]

Hi Sakari,

Thank you for the patch.

On Mon, Mar 04, 2024 at 08:51:25PM +0200, Sakari Ailus wrote:
> MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on
> it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig
> options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies
> anymore.

It seems reasonable to me too, but I think it would make sense to drop
in the same patch the manual selection of MEDIA_CONTROLLER for the
Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

>  drivers/media/v4l2-core/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
> index 331b8e535e5b..d55eff3f31b0 100644
> --- a/drivers/media/v4l2-core/Kconfig
> +++ b/drivers/media/v4l2-core/Kconfig
> @@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
>  
>  config VIDEO_V4L2_SUBDEV_API
>  	bool
> -	depends on VIDEO_DEV && MEDIA_CONTROLLER
> +	depends on VIDEO_DEV
> +	select MEDIA_CONTROLLER
>  	help
>  	  Enables the V4L2 sub-device pad-level userspace API used to configure
>  	  video format, size and frame rate between hardware blocks.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[Sakari Ailus]

Hi Laurent,

On Tue, Mar 05, 2024 at 12:59:07AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.
> 
> On Mon, Mar 04, 2024 at 08:51:25PM +0200, Sakari Ailus wrote:
> > MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on
> > it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig
> > options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies
> > anymore.
> 
> It seems reasonable to me too, but I think it would make sense to drop
> in the same patch the manual selection of MEDIA_CONTROLLER for the
> Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

This should be done, yes, but I'd add a separate patch for it: this one
doesn't require changes elsewhere as such, just enables making them. Same
for the other, few users that depend on MEDIA_CONTROLLER, they need to be
converted, too.

> 
> >  drivers/media/v4l2-core/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
> > index 331b8e535e5b..d55eff3f31b0 100644
> > --- a/drivers/media/v4l2-core/Kconfig
> > +++ b/drivers/media/v4l2-core/Kconfig
> > @@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
> >  
> >  config VIDEO_V4L2_SUBDEV_API
> >  	bool
> > -	depends on VIDEO_DEV && MEDIA_CONTROLLER
> > +	depends on VIDEO_DEV
> > +	select MEDIA_CONTROLLER
> >  	help
> >  	  Enables the V4L2 sub-device pad-level userspace API used to configure
> >  	  video format, size and frame rate between hardware blocks.

-- 
Regards,

Sakari Ailus

Re: [PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[Laurent Pinchart]

On Tue, Mar 05, 2024 at 06:50:15AM +0000, Sakari Ailus wrote:
> On Tue, Mar 05, 2024 at 12:59:07AM +0200, Laurent Pinchart wrote:
> > On Mon, Mar 04, 2024 at 08:51:25PM +0200, Sakari Ailus wrote:
> > > MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on
> > > it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig
> > > options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.
> > > 
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > ---
> > > Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies
> > > anymore.
> > 
> > It seems reasonable to me too, but I think it would make sense to drop
> > in the same patch the manual selection of MEDIA_CONTROLLER for the
> > Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.
> 
> This should be done, yes, but I'd add a separate patch for it: this one
> doesn't require changes elsewhere as such, just enables making them. Same
> for the other, few users that depend on MEDIA_CONTROLLER, they need to be
> converted, too.

I'm OK with a separate patch, but can you send one ? :-)

> > >  drivers/media/v4l2-core/Kconfig | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
> > > index 331b8e535e5b..d55eff3f31b0 100644
> > > --- a/drivers/media/v4l2-core/Kconfig
> > > +++ b/drivers/media/v4l2-core/Kconfig
> > > @@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
> > >  
> > >  config VIDEO_V4L2_SUBDEV_API
> > >  	bool
> > > -	depends on VIDEO_DEV && MEDIA_CONTROLLER
> > > +	depends on VIDEO_DEV
> > > +	select MEDIA_CONTROLLER
> > >  	help
> > >  	  Enables the V4L2 sub-device pad-level userspace API used to configure
> > >  	  video format, size and frame rate between hardware blocks.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/1] media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

[Sakari Ailus]

On Thu, May 23, 2024 at 11:53:56AM +0300, Laurent Pinchart wrote:
> On Tue, Mar 05, 2024 at 06:50:15AM +0000, Sakari Ailus wrote:
> > On Tue, Mar 05, 2024 at 12:59:07AM +0200, Laurent Pinchart wrote:
> > > On Mon, Mar 04, 2024 at 08:51:25PM +0200, Sakari Ailus wrote:
> > > > MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on
> > > > it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig
> > > > options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.
> > > > 
> > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > ---
> > > > Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies
> > > > anymore.
> > > 
> > > It seems reasonable to me too, but I think it would make sense to drop
> > > in the same patch the manual selection of MEDIA_CONTROLLER for the
> > > Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.
> > 
> > This should be done, yes, but I'd add a separate patch for it: this one
> > doesn't require changes elsewhere as such, just enables making them. Same
> > for the other, few users that depend on MEDIA_CONTROLLER, they need to be
> > converted, too.
> 
> I'm OK with a separate patch, but can you send one ? :-)

Yes, a bit later on. This is worth merging without such a change as
also new drivers will need to select both options.

-- 
Sakari Ailus