From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
linux-kernel@vger.kernel.org,
"Eric Biggers" <ebiggers@kernel.org>,
"Evan Green" <evan@rivosinc.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Clément Léger" <cleger@rivosinc.com>,
linux-riscv@lists.infradead.org,
"Charles Lohr" <lohr85@gmail.com>
Subject: Re: [PATCH v6 3/4] riscv: Decouple emulated unaligned accesses from access speed
Date: Wed, 6 Mar 2024 10:25:05 -0800 [thread overview]
Message-ID: <Zei1Ac8RKNJu01Fs@ghost> (raw)
In-Reply-To: <20240306-tactless-decathlon-b0df16517b1b@wendy>
On Wed, Mar 06, 2024 at 01:19:37PM +0000, Conor Dooley wrote:
> On Fri, Mar 01, 2024 at 05:45:34PM -0800, Charlie Jenkins wrote:
>
> > -void unaligned_emulation_finish(void)
> > +bool check_unaligned_access_emulated_all_cpus(void)
> > {
> > int cpu;
> >
> > - /*
> > - * We can only support PR_UNALIGN controls if all CPUs have misaligned
> > - * accesses emulated since tasks requesting such control can run on any
> > - * CPU.
> > - */
>
> Why was this comment removed? This patch doesn't change the situations
> in which PR_UNALIGN is allowed, right?
I'll add it back, that was unintentional. Thank you.
- Charlie
>
> > - for_each_online_cpu(cpu) {
> > - if (per_cpu(misaligned_access_speed, cpu) !=
> > - RISCV_HWPROBE_MISALIGNED_EMULATED) {
> > - return;
> > - }
> > - }
> > + for_each_online_cpu(cpu)
> > + if (check_unaligned_access_emulated(cpu))
> > + return false;
> > +
> > unaligned_ctl = true;
> > + return true;
> > }
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Evan Green" <evan@rivosinc.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Elliot Berman" <quic_eberman@quicinc.com>,
"Charles Lohr" <lohr85@gmail.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/4] riscv: Decouple emulated unaligned accesses from access speed
Date: Wed, 6 Mar 2024 10:25:05 -0800 [thread overview]
Message-ID: <Zei1Ac8RKNJu01Fs@ghost> (raw)
In-Reply-To: <20240306-tactless-decathlon-b0df16517b1b@wendy>
On Wed, Mar 06, 2024 at 01:19:37PM +0000, Conor Dooley wrote:
> On Fri, Mar 01, 2024 at 05:45:34PM -0800, Charlie Jenkins wrote:
>
> > -void unaligned_emulation_finish(void)
> > +bool check_unaligned_access_emulated_all_cpus(void)
> > {
> > int cpu;
> >
> > - /*
> > - * We can only support PR_UNALIGN controls if all CPUs have misaligned
> > - * accesses emulated since tasks requesting such control can run on any
> > - * CPU.
> > - */
>
> Why was this comment removed? This patch doesn't change the situations
> in which PR_UNALIGN is allowed, right?
I'll add it back, that was unintentional. Thank you.
- Charlie
>
> > - for_each_online_cpu(cpu) {
> > - if (per_cpu(misaligned_access_speed, cpu) !=
> > - RISCV_HWPROBE_MISALIGNED_EMULATED) {
> > - return;
> > - }
> > - }
> > + for_each_online_cpu(cpu)
> > + if (check_unaligned_access_emulated(cpu))
> > + return false;
> > +
> > unaligned_ctl = true;
> > + return true;
> > }
>
next prev parent reply other threads:[~2024-03-06 19:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:45 [PATCH v6 0/4] riscv: Use Kconfig to set unaligned access speed Charlie Jenkins
2024-03-02 1:45 ` Charlie Jenkins
2024-03-02 1:45 ` [PATCH v6 1/4] riscv: lib: Introduce has_fast_unaligned_access function Charlie Jenkins
2024-03-02 1:45 ` Charlie Jenkins
2024-03-02 1:45 ` [PATCH v6 2/4] riscv: Only check online cpus for emulated accesses Charlie Jenkins
2024-03-02 1:45 ` Charlie Jenkins
2024-03-06 13:11 ` Conor Dooley
2024-03-06 13:11 ` Conor Dooley
2024-03-02 1:45 ` [PATCH v6 3/4] riscv: Decouple emulated unaligned accesses from access speed Charlie Jenkins
2024-03-02 1:45 ` Charlie Jenkins
2024-03-06 13:19 ` Conor Dooley
2024-03-06 13:19 ` Conor Dooley
2024-03-06 18:25 ` Charlie Jenkins [this message]
2024-03-06 18:25 ` Charlie Jenkins
2024-03-02 1:45 ` [PATCH v6 4/4] riscv: Set unaligned access speed at compile time Charlie Jenkins
2024-03-02 1:45 ` Charlie Jenkins
2024-03-06 16:19 ` Conor Dooley
2024-03-06 16:19 ` Conor Dooley
2024-03-06 18:32 ` Charlie Jenkins
2024-03-06 18:32 ` Charlie Jenkins
2024-03-06 18:35 ` Conor Dooley
2024-03-06 18:35 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zei1Ac8RKNJu01Fs@ghost \
--to=charlie@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=ebiggers@kernel.org \
--cc=evan@rivosinc.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lohr85@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.