From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Igor Pylypiv <ipylypiv@google.com>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Hannes Reinecke <hare@suse.de>,
Xiang Chen <chenxiang66@hisilicon.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
TJ Adams <tadamsjr@google.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers
Date: Tue, 12 Mar 2024 16:37:01 +0100 [thread overview]
Message-ID: <ZfB2nTnzDqIgb65V@ryzen> (raw)
In-Reply-To: <35801735-1e6a-43ef-8687-06ff04d53619@kernel.org>
On Tue, Mar 12, 2024 at 03:17:43PM +0900, Damien Le Moal wrote:
> On 2024/03/08 19:03, Niklas Cassel wrote:
> >
> > Anyway, like you said, as you are now creating helper functions:
> > ata_ncq_prio_supported(), ata_ncq_prio_enabled(), ata_ncq_prio_enable()
> > these function might no longer only be called from sysfs code,
> > so it is probably a bad idea to let these functions use spin_lock_irq().
> >
> > However, can't ata_ncq_prio_supported() and ata_ncq_prio_enabled()
> > still use a simple spin_lock(), why would they need to disable irqs?
> >
> > Damien, you are the author of ata_ncq_prio_supported_show(), thoughts?
>
> See above. The spin lock irq-disabling variant is needed because the port lock
> is taken from command completion context.
Yes of course, I don't know what I was thinking...
next prev parent reply other threads:[~2024-03-12 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 21:44 [PATCH v8 0/7] NCQ Priority sysfs sttributes for libsas Igor Pylypiv
2024-03-07 21:44 ` [PATCH v8 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers Igor Pylypiv
2024-03-08 10:03 ` Niklas Cassel
2024-03-12 6:17 ` Damien Le Moal
2024-03-12 15:37 ` Niklas Cassel [this message]
2024-03-12 15:37 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices Igor Pylypiv
2024-03-08 10:10 ` Niklas Cassel
2024-03-26 9:53 ` Geert Uytterhoeven
2024-03-26 10:05 ` Damien Le Moal
2024-03-26 10:06 ` Damien Le Moal
2024-03-26 10:16 ` Geert Uytterhoeven
2024-03-26 11:52 ` Damien Le Moal
2024-03-07 21:44 ` [PATCH v8 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group Igor Pylypiv
2024-03-07 21:44 ` [PATCH v8 4/7] scsi: mvsas: " Igor Pylypiv
2024-03-08 10:09 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 5/7] scsi: hisi_sas: " Igor Pylypiv
2024-03-08 10:09 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 6/7] scsi: aic94xx: " Igor Pylypiv
2024-03-08 10:10 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 7/7] scsi: isci: " Igor Pylypiv
2024-03-25 20:02 ` [PATCH v8 0/7] NCQ Priority sysfs sttributes for libsas Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfB2nTnzDqIgb65V@ryzen \
--to=cassel@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=bvanassche@acm.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.