From: Niklas Cassel <cassel@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Hannes Reinecke <hare@suse.de>,
Xiang Chen <chenxiang66@hisilicon.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
TJ Adams <tadamsjr@google.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers
Date: Tue, 12 Mar 2024 16:37:42 +0100 [thread overview]
Message-ID: <ZfB2xrTOuNrrl2Q8@ryzen> (raw)
In-Reply-To: <20240307214418.3812290-2-ipylypiv@google.com>
On Thu, Mar 07, 2024 at 01:44:12PM -0800, Igor Pylypiv wrote:
> Export libata NCQ Priority configuration helpers to be reused
> for libsas managed SATA devices.
>
> Switched locking from spin_lock_irq() to spin_lock_irqsave().
> In the future someone might call these helper functions when interrupts
> are disabled. spin_unlock_irq() could lead to a premature re-enabling
> of interrupts, whereas spin_unlock_irqrestore() restores the interrupt
> state to its condition prior to the spin_lock_irqsave() call.
>
> Acked-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2024-03-12 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 21:44 [PATCH v8 0/7] NCQ Priority sysfs sttributes for libsas Igor Pylypiv
2024-03-07 21:44 ` [PATCH v8 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers Igor Pylypiv
2024-03-08 10:03 ` Niklas Cassel
2024-03-12 6:17 ` Damien Le Moal
2024-03-12 15:37 ` Niklas Cassel
2024-03-12 15:37 ` Niklas Cassel [this message]
2024-03-07 21:44 ` [PATCH v8 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices Igor Pylypiv
2024-03-08 10:10 ` Niklas Cassel
2024-03-26 9:53 ` Geert Uytterhoeven
2024-03-26 10:05 ` Damien Le Moal
2024-03-26 10:06 ` Damien Le Moal
2024-03-26 10:16 ` Geert Uytterhoeven
2024-03-26 11:52 ` Damien Le Moal
2024-03-07 21:44 ` [PATCH v8 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group Igor Pylypiv
2024-03-07 21:44 ` [PATCH v8 4/7] scsi: mvsas: " Igor Pylypiv
2024-03-08 10:09 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 5/7] scsi: hisi_sas: " Igor Pylypiv
2024-03-08 10:09 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 6/7] scsi: aic94xx: " Igor Pylypiv
2024-03-08 10:10 ` Niklas Cassel
2024-03-07 21:44 ` [PATCH v8 7/7] scsi: isci: " Igor Pylypiv
2024-03-25 20:02 ` [PATCH v8 0/7] NCQ Priority sysfs sttributes for libsas Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfB2xrTOuNrrl2Q8@ryzen \
--to=cassel@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=bvanassche@acm.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.