From: Andrea della Porta <andrea.porta@suse.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Saenz Julienne <nsaenz@kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com
Subject: Re: [PATCH v2 13/15] dt-bindings: dma: Added bcm2711-dma
Date: Wed, 13 Mar 2024 16:16:36 +0100 [thread overview]
Message-ID: <ZfHDVCK71tuhcpv-@apocalypse> (raw)
In-Reply-To: <cd4fb265-8788-4309-9d9e-9676d76c1fe8@linaro.org>
On 17:17 Tue 12 Mar , Krzysztof Kozlowski wrote:
> On 12/03/2024 10:12, Andrea della Porta wrote:
> > Add BCM2711 dma engine compatible.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > index c9b9a5490826..4271a6fedf54 100644
> > --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > @@ -20,7 +20,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: brcm,bcm2835-dma
> > + enum:
> > + - brcm,bcm2835-dma
> > + - brcm,bcm2711-dma
>
> Please keep the entries alphabetically sorted. Probably same comment
> applies to your driver device ID table.
>
> With sorting fixed:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Sure, I'll fix the order in the next version, after collecting guidelines for dma_map_resource()
issue. Please ignore the patchset sent today since it still contains the dt binding in
the incorrect order: thge patchset has been sent as is just to reach all teh parties since it
was splitted due to a problem with my imap server.
> Best regards,
> Krzysztof
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea della Porta <andrea.porta@suse.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Saenz Julienne <nsaenz@kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dave.stevenson@raspberrypi.com
Subject: Re: [PATCH v2 13/15] dt-bindings: dma: Added bcm2711-dma
Date: Wed, 13 Mar 2024 16:16:36 +0100 [thread overview]
Message-ID: <ZfHDVCK71tuhcpv-@apocalypse> (raw)
In-Reply-To: <cd4fb265-8788-4309-9d9e-9676d76c1fe8@linaro.org>
On 17:17 Tue 12 Mar , Krzysztof Kozlowski wrote:
> On 12/03/2024 10:12, Andrea della Porta wrote:
> > Add BCM2711 dma engine compatible.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > index c9b9a5490826..4271a6fedf54 100644
> > --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
> > @@ -20,7 +20,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: brcm,bcm2835-dma
> > + enum:
> > + - brcm,bcm2835-dma
> > + - brcm,bcm2711-dma
>
> Please keep the entries alphabetically sorted. Probably same comment
> applies to your driver device ID table.
>
> With sorting fixed:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Sure, I'll fix the order in the next version, after collecting guidelines for dma_map_resource()
issue. Please ignore the patchset sent today since it still contains the dt binding in
the incorrect order: thge patchset has been sent as is just to reach all teh parties since it
was splitted due to a problem with my imap server.
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-13 15:16 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 14:08 [PATCH v2 00/15] dmaengine: bcm2835: add BCM2711 40-bit DMA support Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-12 17:16 ` Dave Stevenson
2024-03-12 17:16 ` Dave Stevenson
2024-03-13 14:33 ` Andrea della Porta
2024-03-13 14:33 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 15:00 ` Florian Fainelli
2024-03-13 15:00 ` Florian Fainelli
2024-03-13 15:26 ` Andrea della Porta
2024-03-13 15:26 ` Andrea della Porta
2024-03-13 16:38 ` Florian Fainelli
2024-03-13 16:38 ` Florian Fainelli
2024-03-13 16:49 ` Andrea della Porta
2024-03-13 16:49 ` Andrea della Porta
2024-03-13 17:14 ` Florian Fainelli
2024-03-13 17:14 ` Florian Fainelli
2024-03-13 14:08 ` [PATCH v2 02/15] dmaengine: bcm2835: Add support for per-channel flags Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-17 12:55 ` Stefan Wahren
2024-03-17 12:55 ` Stefan Wahren
2024-03-13 14:08 ` [PATCH v2 03/15] dmaengine: bcm2835: Add NO_WAIT_RESP, DMA_WIDE_SOURCE and DMA_WIDE_DEST flag Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 04/15] dmaengine: bcm2835: Support dma flags for multi-beat burst Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 05/15] dmaengine: bcm2835: Fixes for dma_abort Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 06/15] dmaengine: bcm2835: Support common dma-channel-mask Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 07/15] dmaengine: bcm2835: move CB info generation into separate function Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 08/15] dmaengine: bcm2835: move CB final extra info generation into function Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 09/15] dmaengine: bcm2835: make address increment platform independent Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 10/15] dmaengine: bcm2385: drop info parameters Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 11/15] dmaengine: bcm2835: pass dma_chan to generic functions Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 12/15] dmaengine: bcm2835: introduce multi platform support Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-12 17:05 ` Dave Stevenson
2024-03-12 17:05 ` Dave Stevenson
2024-03-13 14:49 ` Andrea della Porta
2024-03-13 14:49 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 13/15] dt-bindings: dma: Added bcm2711-dma Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-12 16:17 ` Krzysztof Kozlowski
2024-03-12 16:17 ` Krzysztof Kozlowski
2024-03-13 15:16 ` Andrea della Porta [this message]
2024-03-13 15:16 ` Andrea della Porta
2024-03-13 14:08 ` [PATCH v2 14/15] dmaengine: bcm2835: Add BCM2711 40-bit DMA support Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-03-17 12:38 ` Stefan Wahren
2024-03-17 12:38 ` Stefan Wahren
2024-03-13 14:08 ` [PATCH v2 15/15] ARM: dts: bcm2711: add bcm2711-dma node Andrea della Porta
2024-03-13 14:08 ` Andrea della Porta
2024-04-14 6:26 ` Krzysztof Kozlowski
2024-04-14 6:26 ` Krzysztof Kozlowski
2024-04-29 14:13 ` Andrea della Porta
2024-04-29 14:13 ` Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfHDVCK71tuhcpv-@apocalypse \
--to=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.