Re: [linux-next:master 12265/12944] arch/arm64/include/asm/pgtable.h:904:16: error: implicit declaration of function 'pud_leaf'; did you mean 'pmd_leaf'?

[Peter Xu <peterx@redhat.com>]

On Thu, Mar 14, 2024 at 05:09:12PM +0800, Yujie Liu wrote:
> Hi Peter,
> 
> On Mon, Mar 11, 2024 at 12:19:32PM -0400, Peter Xu wrote:
> > On Sun, Mar 10, 2024 at 04:10:37PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
> > > commit: 924bd6a8c96767a05323d575bdefd664631dce73 [12265/12944] mm/x86: drop two unnecessary pud_leaf() definitions
> > > config: arm64-randconfig-r031-20230409 (https://download.01.org/0day-ci/archive/20240310/202403101607.a42gaLOS-lkp@intel.com/config)
> > > compiler: aarch64-linux-gcc (GCC) 13.2.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240310/202403101607.a42gaLOS-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202403101607.a42gaLOS-lkp@intel.com/
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from include/linux/pgtable.h:6,
> > >                     from arch/arm64/include/asm/io.h:12,
> > >                     from include/linux/io.h:13,
> > >                     from include/acpi/acpi_io.h:5,
> > >                     from include/linux/acpi.h:39,
> > >                     from include/acpi/apei.h:9,
> > >                     from include/acpi/ghes.h:5,
> > >                     from include/linux/arm_sdei.h:8,
> > >                     from arch/arm64/kernel/asm-offsets.c:10:
> > >    arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page':
> > > >> arch/arm64/include/asm/pgtable.h:904:16: error: implicit declaration of function 'pud_leaf'; did you mean 'pmd_leaf'? [-Werror=implicit-function-declaration]
> > >      904 |         return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud));
> > >          |                ^~~~~~~~
> > >          |                pmd_leaf
> > >    cc1: some warnings being treated as errors
> > >    make[3]: *** [scripts/Makefile.build:116: arch/arm64/kernel/asm-offsets.s] Error 1
> > >    make[3]: Target 'prepare' not remade because of errors.
> > >    make[2]: *** [Makefile:1199: prepare0] Error 2
> > >    make[2]: Target 'prepare' not remade because of errors.
> > >    make[1]: *** [Makefile:240: __sub-make] Error 2
> > >    make[1]: Target 'prepare' not remade because of errors.
> > >    make: *** [Makefile:240: __sub-make] Error 2
> > >    make: Target 'prepare' not remade because of errors.
> > > 
> > > 
> > > vim +904 arch/arm64/include/asm/pgtable.h
> > > 
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  901  
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  902  static inline bool pud_user_accessible_page(pud_t pud)
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  903  {
> > > 730a11f982e61a Liu Shixin   2022-11-22 @904  	return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud));
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  905  }
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  906  #endif
> > > ed928a3402d8a2 Tong Tiangen 2022-05-17  907  
> > > 
> > 
> > There's another possibly relevant report for riscv:
> > 
> > https://lore.kernel.org/r/202403090900.OwPqmRuI-lkp@intel.com
> > 
> > I think I messed up the nopmd use case.  Since this commit already landed
> > mm-stable, I assume there's no way I provide a fixup.
> > 
> > I attached a formal patch below, but I don't know how to test it myself,
> > and I'm not 100% confident.  Before I post a formal patch, can anyone let
> > me know how I can kickoff the test bot to test the patch (or help me do the
> > kickoff)?
> 
> It is recommended to firstly follow the "reproduce" link in the report
> to see if the issue can be reproduced.
> 
>   reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240310/202403101607.a42gaLOS-lkp@intel.com/reproduce)
> 
> Then please apply the fix patch and rerun the build command to see if
> the issue is gone.
> 
> The kernel test robot sends reports when catching any new issues, but
> the bot is not yet able to test whether a patch can fix a previously
> reported issue.

Yujie,

I see, thanks for the information!

-- 
Peter Xu