[PATCH] Add Asus VivoBook S 16X to quirks table for acp6x

[PATCH] Add Asus VivoBook S 16X to quirks table for acp6x

[marcel]

This patch enables microphone driver on Asus Vivobook S 16X laptop by 
adding it to quirks table.

Signed-off-by: Marcel Geraltowski <marcelg@gmx.com>

- - -

--- sound/sound/soc/amd/yc/acp6x-mach.c.orig    2024-02-05 
10:26:11.123897233 +0800
+++ sound/sound/soc/amd/yc/acp6x-mach.c    2024-02-05 11:04:40.554566909 
+0800
@@ -262,6 +262,13 @@ static const struct dmi_system_id yc_acp
              DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
          }
      },
+        {
+                .driver_data = &acp6x_card,
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER 
INC."),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
+                }
+        },
      {
          .driver_data = &acp6x_card,
          .matches = {

Re: [PATCH] Add Asus VivoBook S 16X to quirks table for acp6x

[Geraldo Nascimento]

On Mon, Feb 05, 2024 at 11:48:31AM +0800, marcel wrote:
> This patch enables microphone driver on Asus Vivobook S 16X laptop by 
> adding it to quirks table.
> 
> Signed-off-by: Marcel Geraltowski <marcelg@gmx.com>

Hi Marcel, thanks for the patch.

Remember to add the correct subsystem and driver name just after the
[PATCH v?] subject. While the change in and of itself is OK, you sorted
it, etc., your MUA ate the tab characters and replaced it with spaces.
This is a big no-no.

Also remember to add the maintainers to the Cc:, in this case Jaroslav
Kysela and Takashi Iwai. Failure to do that may result in unnoticed and
thus missing patches.

Thank you,
Geraldo Nascimento
> 
> - - -
> 
> --- sound/sound/soc/amd/yc/acp6x-mach.c.orig    2024-02-05 
> 10:26:11.123897233 +0800
> +++ sound/sound/soc/amd/yc/acp6x-mach.c    2024-02-05 11:04:40.554566909 
> +0800
> @@ -262,6 +262,13 @@ static const struct dmi_system_id yc_acp
>               DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
>           }
>       },
> +        {
> +                .driver_data = &acp6x_card,
> +                .matches = {
> +                        DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER 
> INC."),
> +                        DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> +                }
> +        },
>       {
>           .driver_data = &acp6x_card,
>           .matches = {
> 

Re: [PATCH] Add Asus VivoBook S 16X to quirks table for acp6x

[Geraldo Nascimento]

On Tue, Mar 19, 2024 at 05:16:10PM +0800, marcel wrote:
> Hi again,
> 
> it's been a while since i sent my patch and I still can't see it in
> kernel on github, so there's my question because I'm not sure if I
> understand correctly. Should I just wait a little bit more and it just
> takes time or send patch again and change things you pointed? Also which
> version should I type after [PATCH v...], "1" ? Because it's my first
> attempt? Sorry for taking your time and if the questions are obvious,
> but it's my first time doing something like this.

Hi Marcel, please address my past concerns regarding your patch and
resubmit as v2.

Remember to Cc: Takashi Iwai and Jaroslav Kysela besides linux-sound
mailing list or your patch will fall into limbo again, overlooked by the
maintainers.

There's also a get_maintainers.pl script in the linux tree. You might
wanna use that as it adds some relevant people who might take a interest
in your patch.

Thanks,
Geraldo Nascimento

> 
> Greetings