From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Jyoti Bhayana <jbhayana@google.com>,
Chris Down <chris@chrisdown.name>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: backend: make use of dev_errp_probe()
Date: Thu, 4 Apr 2024 15:23:13 +0300 [thread overview]
Message-ID: <Zg6bsS3WMvp-nY3S@smile.fi.intel.com> (raw)
In-Reply-To: <20240404-dev-add_dev_errp_probe-v1-3-d18e3eb7ec3f@analog.com>
On Thu, Apr 04, 2024 at 01:06:25PM +0200, Nuno Sa wrote:
> Using dev_errp_probe() to simplify the code.
...
> + if (IS_ERR(fwnode))
> + return dev_errp_probe(dev, PTR_ERR(fwnode),
> + "Cannot get Firmware reference\n");
ERR_CAST() seems quite good candidate to have here.
return dev_errp_probe(dev, fwnode, "Cannot get Firmware reference\n");
(Assuming dev_errp_probe() magically understands that, note you may have it as
a macro and distinguish parameter type with _Generic() or so and behave
differently: ERR_PTR() vs. ERR_CAST(), see acpi_dev_hid_uid_match()
implementation, but also keep in mind that it doesn't distinguish NULL/0, there
is a patch available in the mailing list to fix that, though.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-04 12:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 11:06 [PATCH 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa
2024-04-04 11:06 ` [PATCH 1/4] dev_printk: add new " Nuno Sa
2024-04-06 18:35 ` Andi Shyti
2024-04-08 8:57 ` Nuno Sá
2024-04-04 11:06 ` [PATCH 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa
2024-04-04 12:18 ` Andy Shevchenko
2024-04-06 18:38 ` Andi Shyti
2024-04-04 11:06 ` [PATCH 3/4] iio: backend: make use of dev_errp_probe() Nuno Sa
2024-04-04 12:23 ` Andy Shevchenko [this message]
2024-04-04 14:58 ` Nuno Sá
2024-04-04 15:12 ` Andy Shevchenko
2024-04-06 16:07 ` Jonathan Cameron
2024-04-06 18:54 ` Andi Shyti
2024-04-08 9:05 ` Nuno Sá
2024-04-08 9:01 ` Nuno Sá
2024-04-04 11:06 ` [PATCH 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa
2024-04-04 12:15 ` [PATCH 0/4] dev_printk: add dev_errp_probe() helper Andy Shevchenko
2024-04-04 12:18 ` Andy Shevchenko
2024-04-04 15:03 ` Nuno Sá
2024-04-04 15:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg6bsS3WMvp-nY3S@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.