From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Jyoti Bhayana <jbhayana@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chris Down <chris@chrisdown.name>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/4] dev_printk: add new dev_errp_probe() helper
Date: Mon, 08 Apr 2024 10:57:02 +0200 [thread overview]
Message-ID: <a13678652cf7f06bb40d78182b02c1398ef06119.camel@gmail.com> (raw)
In-Reply-To: <42sw4ugekugyqzjylsci6tvw5zfxlwz6ypnetnau6dyqnrqfiq@5jde2w4etpfh>
On Sat, 2024-04-06 at 20:35 +0200, Andi Shyti wrote:
> Hi Nuno,
>
> ...
>
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */
> > +#define dev_errp_probe(dev, ___err, fmt, ...) ({ \
> > + ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__)); \
> > +})
>
> I have a whole series adding a set of error oriente printk's. But
> for the time being this looks OK.
>
> I just don't like the name, the 'p' is an important detail, but
> a bit hidden... how about dev_err_ptr_probe(...)?
>
Agreed, not a very good name indeed.
- Nuno Sá
next prev parent reply other threads:[~2024-04-08 8:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 11:06 [PATCH 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa
2024-04-04 11:06 ` [PATCH 1/4] dev_printk: add new " Nuno Sa
2024-04-06 18:35 ` Andi Shyti
2024-04-08 8:57 ` Nuno Sá [this message]
2024-04-04 11:06 ` [PATCH 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa
2024-04-04 12:18 ` Andy Shevchenko
2024-04-06 18:38 ` Andi Shyti
2024-04-04 11:06 ` [PATCH 3/4] iio: backend: make use of dev_errp_probe() Nuno Sa
2024-04-04 12:23 ` Andy Shevchenko
2024-04-04 14:58 ` Nuno Sá
2024-04-04 15:12 ` Andy Shevchenko
2024-04-06 16:07 ` Jonathan Cameron
2024-04-06 18:54 ` Andi Shyti
2024-04-08 9:05 ` Nuno Sá
2024-04-08 9:01 ` Nuno Sá
2024-04-04 11:06 ` [PATCH 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa
2024-04-04 12:15 ` [PATCH 0/4] dev_printk: add dev_errp_probe() helper Andy Shevchenko
2024-04-04 12:18 ` Andy Shevchenko
2024-04-04 15:03 ` Nuno Sá
2024-04-04 15:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13678652cf7f06bb40d78182b02c1398ef06119.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.