From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
Date: Thu, 28 Mar 2024 18:21:26 +0800 [thread overview]
Message-ID: <ZgVEpt7pOzNK2wrM@intel.com> (raw)
In-Reply-To: <20240325141422.1380087-2-pbonzini@redhat.com>
Hi Paolo,
Just meet typos when compiling ;-)
On Mon, Mar 25, 2024 at 03:14:20PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:20 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
> X-Mailer: git-send-email 2.44.0
[snip]
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index b1dcb3857f0..67e8b0b05e8 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -859,14 +859,26 @@ bool css_migration_enabled(void)
> } \
> type_init(ccw_machine_register_##suffix)
>
> +static void ccw_machine_9_1_instance_options(MachineState *machine)
> +{
> +}
> +
> +static void ccw_machine_9_1_class_options(MachineClass *mc)
> +{
> +}
> +DEFINE_CCW_MACHINE(9_0, "9.1", true);
Should be:
DEFINE_CCW_MACHINE(9_1, "9.1", true);
> +
> static void ccw_machine_9_0_instance_options(MachineState *machine)
> {
> + ccw_machine_9_1_instance_options(machine);
> }
>
> static void ccw_machine_9_0_class_options(MachineClass *mc)
> {
> + ccw_machine_9_1_class_options(machine);
s/machine/mc/
Regards,
Zhao
next prev parent reply other threads:[~2024-03-28 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 14:14 [PATCH for-9.1 v5 0/3] kvm: add support for guest physical bits Paolo Bonzini
2024-03-25 14:14 ` [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1 Paolo Bonzini
2024-03-25 15:02 ` Cornelia Huck
2024-03-25 15:07 ` Thomas Huth
2024-03-26 10:10 ` Harsh Prateek Bora
2024-03-27 7:57 ` Zhao Liu
2024-03-28 10:21 ` Zhao Liu [this message]
2024-03-29 12:54 ` Paolo Bonzini
2024-03-25 14:14 ` [PATCH for-9.1 v5 2/3] target/i386: add guest-phys-bits cpu property Paolo Bonzini
2024-03-27 3:00 ` Xiaoyao Li
2024-03-27 8:05 ` Zhao Liu
2024-03-25 14:14 ` [PATCH for-9.1 v5 3/3] kvm: add support for guest physical bits Paolo Bonzini
2024-03-27 8:21 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgVEpt7pOzNK2wrM@intel.com \
--to=zhao1.liu@intel.com \
--cc=cohuck@redhat.com \
--cc=gshan@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.