All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display_debugfs: Remove check for crtc in force bigjoiner
@ 2024-03-28 14:14 Ankit Nautiyal
  2024-03-28 14:37 ` Joshi, Kunal1
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ankit Nautiyal @ 2024-03-28 14:14 UTC (permalink / raw)
  To: intel-gfx; +Cc: ville.syrjala, kunal1.joshi

At the moment, we allow force joiner debugs to work only for connector
with status connected and a crtc attached to it.
This creates a problem when we force bigjoiner and then pipe gets reset
before the force bigjoiner is disabled.
Relax the condition to check for crtc while exposing the debugfs.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index b99c024b0934..94bc9e0d30fe 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1405,10 +1405,8 @@ out:	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
 static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)
 {
 	struct intel_connector *connector = m->private;
-	struct drm_crtc *crtc;
 
-	crtc = connector->base.state->crtc;
-	if (connector->base.status != connector_status_connected || !crtc)
+	if (connector->base.status != connector_status_connected)
 		return -ENODEV;
 
 	seq_printf(m, "Bigjoiner enable: %d\n", connector->force_bigjoiner_enable);
@@ -1443,12 +1441,10 @@ static ssize_t i915_bigjoiner_enable_write(struct file *file,
 {
 	struct seq_file *m = file->private_data;
 	struct intel_connector *connector = m->private;
-	struct drm_crtc *crtc;
 	bool bigjoiner_en = 0;
 	int ret;
 
-	crtc = connector->base.state->crtc;
-	if (connector->base.status != connector_status_connected || !crtc)
+	if (connector->base.status != connector_status_connected)
 		return -ENODEV;
 
 	ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-29 22:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-28 14:14 [PATCH] drm/i915/display_debugfs: Remove check for crtc in force bigjoiner Ankit Nautiyal
2024-03-28 14:37 ` Joshi, Kunal1
2024-03-28 17:28 ` Ville Syrjälä
2024-03-29  3:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-03-29 22:45 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.