From: Vinod Koul <vkoul@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: konrad.dybcio@linaro.org, andersson@kernel.org, wsa@kernel.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
quic_vdadhani@quicinc.com,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode
Date: Fri, 29 Mar 2024 22:15:24 +0530 [thread overview]
Message-ID: <ZgbwJAb7Ffktf554@matsya> (raw)
In-Reply-To: <171161140136.2698925.4294566764047886777.b4-ty@kernel.org>
On 28-03-24, 08:36, Andi Shyti wrote:
> Hi
>
> On Wed, 13 Mar 2024 10:56:39 +0530, Mukesh Kumar Savaliya wrote:
> > I2C driver currently reports "DMA txn failed" error even though it's
> > NACK OR BUS_PROTO OR ARB_LOST. Detect NACK error when no device ACKs
> > on the bus instead of generic transfer failure which doesn't give any
> > specific clue.
> >
> > Make Changes inside i2c driver callback handler function
> > i2c_gpi_cb_result() to parse these errors and make sure GSI driver
> > stores the error status during error interrupt.
> >
> > [...]
>
> Applied to i2c/i2c-host-next on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/local tree
You applied changes to dmaengine driver without my ack! I dont agree to
the approach here, we could do better
--
~Vinod
next prev parent reply other threads:[~2024-03-29 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 5:26 [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode Mukesh Kumar Savaliya
2024-03-28 7:24 ` Vinod Koul
2024-03-28 7:36 ` Andi Shyti
2024-03-29 16:45 ` Vinod Koul [this message]
2024-03-29 23:54 ` Andi Shyti
2024-04-03 6:31 ` Krzysztof Kozlowski
2024-04-02 16:44 ` Andi Shyti
2024-04-03 6:09 ` Mukesh Kumar Savaliya
2024-04-03 6:33 ` Krzysztof Kozlowski
2024-04-07 8:12 ` Vinod Koul
2024-04-16 15:05 ` Andi Shyti
2024-04-17 16:57 ` Vinod Koul
2024-04-18 9:49 ` Andi Shyti
2024-04-03 6:46 ` Mukesh Kumar Savaliya
2024-04-03 9:14 ` Krzysztof Kozlowski
2024-04-07 8:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgbwJAb7Ffktf554@matsya \
--to=vkoul@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.