From: Vinod Koul <vkoul@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: konrad.dybcio@linaro.org, andersson@kernel.org, wsa@kernel.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
quic_vdadhani@quicinc.com,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode
Date: Wed, 17 Apr 2024 22:27:52 +0530 [thread overview]
Message-ID: <Zh__kAdzU8a2DHLH@matsya> (raw)
In-Reply-To: <j3zupurwq5vtzfwby7ubl7ft75fqqhutk4vfqolihkcldfcesi@ywwfnkjcfhgu>
On 16-04-24, 17:05, Andi Shyti wrote:
> > > Anyway, the changes are in -next. What do we do now? Do I revert
> > > it? Mukesh, can you please agree with Vinod?
> >
> > I dont apply patches to other subsystem without the ack. Either way you
> > can ask always!
>
> Yes, you are totally right; but please, keep in mind that this
> patch has some history and I would have loved to hear from you
> earlier. Anyway...
There was merge window, I dont look up during that. Then I had some
family stuff and travel to take care... Things happen.
When in doubt pls ask, a gentle reminder goes long way!
>
> > I will leave it upto you...
>
> ... Mukesh, I'm sorry, but I'm going to revert this patch again
> until we address all the last minute issues from Vinod. The
> silence on this thread is worrying me more than reverting it.
>
> I hope this will be the last time I revert this patch.
>
> Moreover, in order to avoid maintainers' rumble (:)), please
> let's try to split patches that are touching more than one
> subsystems keeping the logical meainings intact.
That is best. Very rarely we have a situation where we add
changes which break bisect and it has to be clubbed together. But for
other cases, it should always be split!
> I hope this is fine with you, Vinod.
Thank you for understanding
--
~Vinod
next prev parent reply other threads:[~2024-04-17 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 5:26 [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode Mukesh Kumar Savaliya
2024-03-28 7:24 ` Vinod Koul
2024-03-28 7:36 ` Andi Shyti
2024-03-29 16:45 ` Vinod Koul
2024-03-29 23:54 ` Andi Shyti
2024-04-03 6:31 ` Krzysztof Kozlowski
2024-04-02 16:44 ` Andi Shyti
2024-04-03 6:09 ` Mukesh Kumar Savaliya
2024-04-03 6:33 ` Krzysztof Kozlowski
2024-04-07 8:12 ` Vinod Koul
2024-04-16 15:05 ` Andi Shyti
2024-04-17 16:57 ` Vinod Koul [this message]
2024-04-18 9:49 ` Andi Shyti
2024-04-03 6:46 ` Mukesh Kumar Savaliya
2024-04-03 9:14 ` Krzysztof Kozlowski
2024-04-07 8:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh__kAdzU8a2DHLH@matsya \
--to=vkoul@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.