[Buildroot] [PATCH 1/1] support/testing: fix trace-cmd runtime test

[Buildroot] [PATCH 1/1] support/testing: fix trace-cmd runtime test

[Julien Olivain]

The trace-cmd runtime test has a typo and fails with output:

    Traceback (most recent call last):
      File "/build/buildroot/support/testing/tests/package/test_trace_cmd.py", line 53, in test_run
        self.assertEquals(exit_code, 0)
        ^^^^^^^^^^^^^^^^^
    AttributeError: 'TestTraceCmd' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

The issue can be reproduced with the command:

    support/testing/run-tests \
        -d dl -o output_test \
        tests.package.test_trace_cmd

This commit fixes the issue by removing the extra 's'.

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 support/testing/tests/package/test_trace_cmd.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/package/test_trace_cmd.py b/support/testing/tests/package/test_trace_cmd.py
index e7d5e13bce8..5d37aef375f 100644
--- a/support/testing/tests/package/test_trace_cmd.py
+++ b/support/testing/tests/package/test_trace_cmd.py
@@ -50,5 +50,5 @@ class TestTraceCmd(infra.basetest.BRTest):
         # Check we have occurrences of "kmalloc:" in the trace report.
         cmd = "grep -Fc kmalloc: trace.txt"
         output, exit_code = self.emulator.run(cmd)
-        self.assertEquals(exit_code, 0)
+        self.assertEqual(exit_code, 0)
         self.assertTrue(int(output[0]) > 0)
-- 
2.44.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/testing: fix trace-cmd runtime test

[Yann E. MORIN]

Julien, all,

On 2024-04-01 19:20 +0200, Julien Olivain spake thusly:
> The trace-cmd runtime test has a typo and fails with output:
> 
>     Traceback (most recent call last):
>       File "/build/buildroot/support/testing/tests/package/test_trace_cmd.py", line 53, in test_run
>         self.assertEquals(exit_code, 0)
>         ^^^^^^^^^^^^^^^^^
>     AttributeError: 'TestTraceCmd' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
> 
> The issue can be reproduced with the command:
> 
>     support/testing/run-tests \
>         -d dl -o output_test \
>         tests.package.test_trace_cmd
> 
> This commit fixes the issue by removing the extra 's'.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  support/testing/tests/package/test_trace_cmd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/package/test_trace_cmd.py b/support/testing/tests/package/test_trace_cmd.py
> index e7d5e13bce8..5d37aef375f 100644
> --- a/support/testing/tests/package/test_trace_cmd.py
> +++ b/support/testing/tests/package/test_trace_cmd.py
> @@ -50,5 +50,5 @@ class TestTraceCmd(infra.basetest.BRTest):
>          # Check we have occurrences of "kmalloc:" in the trace report.
>          cmd = "grep -Fc kmalloc: trace.txt"
>          output, exit_code = self.emulator.run(cmd)
> -        self.assertEquals(exit_code, 0)
> +        self.assertEqual(exit_code, 0)
>          self.assertTrue(int(output[0]) > 0)
> -- 
> 2.44.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/testing: fix trace-cmd runtime test

[Peter Korsgaard]

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > The trace-cmd runtime test has a typo and fails with output:
 >     Traceback (most recent call last):
 >       File "/build/buildroot/support/testing/tests/package/test_trace_cmd.py", line 53, in test_run
 >         self.assertEquals(exit_code, 0)
 >         ^^^^^^^^^^^^^^^^^
 >     AttributeError: 'TestTraceCmd' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

 > The issue can be reproduced with the command:

 >     support/testing/run-tests \
 >         -d dl -o output_test \
 >         tests.package.test_trace_cmd

 > This commit fixes the issue by removing the extra 's'.

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot