From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ran Wang <ran.wang_1@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: nvidia: drop driver owner assignment
Date: Tue, 2 Apr 2024 13:11:31 +0300 [thread overview]
Message-ID: <ZgvZ07U+DFcPATII@kuha.fi.intel.com> (raw)
In-Reply-To: <20240327174609.519252-2-krzysztof.kozlowski@linaro.org>
On Wed, Mar 27, 2024 at 06:46:09PM +0100, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/altmodes/nvidia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
> index c36769736405..fe70b36f078f 100644
> --- a/drivers/usb/typec/altmodes/nvidia.c
> +++ b/drivers/usb/typec/altmodes/nvidia.c
> @@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
> .remove = nvidia_altmode_remove,
> .driver = {
> .name = "typec_nvidia",
> - .owner = THIS_MODULE,
> },
> };
> module_typec_altmode_driver(nvidia_altmode_driver);
> --
> 2.34.1
--
heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ran Wang <ran.wang_1@nxp.com>,
linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: nvidia: drop driver owner assignment
Date: Tue, 2 Apr 2024 13:11:31 +0300 [thread overview]
Message-ID: <ZgvZ07U+DFcPATII@kuha.fi.intel.com> (raw)
In-Reply-To: <20240327174609.519252-2-krzysztof.kozlowski@linaro.org>
On Wed, Mar 27, 2024 at 06:46:09PM +0100, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/altmodes/nvidia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
> index c36769736405..fe70b36f078f 100644
> --- a/drivers/usb/typec/altmodes/nvidia.c
> +++ b/drivers/usb/typec/altmodes/nvidia.c
> @@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
> .remove = nvidia_altmode_remove,
> .driver = {
> .name = "typec_nvidia",
> - .owner = THIS_MODULE,
> },
> };
> module_typec_altmode_driver(nvidia_altmode_driver);
> --
> 2.34.1
--
heikki
next prev parent reply other threads:[~2024-04-02 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 17:46 [PATCH 1/2] usb: phy: fsl-usb: drop driver owner assignment Krzysztof Kozlowski
2024-03-27 17:46 ` [PATCH 2/2] usb: typec: nvidia: " Krzysztof Kozlowski
2024-04-02 10:11 ` Heikki Krogerus [this message]
2024-04-02 10:11 ` Heikki Krogerus
2024-04-02 10:10 ` [PATCH 1/2] usb: phy: fsl-usb: " Heikki Krogerus
2024-04-02 10:10 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgvZ07U+DFcPATII@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ran.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.