From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 01/16] serial: max3100: Lock port->lock when calling uart_handle_cts_change()
Date: Tue, 2 Apr 2024 20:14:27 +0300 [thread overview]
Message-ID: <Zgw881ApbwJrozAw@smile.fi.intel.com> (raw)
In-Reply-To: <20240402130715.7f1292b774ee0b2f056a6e95@hugovil.com>
On Tue, Apr 02, 2024 at 01:07:15PM -0400, Hugo Villeneuve wrote:
> On Tue, 2 Apr 2024 18:38:07 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> Hi Andy,
>
> > uart_handle_cts_change() has to be called with port lock taken,
> > Since we run it in a separate work, the lcok maybe not taken at
>
> lcok -> lock
>
> and possibly: "may not be taken" ?
Thanks, I'll fix this in case a new version is required.
> > the time of running. Make sure that it's taken by explicitly doing
> > that. Without it we got a splat:
> >
> > WARNING: CPU: 0 PID: 10 at drivers/tty/serial/serial_core.c:3491 uart_handle_cts_change+0xa6/0xb0
> > ...
> > Workqueue: max3100-0 max3100_work [max3100]
> > RIP: 0010:uart_handle_cts_change+0xa6/0xb0
> > ...
> > max3100_handlerx+0xc5/0x110 [max3100]
> > max3100_work+0x12a/0x340 [max3100]
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-02 17:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:38 [PATCH v1 00/16] serial: max3100: Put into shape Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 01/16] serial: max3100: Lock port->lock when calling uart_handle_cts_change() Andy Shevchenko
2024-04-02 17:07 ` Hugo Villeneuve
2024-04-02 17:14 ` Andy Shevchenko [this message]
2024-04-02 15:38 ` [PATCH v1 02/16] serial: max3100: Update uart_driver_registered on driver removal Andy Shevchenko
2024-04-02 17:18 ` Hugo Villeneuve
2024-04-02 17:31 ` Andy Shevchenko
2024-04-02 17:37 ` Hugo Villeneuve
2024-04-02 15:38 ` [PATCH v1 03/16] serial: max3100: Fix bitwise types Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 04/16] serial: max3100: Make struct plat_max3100 local Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 05/16] serial: max3100: Remove custom HW shutdown support Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 06/16] serial: max3100: Replace custom polling timeout with standard one Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 07/16] serial: max3100: Enable TIOCM_LOOP Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 08/16] serial: max3100: Get crystal frequency via device property Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 09/16] serial: max3100: Remove duplicating irq field Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 10/16] serial: max3100: Switch to use dev_err_probe() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 11/16] serial: max3100: Replace MODULE_ALIAS() with respective ID tables Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 12/16] serial: max3100: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 13/16] serial: max3100: Extract to_max3100_port() helper macro Andy Shevchenko
2024-04-02 17:32 ` Hugo Villeneuve
2024-04-02 17:40 ` Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 14/16] serial: max3100: Remove unneeded forward declaration Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 15/16] serial: max3100: Sort headers Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 16/16] serial: max3100: Update Kconfig entry Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgw881ApbwJrozAw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.